WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Improve cleanup logic for video and subtitle URLs #4945

Improve cleanup logic for video and subtitle URLs

Improve cleanup logic for video and subtitle URLs #4945

Triggered via push December 9, 2025 14:31
Status Success
Total duration 8m 47s
Artifacts

ci.yml

on: push
Detect Changes
9s
Detect Changes
Verify Tauri plugin versions
Verify Tauri plugin versions
Matrix: Build Desktop
Matrix: Clippy
Matrix: Rust cache
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
derefed type is same as origin: apps/desktop/src-tauri/src/target_select_overlay.rs#L145
warning: derefed type is same as origin --> apps\desktop\src-tauri\src\target_select_overlay.rs:145:13 | 145 | bundle_identifier.as_deref(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bundle_identifier` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_option_as_deref = note: `#[warn(clippy::needless_option_as_deref)]` on by default
function `resolve_window_ids` is never used: apps/desktop/src-tauri/src/window_exclusion.rs#L64
warning: function `resolve_window_ids` is never used --> apps\desktop\src-tauri\src\window_exclusion.rs:64:8 | 64 | pub fn resolve_window_ids(exclusions: &[WindowExclusion]) -> Vec<WindowId> { | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
unused import: `self`: apps/desktop/src-tauri/src/recording.rs#L59
warning: unused import: `self` --> apps\desktop\src-tauri\src\recording.rs:59:9 | 59 | self, GeneralSettingsStore, PostDeletionBehaviour, PostStudioRecordingBehaviour, | ^^^^
unused import: `std::error::Error as StdError`: apps/desktop/src-tauri/src/recording.rs#L34
warning: unused import: `std::error::Error as StdError` --> apps\desktop\src-tauri\src\recording.rs:34:5 | 34 | use std::error::Error as StdError; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: crates/recording/src/sources/screen_capture/mod.rs#L308
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> crates\recording\src\sources\screen_capture\mod.rs:308:41 | 308 | let output_size: PhysicalSize = crop_bounds | _________________________________________^ 309 | | .and_then(|b| -> Option<PhysicalSize> { 310 | | #[cfg(target_os = "macos")] ... | 324 | | }) | |______________^ help: try: `crop_bounds.map(|b| -> Option<PhysicalSize> b.size().map(|v| (v / 2.0).floor() * 2.0))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#bind_instead_of_map = note: `#[warn(clippy::bind_instead_of_map)]` on by default
deref which would be done by auto-deref: crates/recording/src/output_pipeline/win.rs#L285
warning: deref which would be done by auto-deref --> crates\recording\src\output_pipeline\win.rs:285:71 | 285 | ... .write_sample(&output_sample, &mut *output) | ^^^^^^^^^^^^ help: try: `&mut output` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
usage of an `Arc` that is not `Send` and `Sync`: crates/recording/src/feeds/camera.rs#L580
warning: usage of an `Arc` that is not `Send` and `Sync` --> crates\recording\src\feeds\camera.rs:580:41 | 580 | ... buffer: std::sync::Arc::new(std::sync::Mutex::new(buffer)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `Arc<Mutex<IMFMediaBuffer>>` is not `Send` and `Sync` as `Mutex<IMFMediaBuffer>` is neither `Send` nor `Sync` = help: if the `Arc` will not be used across threads replace it with an `Rc` = help: otherwise make `Mutex<IMFMediaBuffer>` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
variable does not need to be mutable: crates/recording/src/screenshot.rs#L353
warning: variable does not need to be mutable --> crates\recording\src\screenshot.rs:353:9 | 353 | let mut info = BITMAPINFO { | ----^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
unused import: `fragmented::*`: crates/recording/src/output_pipeline/mod.rs#L9
warning: unused import: `fragmented::*` --> crates\recording\src\output_pipeline\mod.rs:9:9 | 9 | pub use fragmented::*; | ^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
transmute used without annotations: crates/enc-mediafoundation/src/video/h264.rs#L216
warning: transmute used without annotations --> crates\enc-mediafoundation\src\video\h264.rs:216:31 | 216 | std::mem::transmute::<_, usize>(temp), | ^^^^^^^^^^^^^^^^^^^^^ help: consider adding missing annotations: `transmute::<windows::Win32::Media::MediaFoundation::IMFDXGIDeviceManager, usize>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#missing_transmute_annotations = note: `#[warn(clippy::missing_transmute_annotations)]` on by default