Ignore - accidental PR

[vgadodia]

Summary by CodeRabbit

• New Features

  • Workspace management system enabling organization of recordings and settings per workspace
  • Versioned video links for improved sharing and tracking
  • Flyover Camera feature architecture and implementation plan

• Updates

  • Product rebranding from Cap to Inflight throughout the application
  • Settings interface redesigned with horizontal tab navigation
  • Enhanced icon library and updated visual components

• Improvements

  • Refined window styling and transparency settings
  • Streamlined UI layout for recording controls and device selection

• Documentation

  • Comprehensive Flyover Camera feature plan documenting multi-track recording, real-time preview, and editable workflows

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR introduces a comprehensive rebranding from Cap to Inflight alongside significant feature development: workspace support replaces organization workflows, a Flyover Camera feature architecture plan is documented, video uploads now track version IDs, and the desktop UI undergoes restructuring with new icon components, settings tabs, and a redesigned recording window interface.

Changes

Cohort / File(s)	Summary
Rebranding & Infrastructure .github/workflows/publish.yml, apps/desktop/scripts/prodBeforeBundle.js, apps/desktop/src-tauri/Cargo.toml, apps/desktop/src-tauri/tauri.conf.json, apps/desktop/src-tauri/tauri.prod.conf.json, apps/desktop/src-tauri/src/tray.rs	Updated product name, binary names, identifiers, and environment variables from Cap/cap to Inflight/inflight. Removed Discord interaction handling in CI/CD. Adjusted macOS runner selection and removed final notification job.
API & Authentication Workspace Support apps/desktop/src-tauri/src/api.rs, apps/desktop/src-tauri/src/auth.rs	Added new Workspace struct and fetch_workspaces() API function. Populated AuthStore with workspaces collection, replacing organization fetching.
Recording Settings & Configuration apps/desktop/src-tauri/src/general_settings.rs, apps/desktop/src-tauri/src/recording_settings.rs, apps/desktop/src-tauri/src/deeplink_actions.rs	Added default_workspace_id to GeneralSettingsStore, workspace_id to RecordingSettingsStore and StartRecordingInputs. Changed default post-deletion behavior.
Upload & Video Handling apps/desktop/src-tauri/src/upload.rs, apps/desktop/src-tauri/src/lib.rs, apps/desktop/src-tauri/src/recording.rs, crates/project/src/meta.rs	Extended upload_video() and create_or_get_video() signatures with version_id and workspace_id parameters. Updated shareable link generation to prefer versioned paths. Added version_id to S3UploadMeta and propagated through recording finalization.
Desktop-Tauri Type Bridge apps/desktop/src/utils/tauri.ts	Updated public types for AuthStore, GeneralSettingsStore, StartRecordingInputs, RecordingSettingsStore, S3UploadMeta. Added Workspace type. Updated uploadExportedVideo() signature with workspaceId parameter.
UI Icon Components apps/desktop/src/icons.tsx	Added 20 new SVG icon components (DoubleArrowSwitcher, InflightLogo, CameraIcon, MicrophoneIcon, SystemAudioIcon, etc.).
Recording Window UI Overhaul apps/desktop/src/routes/(window-chrome)/new-main/index.tsx, apps/desktop/src/routes/(window-chrome)/new-main/CameraSelect.tsx, apps/desktop/src/routes/(window-chrome)/new-main/MicrophoneSelect.tsx, apps/desktop/src/routes/(window-chrome)/new-main/SystemAudio.tsx, apps/desktop/src/routes/(window-chrome)/new-main/HorizontalTargetButton.tsx, apps/desktop/src/routes/(window-chrome)/new-main/InfoPill.tsx, apps/desktop/src/routes/(window-chrome)/new-main/TargetTypeButton.tsx, apps/desktop/src/routes/(window-chrome).tsx	Restructured main recording window with new UI components, rounded corners, transparent windows, updated icon usage. Added HorizontalTargetButton component. Adjusted window sizing (272×394). Enhanced camera/mic selection with hover controls and ChevronDown indicators. Updated InfoPill with "on"/"off" variant styling.
Settings Pages UI Restructure apps/desktop/src/routes/(window-chrome)/settings.tsx, apps/desktop/src/routes/(window-chrome)/settings/general.tsx, apps/desktop/src/routes/(window-chrome)/settings/hotkeys.tsx, apps/desktop/src/routes/(window-chrome)/settings/recordings.tsx, apps/desktop/src/routes/(window-chrome)/settings/Setting.tsx	Replaced vertical left navigation with horizontal tab bar. Added workspace and account setting sections to general settings. Integrated workspace selection UI and sign-in mutation. Added tab indicator animation on location change.
Target & Recording Overlays apps/desktop/src/routes/target-select-overlay.tsx, apps/desktop/src/routes/in-progress-recording.tsx, apps/desktop/src/routes/recordings-overlay.tsx, apps/desktop/src/routes/editor/ExportDialog.tsx, apps/desktop/src/routes/editor/ShareButton.tsx	Replaced organization-based logic with workspace-centric flow. Added workspace selection UI and menu-driven workflows. Added workspaceId to export settings and upload calls. Extended uploadExportedVideo() calls with workspace parameter.
Window Management & Rendering apps/desktop/src-tauri/src/windows.rs	Added transparent window support for Setup, Main, Settings. Modified macOS traffic lights positioning and window button handling. Reduced InProgressRecording window from 320×150 to 208×48.
Utilities & Queries apps/desktop/src/utils/queries.ts, packages/ui-solid/src/Button.tsx	Added createWorkspacesQuery() mirroring organization query pattern. Added workspaceId to recording options state. Changed default recording mode to instant. Minor Button component formatting.
Setup & Navigation apps/desktop/src/routes/setup.tsx, apps/desktop/src/routes/camera.tsx	Rebranded all user-facing strings from Cap to Inflight. Updated permission flow descriptions. Minor formatting and inline handler adjustments.
Documentation FLYOVER_FEATURE_PLAN.md	Comprehensive architecture and implementation plan for Flyover Camera feature, including desktop recording, real-time preview, web components, and phased milestones.

Sequence Diagram

sequenceDiagram
    actor User
    participant UI as Desktop UI
    participant Tauri as Tauri Backend
    participant Settings as Settings Store
    participant Upload as Upload Service
    participant API as Backend API

    User->>UI: Start Recording with Workspace
    UI->>Settings: Load default_workspace_id & workspace list
    Settings-->>UI: Return workspaces
    UI->>Tauri: start_recording(workspace_id)
    
    Tauri->>Settings: Persist workspace_id to RecordingSettingsStore
    Tauri->>Upload: create_or_get_video(workspace_id)
    Upload->>API: POST /api/desktop/workspaces/videos?workspaceId={workspace_id}
    API-->>Upload: Return S3UploadMeta { id, version_id }
    Upload-->>Tauri: Return upload metadata
    
    Tauri->>Tauri: Process recording → generate version_id
    Tauri->>Upload: upload_video(version_id, workspace_id)
    Upload->>API: Upload to S3 with versioned path /v/{version_id}
    API-->>Upload: Confirm
    Upload-->>Tauri: Return shareable link with version
    
    Tauri-->>UI: Recording complete with versioned link
    UI->>User: Display shareable link

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Areas requiring extra attention:

• Recording flow propagation: Verify workspace_id threading through start_recording() → create_or_get_video() → upload_video() in apps/desktop/src-tauri/src/recording.rs and apps/desktop/src-tauri/src/lib.rs; ensure backward compatibility with None defaults.
• Workspace-centric refactor: Review target-select-overlay.tsx workspace selection logic and menu-driven workflows; verify organization fallback handling is completely replaced.
• Version-ID tracking: Confirm version_id propagation from video creation through upload and link generation; check all create_or_get_video() call sites for correct parameter ordering.
• UI restructuring complexity: Settings tabs implementation with dynamic indicator positioning and new icon integrations across multiple components; verify visual consistency.
• API signature changes: Multiple public function signatures extended (upload_video, create_or_get_video, uploadExportedVideo); ensure all call sites updated consistently.
• Rebranding completeness: Verify all Cap → Inflight references updated in configs, branding, and user-facing strings; check build/update URLs are correct.

Possibly related PRs

• Implement org selection #1185: Implements core workspace support infrastructure and replaces org-selection plumbing with workspace fields across AuthStore, StartRecordingInputs, and upload functions.
• New recording flow #831: Develops the "new recording flow" feature touching general_settings.rs feature flags, windows.rs routing, and new-main UI modules overlapping with this PR.
• New recording flow #933: Modifies the same desktop recording flow including recording/start workflow, target-select overlay, new-main UI, and tauri typings.

Suggested labels

codex, feat/workspaces, ui/desktop, refactor/rebranding

Suggested reviewers

• oscartbeaumont
• Brendonovich

Poem

🐰 A rabbit hops through Cap's new Inflight door,
Workspaces bloom where orgs were before,
Version IDs trace each recording's flight,
Tab bars dance with indicator light,
Icons scattered like carrots—what a sight! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdf23c8 and f78c4a2.

📒 Files selected for processing (41)

• .github/workflows/publish.yml (3 hunks)
• FLYOVER_FEATURE_PLAN.md (1 hunks)
• apps/desktop/scripts/prodBeforeBundle.js (2 hunks)
• apps/desktop/src-tauri/Cargo.toml (1 hunks)
• apps/desktop/src-tauri/src/api.rs (1 hunks)
• apps/desktop/src-tauri/src/auth.rs (3 hunks)
• apps/desktop/src-tauri/src/deeplink_actions.rs (1 hunks)
• apps/desktop/src-tauri/src/general_settings.rs (2 hunks)
• apps/desktop/src-tauri/src/lib.rs (6 hunks)
• apps/desktop/src-tauri/src/recording.rs (6 hunks)
• apps/desktop/src-tauri/src/recording_settings.rs (1 hunks)
• apps/desktop/src-tauri/src/tray.rs (1 hunks)
• apps/desktop/src-tauri/src/upload.rs (5 hunks)
• apps/desktop/src-tauri/src/windows.rs (6 hunks)
• apps/desktop/src-tauri/tauri.conf.json (1 hunks)
• apps/desktop/src-tauri/tauri.prod.conf.json (1 hunks)
• apps/desktop/src/icons.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome).tsx (4 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/CameraSelect.tsx (6 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/HorizontalTargetButton.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/InfoPill.tsx (1 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/MicrophoneSelect.tsx (8 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/SystemAudio.tsx (2 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/TargetTypeButton.tsx (2 hunks)
• apps/desktop/src/routes/(window-chrome)/new-main/index.tsx (28 hunks)
• apps/desktop/src/routes/(window-chrome)/settings.tsx (2 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/Setting.tsx (2 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/general.tsx (22 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/hotkeys.tsx (7 hunks)
• apps/desktop/src/routes/(window-chrome)/settings/recordings.tsx (16 hunks)
• apps/desktop/src/routes/(window-chrome)/setup.tsx (16 hunks)
• apps/desktop/src/routes/camera.tsx (24 hunks)
• apps/desktop/src/routes/editor/ExportDialog.tsx (36 hunks)
• apps/desktop/src/routes/editor/ShareButton.tsx (1 hunks)
• apps/desktop/src/routes/in-progress-recording.tsx (22 hunks)
• apps/desktop/src/routes/recordings-overlay.tsx (1 hunks)
• apps/desktop/src/routes/target-select-overlay.tsx (25 hunks)
• apps/desktop/src/utils/queries.ts (6 hunks)
• apps/desktop/src/utils/tauri.ts (7 hunks)
• crates/project/src/meta.rs (1 hunks)
• packages/ui-solid/src/Button.tsx (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}