[Code refactoring]: CLI code refactoring #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: Result<(),Error> now: ())
LorenzoTettamanti
added
code refactoring
added 2 commits
November 4, 2025 14:33
…, Added functions detailed documentation, removed duplicated functions. Added connect_to_client aux function to connect to kubernetes client
…ule, moved connect_to_client function to essential.rs. Code refactoring of logs.r: added docs, improved error handling
… handling, Added documentation to every function
…ntroduced InstallationError enum to group all the errors
…ng. Added documentation to every function
…etter error handling, removed duplicated functions
…on to every function, better error handling
…um to group all the error types. implemented From trait for ClientError to convert kube::Error erros in ClientError's type
…nused imports. Fixed typos in return types
…ntError type and MonitoringError types. Added From trait implermentation to convert anyhow::Error into CliError. Cargo.lock update
…main.rs for better clarity
Collaborator
|
Testing it out @LorenzoTettamanti mate! 
Things are working great 🚀🚀 |
siddh34
approved these changes
Nov 8, 2025
Member
Author
|
Thanks mate, merging the changes right now 🚀 |
LorenzoTettamanti
merged commit 5e8354a
into
CortexFlow:feature/ebpf-core
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a heavy CLI code refactoring. Code refactoring aim:
The CLI crate is now ready for improvements
Tests
Testing environments:
Command tested:
Testing scenarios: