renderer: catch shader source processing exceptions and print raw source #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
force-pushed
the
illwieckz/shader-dump
branch
from
1c9a5f2 to
09775ad
Compare
Member
|
I think we should just fix the text processing code. That code is a good candidate for unit testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch shader source processing exceptions and print raw source if something bad happened while processing the source.
See #1612:
Unhandled exception (St12length_error): basic_string::_M_replace_auxerror #1612This doesn't fix the underlying cause of the processing error, but at least the engine doesn't crash, the source get printed, the error message get printed, and it is possible to debug the GLSL shader code in some kind of degraded mode.