performance: remove unneeded ToArray calls
#2174
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
force-pushed
the
remove_toarray
branch
from
0100f84 to
3ddf8e4
Compare
mgravell
approved these changes
Jul 6, 2025
Member
mgravell
left a comment
mgravell
left a comment
There was a problem hiding this comment.
Looks good; I'll need to double check impact on the full TFM range (i.e. the older overloads), but: 👍
mkorsukov
reviewed
Dec 28, 2025
|
|
||
| // Before we get all emitty... | ||
| var lookup = string.Join("|", names.ToArray()); | ||
| var lookup = string.Join("|", names); |
There was a problem hiding this comment.
A "char" vs "string" can be used in Join() call.
Author
There was a problem hiding this comment.
I'm scared of getting nerd sniped here, but I'm pretty sure they do the same thing. string.Join(char and string.Join(string. both call JoinCore. The only difference is it converts the char into a Span via new ReadOnlySpan<char>(in separator) before calling JoinCore. Code here
I would love to know if the generated code is different between char and string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary
ToArraycalls