-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Backport 7.73.x] tests_macos_gitlab_arm64 flakiness: add go build isolation to pkgconfigusage
#43854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.73.x
Are you sure you want to change the base?
[Backport 7.73.x] tests_macos_gitlab_arm64 flakiness: add go build isolation to pkgconfigusage
#43854
Conversation
…gconfigusage` (#43773) ### What does this PR do? Add `go build` isolation to `TestAll` in `pkg/linters/components/pkgconfigusage` to reduce test timeouts on macOS CI runners. ### Motivation The test still times out occasionally ([example in `main`](http://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1267508733/viewer#L2040)) after 3 minutes on macOS Gitlab runners when running with `-p 12 -parallel 12`. `analysistest.Run` internally runs `go build` commands to verify the Go toolchain works. When multiple tests run concurrently with the same shared `GOCACHE`, they can deadlock in Go's process management layer (see golang/go#59657). ### Changes Added per-test isolated `GOCACHE`, `GOPRIVATE` and `GOPROXY`, following the same approach as PR #39687 which fixed a similar timeout issue in `comp/core/secrets/impl/fetch_secret_test.go`. ### Describe how you validated your changes Verified locally with `go test -v -race -count=20 -parallel 12 -timeout 600s`. ### Additional Notes Prior art include: - #39518 - #39687 - #43207 - #43627 💡 `-mod=vendor` could be also factored out through a future PR should the problem manifest itself again after the present change is merged.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: e40489e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | docker_containers_cpu | % cpu utilization | +13.50 | [+11.71, +15.29] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | docker_containers_cpu | % cpu utilization | +13.50 | [+11.71, +15.29] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +4.22 | [+1.37, +7.08] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.74 | [+0.50, +0.99] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.69 | [+0.62, +0.76] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.55 | [+0.40, +0.70] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.55 | [+0.36, +0.73] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.50 | [+0.45, +0.55] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.38 | [+0.29, +0.48] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.31 | [+0.27, +0.35] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.21 | [+0.17, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.16 | [+0.10, +0.22] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.12 | [-0.02, +0.25] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.05 | [-0.11, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.02 | [-0.58, +0.62] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.60, +0.62] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.19, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.04 | [-0.63, +0.55] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.04 | [-0.66, +0.57] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.08 | [-0.12, -0.04] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.17 | [-0.37, +0.03] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -2.65 | [-3.09, -2.21] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Cherry-picked from #43773.
What does this PR do?
Add
go buildisolation toTestAllinpkg/linters/components/pkgconfigusageto reduce test timeouts on macOS CI runners.Motivation
The test still times out occasionally (example in
main) after 3 minutes on macOS Gitlab runners when running with-p 12 -parallel 12.analysistest.Runinternally runsgo buildcommands to verify the Go toolchain works. When multiple tests run concurrently with the same sharedGOCACHE, they can deadlock in Go's process management layer (see golang/go#59657).Changes
Added per-test isolated
GOCACHE,GOPRIVATEandGOPROXY, following the same approach as PR #39687 which fixed a similar timeout issue incomp/core/secrets/impl/fetch_secret_test.go.Describe how you validated your changes
Verified locally with
go test -v -race -count=20 -parallel 12 -timeout 600s.Additional Notes
Prior art include:
tests_macos_gitlab_amd64: tentatively fix flakyTestAll#43207trace_agent_integration_tests: tentatively fix flakiness #43627💡
-mod=vendorcould be also factored out through a future PR should the problem manifest itself again after the present change is merged.