WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Dec 5, 2025

Backport 320050a from #43627.


What does this PR do?

The present change is expected to reduce test execution time, especially with race detection enabled, and hopefully prevent timeouts in TestTraces and siblings.

This change implements the TODO in agent.go by:

  • creating a top-level temporary directory,
  • building trace-agent and secret-script binaries once in that directory, with GOPRIVATE=* and GOPROXY=off to prevent concurrent module cache access,
  • creating symlinks to the cached binaries in per-test subdirectories,
  • cleaning up the entire temp directory tree after all tests complete.

Motivation

The trace-agent integration tests have been repeatedly failing on timeouts, for instance:

There are at least 2 culprits:

  1. rebuilding the trace-agent binary from scratch for every test run. When running with the race detector (-race flag), each build takes time,
  2. module cache contention when building, see tests_macos_gitlab_amd64: tentatively fix flaky TestAll #43207 for why.

### What does this PR do?
The present change is expected to reduce test execution time, especially with race detection enabled, and hopefully prevent timeouts in `TestTraces` and siblings.

This change implements the `TODO` in `agent.go` by:
- creating a top-level temporary directory,
- building `trace-agent` and `secret-script` binaries once in that directory, with `GOPRIVATE=*` and `GOPROXY=off` to prevent concurrent module cache access,
- creating symlinks to the cached binaries in per-test subdirectories,
- cleaning up the entire temp directory tree after all tests complete.

### Motivation
The `trace-agent` integration tests have been repeatedly failing on timeouts, for instance:
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261246921
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261237699
- https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261226844

There are at least 2 culprits:
1. rebuilding the `trace-agent` binary from scratch for every test run. When running with the race detector (`-race` flag), each build takes time,
2. module cache contention when building, see #43207 for why.

Co-authored-by: regis.desgroppes <[email protected]>
(cherry picked from commit 320050a)
@dd-octo-sts dd-octo-sts bot added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation backport bot short review PR is simple enough to be reviewed quickly labels Dec 5, 2025
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner December 5, 2025 14:35
@dd-octo-sts dd-octo-sts bot added the ask-review Ask required teams to review this PR label Dec 5, 2025
@spencergilbert
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 5, 2025

View all feedbacks in Devflow UI.

2025-12-05 14:39:47 UTC ℹ️ Start processing command /merge


2025-12-05 14:39:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in 7.74.x is approximately 32m (p90).


2025-12-05 15:09:59 UTC ℹ️ MergeQueue: This merge request was merged

@spencergilbert spencergilbert self-assigned this Dec 5, 2025
@dd-mergequeue dd-mergequeue bot merged commit 008c3c6 into 7.74.x Dec 5, 2025
207 of 235 checks passed
@dd-mergequeue dd-mergequeue bot deleted the backport-43627-to-7.74.x branch December 5, 2025 15:09
@github-actions github-actions bot added this to the 7.74.0 milestone Dec 5, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 5, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0ec5dd8c-fc83-4e91-9f58-0bb04a3ba215

Baseline: 15fd09a
Comparison: a2d213e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.13 [-1.74, +4.01] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.13 [-1.74, +4.01] 1 Logs
docker_containers_memory memory utilization +0.60 [+0.52, +0.68] 1 Logs
quality_gate_metrics_logs memory utilization +0.41 [+0.20, +0.63] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.16 [+0.09, +0.22] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.09 [-0.31, +0.50] 1 Logs
otlp_ingest_metrics memory utilization +0.08 [-0.07, +0.23] 1 Logs
file_tree memory utilization +0.08 [+0.03, +0.12] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.05 [-0.10, +0.21] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.07] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.14, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.04 [-0.41, +0.33] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.09, +0.00] 1 Logs
otlp_ingest_logs memory utilization -0.05 [-0.14, +0.05] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.06 [-0.30, +0.18] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.48, +0.34] 1 Logs
quality_gate_idle_all_features memory utilization -0.07 [-0.12, -0.02] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.09 [-0.15, -0.04] 1 Logs
quality_gate_idle memory utilization -0.16 [-0.21, -0.10] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.22 [-0.42, -0.03] 1 Logs
quality_gate_logs % cpu utilization -0.56 [-2.00, +0.87] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.75 [-0.96, -0.54] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.93 [-1.02, -0.85] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR backport bot changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants