[Backport 7.73.x] trace_agent_integration_tests: tentatively fix flakiness
#43856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? The present change is expected to reduce test execution time, especially with race detection enabled, and hopefully prevent timeouts in `TestTraces` and siblings. This change implements the `TODO` in `agent.go` by: - creating a top-level temporary directory, - building `trace-agent` and `secret-script` binaries once in that directory, with `GOPRIVATE=*` and `GOPROXY=off` to prevent concurrent module cache access, - creating symlinks to the cached binaries in per-test subdirectories, - cleaning up the entire temp directory tree after all tests complete. ### Motivation The `trace-agent` integration tests have been repeatedly failing on timeouts, for instance: - https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261246921 - https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261237699 - https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1261226844 There are at least 2 culprits: 1. rebuilding the `trace-agent` binary from scratch for every test run. When running with the race detector (`-race` flag), each build takes time, 2. module cache contention when building, see #43207 for why. Co-authored-by: regis.desgroppes <[email protected]> (cherry picked from commit 320050a)
dd-octo-sts
bot
added
changelog/no-changelog
qa/no-code-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 320050a from #43627.
What does this PR do?
The present change is expected to reduce test execution time, especially with race detection enabled, and hopefully prevent timeouts in
TestTracesand siblings.This change implements the
TODOinagent.goby:trace-agentandsecret-scriptbinaries once in that directory, withGOPRIVATE=*andGOPROXY=offto prevent concurrent module cache access,Motivation
The
trace-agentintegration tests have been repeatedly failing on timeouts, for instance:There are at least 2 culprits:
trace-agentbinary from scratch for every test run. When running with the race detector (-raceflag), each build takes time,tests_macos_gitlab_amd64: tentatively fix flakyTestAll#43207 for why.