Migrate to dd-pkg staging artifact-gateway for all builds #43872
+3
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set DD_PKG_GITLAB_URL globally in .gitlab-ci.yml to staging artifact-gateway - Remove conditional logic that only applied staging URL to nightly/oldnightly builds - Simplify agent.yml and installer.yml trigger scripts to use global variable - All builds (nightly, beta, stable) now consistently use staging artifact-gateway - Variable remains overridable at pipeline trigger level
spencergilbert
added
changelog/no-changelog
qa/no-code-change
github-actions
bot
added
the
short review
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 1 | 0 | 0 |
Updated: .gitlab/trigger_distribution/include.yml
Modified Jobs
.agent_release_management_trigger
.agent_release_management_trigger:
dependencies: []
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
script:
- curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
| tar -xz -C /usr/local/bin dd-pkg
- dd-pkg version
- RELEASE_VERSION="$(dda inv agent.version --url-safe --omnibus-format --pipeline-id
$PARENT_PIPELINE_ID)-1" || exit $?; export RELEASE_VERSION
- - "if [ \"$BUCKET_BRANCH\" = \"nightly\" ] || [ \"$BUCKET_BRANCH\" = \"oldnightly\"\
- \ ]; then\n export DD_PKG_GITLAB_URL=\"https://artifact-gateway.us1.staging.dog/internal/artifact-gateway/api/v4\"\
- \n echo \"Using staging artifact gateway: $DD_PKG_GITLAB_URL\"\nfi\n"
? ^^^^^ - -------- - -------
+ - 'echo "Using artifact gateway: $DD_PKG_GITLAB_URL"
? + ^
+
+ '
- "dd-pkg promote \\\n --build-pipeline-id $PARENT_PIPELINE_ID \\\n --release-product\
\ $RELEASE_PRODUCT \\\n --key-id $PIPELINE_KEY_ALIAS \\\n --release-version\
\ $RELEASE_VERSION \\\n --target-repo $TARGET_REPO \\\n --target-channel $BUCKET_BRANCH\
\ \\\n $AUTO_RELEASE \\\n $FOLLOW"
stage: trigger_release
tags:
- arch:amd64
- specific:true
variables:
DD_PKG_ARCH: x86_64
RELEASE_PRODUCT: datadog-agent.installer_release_management_trigger
.installer_release_management_trigger:
dependencies: []
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
script:
- curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
| tar -xz -C /usr/local/bin dd-pkg
- dd-pkg version
- RELEASE_VERSION="$(dda inv agent.version --url-safe --omnibus-format --pipeline-id
$PARENT_PIPELINE_ID)-1" || exit $?; export RELEASE_VERSION
- - "if [ \"$BUCKET_BRANCH\" = \"nightly\" ] || [ \"$BUCKET_BRANCH\" = \"oldnightly\"\
- \ ]; then\n export DD_PKG_GITLAB_URL=\"https://artifact-gateway.us1.staging.dog/internal/artifact-gateway/api/v4\"\
- \n echo \"Using staging artifact gateway: $DD_PKG_GITLAB_URL\"\nfi\n"
? ^^^^^ - -------- - -------
+ - 'echo "Using artifact gateway: $DD_PKG_GITLAB_URL"
? + ^
+
+ '
- "dd-pkg promote \\\n --build-pipeline-id $PARENT_PIPELINE_ID \\\n --release-product\
\ $RELEASE_PRODUCT \\\n --key-id $PIPELINE_KEY_ALIAS \\\n --release-version\
\ $RELEASE_VERSION \\\n --target-repo $TARGET_REPO \\\n --target-channel $BUCKET_BRANCH\
\ \\\n $AUTO_RELEASE \\\n $FOLLOW"
stage: trigger_release
tags:
- arch:amd64
- specific:true
variables:
DD_PKG_ARCH: x86_64
RELEASE_PRODUCT: datadog-installerinstaller_trigger_auto_staging_release
installer_trigger_auto_staging_release:
dependencies: []
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
rules:
- if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
when: always
script:
- curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
| tar -xz -C /usr/local/bin dd-pkg
- dd-pkg version
- RELEASE_VERSION="$(dda inv agent.version --url-safe --omnibus-format --pipeline-id
$PARENT_PIPELINE_ID)-1" || exit $?; export RELEASE_VERSION
- - "if [ \"$BUCKET_BRANCH\" = \"nightly\" ] || [ \"$BUCKET_BRANCH\" = \"oldnightly\"\
- \ ]; then\n export DD_PKG_GITLAB_URL=\"https://artifact-gateway.us1.staging.dog/internal/artifact-gateway/api/v4\"\
- \n echo \"Using staging artifact gateway: $DD_PKG_GITLAB_URL\"\nfi\n"
? ^^^^^ - -------- - -------
+ - 'echo "Using artifact gateway: $DD_PKG_GITLAB_URL"
? + ^
+
+ '
- "dd-pkg promote \\\n --build-pipeline-id $PARENT_PIPELINE_ID \\\n --release-product\
\ $RELEASE_PRODUCT \\\n --key-id $PIPELINE_KEY_ALIAS \\\n --release-version\
\ $RELEASE_VERSION \\\n --target-repo $TARGET_REPO \\\n --target-channel $BUCKET_BRANCH\
\ \\\n $AUTO_RELEASE \\\n $FOLLOW"
stage: trigger_release
tags:
- arch:amd64
- specific:true
timeout: 2h 30m
variables:
AUTO_RELEASE: --auto-release
DD_PKG_ARCH: x86_64
FOLLOW: --follow
RELEASE_PRODUCT: datadog-installer
TARGET_REPO: staginginstaller_trigger_manual_prod_release
installer_trigger_manual_prod_release:
dependencies: []
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
rules:
- if: $BUCKET_BRANCH != "beta" && $BUCKET_BRANCH != "stable"
when: never
- if: $DEPLOY_INSTALLER != "true" && $DDR_WORKFLOW_ID == null
when: never
- allow_failure: true
if: $BUCKET_BRANCH != "stable"
when: manual
- when: always
script:
- curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
| tar -xz -C /usr/local/bin dd-pkg
- dd-pkg version
- RELEASE_VERSION="$(dda inv agent.version --url-safe --omnibus-format --pipeline-id
$PARENT_PIPELINE_ID)-1" || exit $?; export RELEASE_VERSION
- - "if [ \"$BUCKET_BRANCH\" = \"nightly\" ] || [ \"$BUCKET_BRANCH\" = \"oldnightly\"\
- \ ]; then\n export DD_PKG_GITLAB_URL=\"https://artifact-gateway.us1.staging.dog/internal/artifact-gateway/api/v4\"\
- \n echo \"Using staging artifact gateway: $DD_PKG_GITLAB_URL\"\nfi\n"
? ^^^^^ - -------- - -------
+ - 'echo "Using artifact gateway: $DD_PKG_GITLAB_URL"
? + ^
+
+ '
- "dd-pkg promote \\\n --build-pipeline-id $PARENT_PIPELINE_ID \\\n --release-product\
\ $RELEASE_PRODUCT \\\n --key-id $PIPELINE_KEY_ALIAS \\\n --release-version\
\ $RELEASE_VERSION \\\n --target-repo $TARGET_REPO \\\n --target-channel $BUCKET_BRANCH\
\ \\\n $AUTO_RELEASE \\\n $FOLLOW"
stage: trigger_release
tags:
- arch:amd64
- specific:true
variables:
DD_PKG_ARCH: x86_64
RELEASE_PRODUCT: datadog-installer
TARGET_REPO: prodtrigger_auto_staging_release
trigger_auto_staging_release:
dependencies: []
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
rules:
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+){0,1}$/
when: never
- when: always
script:
- curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
| tar -xz -C /usr/local/bin dd-pkg
- dd-pkg version
- RELEASE_VERSION="$(dda inv agent.version --url-safe --omnibus-format --pipeline-id
$PARENT_PIPELINE_ID)-1" || exit $?; export RELEASE_VERSION
- - "if [ \"$BUCKET_BRANCH\" = \"nightly\" ] || [ \"$BUCKET_BRANCH\" = \"oldnightly\"\
- \ ]; then\n export DD_PKG_GITLAB_URL=\"https://artifact-gateway.us1.staging.dog/internal/artifact-gateway/api/v4\"\
- \n echo \"Using staging artifact gateway: $DD_PKG_GITLAB_URL\"\nfi\n"
? ^^^^^ - -------- - -------
+ - 'echo "Using artifact gateway: $DD_PKG_GITLAB_URL"
? + ^
+
+ '
- "dd-pkg promote \\\n --build-pipeline-id $PARENT_PIPELINE_ID \\\n --release-product\
\ $RELEASE_PRODUCT \\\n --key-id $PIPELINE_KEY_ALIAS \\\n --release-version\
\ $RELEASE_VERSION \\\n --target-repo $TARGET_REPO \\\n --target-channel $BUCKET_BRANCH\
\ \\\n $AUTO_RELEASE \\\n $FOLLOW"
stage: trigger_release
tags:
- arch:amd64
- specific:true
timeout: 2h 30m
variables:
AUTO_RELEASE: --auto-release
DD_PKG_ARCH: x86_64
FOLLOW: --follow
RELEASE_PRODUCT: datadog-agent
TARGET_REPO: stagingtrigger_manual_prod_release
trigger_manual_prod_release:
dependencies: []
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
rules:
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+){0,1}$/
when: never
- if: $BUCKET_BRANCH != "beta" && $BUCKET_BRANCH != "stable"
when: never
- allow_failure: true
if: $BUCKET_BRANCH != "stable"
when: manual
- when: always
script:
- curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz"
| tar -xz -C /usr/local/bin dd-pkg
- dd-pkg version
- RELEASE_VERSION="$(dda inv agent.version --url-safe --omnibus-format --pipeline-id
$PARENT_PIPELINE_ID)-1" || exit $?; export RELEASE_VERSION
- - "if [ \"$BUCKET_BRANCH\" = \"nightly\" ] || [ \"$BUCKET_BRANCH\" = \"oldnightly\"\
- \ ]; then\n export DD_PKG_GITLAB_URL=\"https://artifact-gateway.us1.staging.dog/internal/artifact-gateway/api/v4\"\
- \n echo \"Using staging artifact gateway: $DD_PKG_GITLAB_URL\"\nfi\n"
? ^^^^^ - -------- - -------
+ - 'echo "Using artifact gateway: $DD_PKG_GITLAB_URL"
? + ^
+
+ '
- "dd-pkg promote \\\n --build-pipeline-id $PARENT_PIPELINE_ID \\\n --release-product\
\ $RELEASE_PRODUCT \\\n --key-id $PIPELINE_KEY_ALIAS \\\n --release-version\
\ $RELEASE_VERSION \\\n --target-repo $TARGET_REPO \\\n --target-channel $BUCKET_BRANCH\
\ \\\n $AUTO_RELEASE \\\n $FOLLOW"
stage: trigger_release
tags:
- arch:amd64
- specific:true
variables:
DD_PKG_ARCH: x86_64
RELEASE_PRODUCT: datadog-agent
TARGET_REPO: prodChanges Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 6 | 0 | 0 |
ℹ️ Diff available in the job log.
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: efcdf21 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.69 | [-4.66, +1.27] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +3.45 | [+1.97, +4.94] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.73 | [+0.63, +0.82] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.64 | [+0.41, +0.87] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.37 | [+0.32, +0.41] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.30 | [+0.23, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.36, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.39, +0.44] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.02 | [-0.35, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.12, +0.12] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.00 | [-0.15, +0.15] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.12] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.01 | [-0.22, +0.21] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.08, +0.06] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.06, +0.03] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.02 | [-0.09, +0.05] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.13 | [-0.18, -0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.14 | [-0.20, -0.08] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.24 | [-0.28, -0.20] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.34 | [-0.50, -0.18] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.54 | [-0.61, -0.47] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.72 | [-0.93, -0.52] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.94 | [-1.17, -0.70] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -1.69 | [-4.66, +1.27] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
chouetz
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Completes the migration to use the staging artifact-gateway URL for all builds (nightly, beta, and stable). The dd-pkg beta version (0.6.0-beta.4) is already deployed globally and remains unchanged.
Motivation
Previously, the staging artifact-gateway URL was only used for nightly/oldnightly builds through conditional logic in the release trigger scripts. This PR:
Changes
Added global variable in
.gitlab-ci.yml:DD_PKG_GITLAB_URLto staging artifact-gateway URL alongsideDD_PKG_VERSIONSimplified release triggers in
.gitlab/trigger_release/agent.ymland.gitlab/trigger_release/installer.yml:DD_PKG_GITLAB_URLonly for nightly buildsDescribe how you validated your changes
Additional Notes
The global
DD_PKG_GITLAB_URLvariable can still be overridden when triggering pipelines if needed for testing or rollback scenarios.