WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@florentinl
Copy link
Contributor

@florentinl florentinl commented Dec 5, 2025

What does this PR do?

It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog:

From the RFC:
image

Motivation

This PR implements RFC-1081.

The goal is be able to use API Gateway lambda inferred spans for endpoint discovery and correlation in the AppSec API Catalog.

Testing Guidelines

Additional Notes

  • _dd.appsec.* meta and metrics are to be set in ddtrace: feat(aap): report AAP on lambda inferred spans dd-trace-py#15511
  • renamed http.user_agent into http.useragent, this is the tag specified in the "Span attributes" page of APM ( and the tag is used by the system-tests to correlate spans with requests, this is necessary to test this feature there)
  • added the _dd.inferred_span metric, the backend filters inferred spans for the APM Catalog (and the AAP Catalog) based on this metric. It is already set by tracers for the API Gateway proxy inferred spans.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@florentinl florentinl changed the title feat(aap): update api gateway for inferred feat(aap): update tags on inferred spans for API Gateway Dec 5, 2025
@florentinl florentinl force-pushed the florentin.labelle/APPSEC-60048/apigw-inferred-span-correlation branch from 9739bef to 28bf2a2 Compare December 8, 2025 13:28
@florentinl florentinl force-pushed the florentin.labelle/APPSEC-60048/apigw-inferred-span-correlation branch from d1d4cba to e7adc97 Compare December 8, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants