-
Notifications
You must be signed in to change notification settings - Fork 469
chore(aap): improve api10 redirection analysis #15529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(aap): improve api10 redirection analysis #15529
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 4 ms. The average import time from base is: 253 ± 3 ms. The import time difference between this PR and base is: -2.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/api10_redirection_add_redirect_response_analysis (374bdb1) with baseline main (874de50) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ add_inplace_aspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.3% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.323µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +1.0% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 1.354µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.4% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ bytearray_extend_aspectTime: ✅ 1.512µs (SLO: <10.000µs 📉 -84.9%) vs baseline: +0.1% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +3.9% ✅ bytearray_extend_noaspectTime: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: +0.1% Memory: ✅ 40.501MB (SLO: <41.500MB -2.4%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 0.479µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.5% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 1.298µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.9% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.1% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.343µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -2.1% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.1% ✅ capitalize_aspectTime: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.4% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ capitalize_noaspectTime: ✅ 0.432µs (SLO: <10.000µs 📉 -95.7%) vs baseline: ~same Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.5% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.3% Memory: ✅ 40.442MB (SLO: <41.500MB -2.5%) vs baseline: +5.7% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.3% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.2% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.2% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.5% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 3.429µs (SLO: <10.000µs 📉 -65.7%) vs baseline: -0.3% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.7% ✅ format_map_aspectTime: ✅ 3.555µs (SLO: <10.000µs 📉 -64.4%) vs baseline: -1.0% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ format_map_noaspectTime: ✅ 0.771µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.5% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: ~same Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ index_aspectTime: ✅ 0.352µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -0.8% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.4% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ join_aspectTime: ✅ 1.339µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.6% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 0.486µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 2.959µs (SLO: <20.000µs 📉 -85.2%) vs baseline: 📈 +15.0% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.1% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.295µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +1.6% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.7% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ lstrip_aspectTime: ✅ 2.259µs (SLO: <20.000µs 📉 -88.7%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.2% ✅ lstrip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.0% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +4.1% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.546µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.5% Memory: ✅ 40.383MB (SLO: <41.500MB -2.7%) vs baseline: +5.3% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +1.4% Memory: ✅ 40.423MB (SLO: <41.500MB -2.6%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.241µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +1.5% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.625µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.9% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ replace_aspectTime: ✅ 4.881µs (SLO: <10.000µs 📉 -51.2%) vs baseline: -0.8% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +3.7% ✅ replace_noaspectTime: ✅ 0.467µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +0.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.2% ✅ repr_aspectTime: ✅ 0.907µs (SLO: <10.000µs 📉 -90.9%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.9% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 1.939µs (SLO: <20.000µs 📉 -90.3%) vs baseline: ~same Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.6% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.6% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.4% ✅ slice_aspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.4% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.2% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.541µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.2% Memory: ✅ 40.010MB (SLO: <41.500MB -3.6%) vs baseline: +3.9% ✅ stringio_noaspectTime: ✅ 0.712µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -1.0% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.221µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.7% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.7% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.778µs (SLO: <10.000µs 📉 -72.2%) vs baseline: 📈 +13.6% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.3% ✅ swapcase_noaspectTime: ✅ 0.536µs (SLO: <10.000µs 📉 -94.6%) vs baseline: ~same Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 2.414µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +1.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 3.321µs (SLO: <10.000µs 📉 -66.8%) vs baseline: +0.8% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.036µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.4% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ upper_aspectTime: ✅ 2.300µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +1.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.2% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.195µs (SLO: <10.000µs 📉 -48.0%) vs baseline: 📈 +25.6% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.091µs (SLO: <10.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.188µs (SLO: <10.000µs 📉 -38.1%) vs baseline: +0.4% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.288µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.2% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.4% ✅ ospathnormcase_aspectTime: ✅ 3.461µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +0.4% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.724µs (SLO: <10.000µs 📉 -52.8%) vs baseline: -1.0% Memory: ✅ 40.383MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.2% ✅ ospathsplit_noaspectTime: ✅ 1.596µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.2% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.651µs (SLO: <10.000µs 📉 -63.5%) vs baseline: -0.6% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.697µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -1.7% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.494µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -2.1% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.386µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -1.3% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.367µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +15.0% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 202.125µs (SLO: <220.000µs -8.1%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.3% ✅ 1-distribution-metric-1-timesTime: ✅ 3.270µs (SLO: <20.000µs 📉 -83.7%) vs baseline: -0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.597µs (SLO: <230.000µs -5.8%) vs baseline: -0.8% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.155µs (SLO: <20.000µs 📉 -89.2%) vs baseline: +0.3% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.2% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.114µs (SLO: <150.000µs -9.3%) vs baseline: ~same Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.059µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 214.534µs (SLO: <250.000µs 📉 -14.2%) vs baseline: +0.1% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.222ms (SLO: <22.000ms -8.1%) vs baseline: -0.6% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.307ms (SLO: <2.550ms -9.5%) vs baseline: +1.5% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: +0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.237ms (SLO: <2.550ms 📉 -12.3%) vs baseline: +1.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.623µs (SLO: <20.000µs 📉 -76.9%) vs baseline: +0.4% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.679µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.5% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.171ms (SLO: <2.500ms 📉 -13.1%) vs baseline: -0.2% Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +4.7% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Add redirection response waf analysis both to urllib and urllib3
Testing
This will be tested by DataDog/system-tests#5831
APPSEC-60065