WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 12, 2025

What does this PR do?

Ensures configurations used in OpenTelemetry Metrics SDK are reported to the instrumentation telemetry platform. Updates configuration fallback logic to properly detect when metrics-specific configs use default values and fall back to general OTLP exporter configs per OpenTelemetry spec.

Motivation:

Emit diagnostic data about the state of the OpenTelemetry Components.

Change log entry

None.

Additional Notes:

How to test the change?

Regression was caught by system tests. This update to system tests will be merged after this PR: DataDog/system-tests#5811

@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 12, 2025
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-12-17 19:59:20 UTC

@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2025

Benchmarks

Benchmark execution time: 2025-12-18 19:16:29

Comparing candidate commit 0db7126 in PR branch munir/track-telemetry-otel-metric with baseline commit 2cb8be7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@github-actions github-actions bot added the otel OpenTelemetry-related changes label Dec 15, 2025
@mabdinur mabdinur force-pushed the munir/track-telemetry-otel-metric branch from 6e1aac5 to 77fbfb0 Compare December 15, 2025 03:01
@mabdinur mabdinur changed the title chore(otel): add configurations to instrumentation telemetry app started chore(otel): fix telemetry collection Dec 15, 2025
@mabdinur mabdinur changed the title chore(otel): fix telemetry collection chore(otel): fix telemetry collection for otel metrics Dec 15, 2025
@datadog-official
Copy link

datadog-official bot commented Dec 15, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 69.57%
Overall Coverage: 95.25% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0db7126 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@mabdinur mabdinur marked this pull request as ready for review December 15, 2025 19:57
@mabdinur mabdinur requested review from a team as code owners December 15, 2025 19:57
@mabdinur mabdinur requested a review from vpellan December 15, 2025 19:57
y9v
y9v previously requested changes Dec 16, 2025
Copy link
Member

@y9v y9v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes a bug, but there is not a single test here, which verifies that the bug is fixed now. Would it be possible to add tests?

@y9v y9v dismissed their stale review December 16, 2025 14:37

I don't want to block the PR since I am planning to take some days off

@mabdinur
Copy link
Contributor Author

This PR fixes a bug, but there is not a single test here, which verifies that the bug is fixed now. Would it be possible to add tests?

I linked the the system tests for this change in the PR description. I can duplicate these tests in dd-trace-rb but I think that reduces the value of having shared tests. I prefer not writing the same test cases multiple times but I can make this change if it is required to merge this PR

@y9v
Copy link
Member

y9v commented Dec 16, 2025

This PR fixes a bug, but there is not a single test here, which verifies that the bug is fixed now. Would it be possible to add tests?

I linked the the system tests for this change in the PR description. I can duplicate these tests in dd-trace-rb but I think that reduces the value of having shared tests. I prefer not writing the same test cases multiple times but I can make this change if it is required to merge this PR

Sorry, I missed the link to system-tests PR. It's up to you, but I would suggest to add at least one test here - simply because it makes it easier to spot a mistake early on in the future. If I am working on the library code, I run the tests we have, but not necessarily system tests (which are more like a contract).

@mabdinur mabdinur force-pushed the munir/track-telemetry-otel-metric branch from 383242e to 2806353 Compare December 16, 2025 14:55
@mabdinur
Copy link
Contributor Author

This PR fixes a bug, but there is not a single test here, which verifies that the bug is fixed now. Would it be possible to add tests?

I linked the the system tests for this change in the PR description. I can duplicate these tests in dd-trace-rb but I think that reduces the value of having shared tests. I prefer not writing the same test cases multiple times but I can make this change if it is required to merge this PR

Sorry, I missed the link to system-tests PR. It's up to you, but I would suggest to add at least one test here - simply because it makes it easier to spot a mistake early on in the future. If I am working on the library code, I run the tests we have, but not necessarily system tests (which are more like a contract).

Yup, I can do that. This change only impacts instrumentation telemetry. I'll add a test cases that captures all supported configs and the success metrics

@mabdinur mabdinur requested a review from y9v December 16, 2025 16:17
@p-datadog
Copy link
Member

@mabdinur Can you please adjust the changelog section of the PR to be compliant with the requirements stated in the first comment above?

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 1 partially typed method, and clears 1 partially typed method. It increases the percentage of typed methods from 55.78% to 55.8% (+0.02%).

Partially typed methods (+1-1)Introduced:
sig/datadog/opentelemetry/sdk/metrics_exporter.rbs:19
└── def export: (untyped metrics, ?timeout: ::Float?) -> Integer
Cleared:
sig/datadog/opentelemetry/sdk/metrics_exporter.rbs:15
└── def export: (untyped metrics, ?timeout: ::Float?) -> Integer

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

@mabdinur mabdinur requested a review from p-datadog December 17, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries otel OpenTelemetry-related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants