WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Dec 4, 2025

What does this PR do?

This PR adds context to the different setup and teardown mechanisms we have when launching a docker agent for e2e tests.

The context is framed between headers with different styles also clearly showing whether the commands suceeded or not based on the return code.

The Application.display_header has been updated as well to provide higher level of control over how to print the header.

Motivation

While logs are printed it is normally hard to find them among all logs, including docker logs. The intention of this change is to make it more visible so developers know what failed and when.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.17%. Comparing base (8c6c226) to head (fb19a95).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AAraKKe AAraKKe marked this pull request as ready for review December 4, 2025 09:49
@AAraKKe AAraKKe requested a review from a team as a code owner December 4, 2025 09:49
@AAraKKe AAraKKe enabled auto-merge December 4, 2025 09:54
@AAraKKe AAraKKe added this pull request to the merge queue Dec 4, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2025
…ng Docker agent in E2E (#22042)

* Add some context information when a start-up command fails when running Docker agent in E2E

* Add changelog

* Cover other lifecycle actions and improve ux
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants