Add some context information when a start-up command fails when running Docker agent in E2E #22042
+65
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds context to the different setup and teardown mechanisms we have when launching a docker agent for e2e tests.
The context is framed between headers with different styles also clearly showing whether the commands suceeded or not based on the return code.
The
Application.display_headerhas been updated as well to provide higher level of control over how to print the header.Motivation
While logs are printed it is normally hard to find them among all logs, including docker logs. The intention of this change is to make it more visible so developers know what failed and when.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged