WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Conversation

@aaronsb
Copy link

@aaronsb aaronsb commented May 2, 2019

Hey I just wanted to give back some changes that I had implemented to color more content. Feel free to ask anything about the changes. It would be awesome to see them implemented in your source but I understand if you don't want to!

Cheers,

Aaron

@lackovic
Copy link

lackovic commented Nov 3, 2019

These changes look great! @vr8hub can we have them merged?

@brunovieira97
Copy link

Is anyone working on this currently? More than a year has passed and still no merge of these awesome improvements...

@aaronsb
Copy link
Author

aaronsb commented Jun 29, 2020

Also, sorry for all the internal commits, they could probably be squashed together.

@brunovieira97
Copy link

Also, sorry for all the internal commits, they could probably be squashed together.

I don't see a problem with this approach, since my flow often includes Squashing the PR on to Master. It helps visualizing all the steps that a dev takes for completing work. My opinion though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants