Fix for null entries in PlayerPreparesEnchantScriptEvent #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davight
reviewed
Dec 14, 2025
| } | ||
| for (int i = 0; i < offers.size(); i++) { | ||
| MapTag map = MapTag.getMapFor(offers.getObject(i), getTagContext(path)); | ||
| if(map.isEmpty()){ |
Contributor
There was a problem hiding this comment.
need space after if statement
tal5
requested changes
Dec 16, 2025
| } | ||
| for (int i = 0; i < offers.size(); i++) { | ||
| MapTag map = MapTag.getMapFor(offers.getObject(i), getTagContext(path)); | ||
| if (map.isEmpty()){ |
Member
There was a problem hiding this comment.
Missing another space here - generally we recommend using an IDE like Intellji IDEA which can help with the formatting/do it for you, a lot easier than managing it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that the PlayerPreparesEnchant ScriptEvent errors in case of the minecraft provided offers having a null entry. I added some simple protections for null entries.