-
Notifications
You must be signed in to change notification settings - Fork 5
generate proper output in the dist folder #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrickuhlmann
wants to merge
1
commit into
main
Choose a base branch
from
fix_build_output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,39 @@ | ||
| import { defineConfig } from 'vite'; | ||
| import { svelte } from '@sveltejs/vite-plugin-svelte'; | ||
| import { createHtmlPlugin } from 'vite-plugin-html'; | ||
| import fs from 'fs'; | ||
| import path from 'path'; | ||
|
|
||
| const htmlVars = { | ||
| browser_lang: 'de', | ||
| page_title: 'Generiere dein Datenauskunftsbegehren | Digitale Gesellschaft', | ||
| description: 'Gemäss Datenschutzgesetz hat jede Person das Recht zu erfahren, welche Daten über sie gespeichert sind, und diese – wenn nötig – löschen oder korrigieren zu lassen.', | ||
| description_short: 'Gemäss Datenschutzgesetz hat jede Person das Recht zu erfahren, welche Daten über sie gespeichert sind', | ||
| browser_outdated: '<p>Du verwendest einen alten Browser.<br>Der Generator funktioniert damit leider nicht.</p><p>Bitte verwende eine aktuelle Version des Browsers deiner Wahl.</p>' | ||
| }; | ||
|
|
||
| export default defineConfig({ | ||
| plugins: [ | ||
| // commonjs(), | ||
| svelte(), | ||
| createHtmlPlugin({ | ||
| minify: true, | ||
| entry: 'src/main.js', | ||
| template: 'index.html', | ||
| inject: { | ||
| data: { | ||
| // @TODO Redaktion description_short: Shorten description for SEO purposes or leave the long version? | ||
| browser_lang: 'de', | ||
| page_title: 'Generiere dein Datenauskunftsbegehren | Digitale Gesellschaft', | ||
| description: 'Gemäss Datenschutzgesetz hat jede Person das Recht zu erfahren, welche Daten über sie gespeichert sind, und diese – wenn nötig – löschen oder korrigieren zu lassen.', | ||
| description_short: 'Gemäss Datenschutzgesetz hat jede Person das Recht zu erfahren, welche Daten über sie gespeichert sind', | ||
| browser_outdated: '<p>Du verwendest einen alten Browser. <br>Der Generator funktioniert damit leider nicht.</p><p>Bitte verwende eine aktuelle Version des Browsers deiner Wahl.</p>' | ||
| }, | ||
| }, | ||
| }) | ||
| { | ||
| name: 'html-template-vars', | ||
| transformIndexHtml(html) { | ||
| // einfache Platzhalter-Ersetzung: %varname% | ||
| return html.replace(/%(\w+)%/g, (_, key) => htmlVars[key] ?? ''); | ||
| } | ||
| } | ||
| ], | ||
|
|
||
| server: { | ||
| open: true | ||
| }, | ||
| preview: { | ||
| open: true, | ||
| port: 8080, | ||
| }, | ||
| optimizeDeps: { | ||
| include: ['lodash-es'], | ||
| }, | ||
| build: { | ||
| outDir: 'dist', | ||
| emptyOutDir: true, | ||
| rollupOptions: { | ||
| input: 'src/main.js', | ||
| output: { | ||
| entryFileNames: 'build/[name]-[hash].js', | ||
| chunkFileNames: 'build/[name]-[hash].js', | ||
| assetFileNames: 'build/[name]-[hash].[ext]', | ||
| }, | ||
| sourcemap: true, | ||
| name: 'app', | ||
| }, | ||
| sourcemap: true | ||
| }, | ||
| base: './', | ||
| }); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Müssen wür aufpassen dass wir das nur in development machen. für prod build wollen wir nicht den gesamten source code miteinbinden. Mal zu testen...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Habe es absichtlich auf true gelassen. Es werden .map Dateien generiert. Diese werden vom Browser by default nicht geladen wenn man die Applikation normal nutzt. Erst wenn es Fehler in der Konsole gibt und man draufklickt lädt er die Dateien. Da das Projekt sowieso OpenSource ist sehe ich kein Problem den Quellcode "bereitzustellen". Ist aber nützlich wenn man Fehler etwas anschauen will auf Prod. Können es aber auch deaktivieren wenn es dich/euch stört.