WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

[poc][BC]Rectorの適用 #6453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dotani1111 wants to merge 1 commit into
base: 4.3-symfony7
Choose a base branch
from
Draft

[poc][BC]Rectorの適用 #6453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions codeception/_data/plugins/Boomerang-1.0.0/PluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,34 +18,39 @@

class PluginManager extends AbstractPluginManager
{
#[\Override]
public function install(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
echo 'Install Boomerang 1.0.0'.PHP_EOL;
echo '*******************************************'.PHP_EOL;
}

#[\Override]
public function enable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
echo 'Enable Boomerang 1.0.0'.PHP_EOL;
echo '*******************************************'.PHP_EOL;
}

#[\Override]
public function disable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
echo 'Disable Boomerang 1.0.0'.PHP_EOL;
echo '*******************************************'.PHP_EOL;
}

#[\Override]
public function update(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
echo 'Update Boomerang 1.0.0'.PHP_EOL;
echo '*******************************************'.PHP_EOL;
}

#[\Override]
public function uninstall(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand Down
5 changes: 5 additions & 0 deletions codeception/_data/plugins/Boomerang10-1.0.0/PluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

class PluginManager extends AbstractPluginManager
{
#[\Override]
public function install(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -35,6 +36,7 @@ public function install(array $config, ContainerInterface $container)
$entityManager->flush($bar);
}

#[\Override]
public function enable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -44,6 +46,7 @@ public function enable(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 2);
}

#[\Override]
public function disable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -53,6 +56,7 @@ public function disable(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 2);
}

#[\Override]
public function update(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -62,6 +66,7 @@ public function update(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 2);
}

#[\Override]
public function uninstall(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand Down
1 change: 1 addition & 0 deletions codeception/_data/plugins/Bundle-1.0.0/Bundle/BundleBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

class BundleBundle extends Bundle
{
#[\Override]
public function build(ContainerBuilder $container)
{
parent::build($container);
Expand Down
1 change: 1 addition & 0 deletions codeception/_data/plugins/Bundle-1.0.0/DependencyInjection/Compiler/BundleCompilerPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

class BundleCompilerPass implements CompilerPassInterface
{
#[\Override]
public function process(ContainerBuilder $container)
{
$plugins = $container->getParameter('eccube.plugins.enabled');
Expand Down
1 change: 1 addition & 0 deletions codeception/_data/plugins/Bundle-1.0.1/Bundle/BundleBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

class BundleBundle extends Bundle
{
#[\Override]
public function build(ContainerBuilder $container)
{
parent::build($container);
Expand Down
1 change: 1 addition & 0 deletions codeception/_data/plugins/Bundle-1.0.1/DependencyInjection/Compiler/BundleCompilerPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

class BundleCompilerPass implements CompilerPassInterface
{
#[\Override]
public function process(ContainerBuilder $container)
{
$plugins = $container->getParameter('eccube.plugins.enabled');
Expand Down
5 changes: 5 additions & 0 deletions codeception/_data/plugins/Emperor-1.0.0/PluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

class PluginManager extends AbstractPluginManager
{
#[\Override]
public function install(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -34,6 +35,7 @@ public function install(array $config, ContainerInterface $container)
$entityManager->flush($foo);
}

#[\Override]
public function enable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -43,6 +45,7 @@ public function enable(array $config, ContainerInterface $container)
$entityManager->find(Foo::class, 1);
}

#[\Override]
public function disable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -52,6 +55,7 @@ public function disable(array $config, ContainerInterface $container)
$entityManager->find(Foo::class, 1);
}

#[\Override]
public function update(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -61,6 +65,7 @@ public function update(array $config, ContainerInterface $container)
$entityManager->find(Foo::class, 1);
}

#[\Override]
public function uninstall(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand Down
5 changes: 5 additions & 0 deletions codeception/_data/plugins/Emperor-1.0.1/PluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

class PluginManager extends AbstractPluginManager
{
#[\Override]
public function install(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -31,6 +32,7 @@ public function install(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 1);
}

#[\Override]
public function enable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -40,6 +42,7 @@ public function enable(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 1);
}

#[\Override]
public function disable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -49,6 +52,7 @@ public function disable(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 1);
}

#[\Override]
public function update(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -59,6 +63,7 @@ public function update(array $config, ContainerInterface $container)
$entityManager->find(Bar::class, 1);
}

#[\Override]
public function uninstall(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand Down
5 changes: 5 additions & 0 deletions codeception/_data/plugins/Horizon-1.0.0/PluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

class PluginManager extends AbstractPluginManager
{
#[\Override]
public function install(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -36,6 +37,7 @@ public function install(array $config, ContainerInterface $container)
$entityManager->flush($horizon);
}

#[\Override]
public function enable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -45,6 +47,7 @@ public function enable(array $config, ContainerInterface $container)
$entityManager->find(Dash::class, 1);
}

#[\Override]
public function disable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -54,6 +57,7 @@ public function disable(array $config, ContainerInterface $container)
$entityManager->find(Dash::class, 1);
}

#[\Override]
public function update(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -63,6 +67,7 @@ public function update(array $config, ContainerInterface $container)
$entityManager->find(Dash::class, 1);
}

#[\Override]
public function uninstall(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand Down
5 changes: 5 additions & 0 deletions codeception/_data/plugins/Horizon-1.0.1/PluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

class PluginManager extends AbstractPluginManager
{
#[\Override]
public function install(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -36,6 +37,7 @@ public function install(array $config, ContainerInterface $container)
$entityManager->flush($horizon);
}

#[\Override]
public function enable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -45,6 +47,7 @@ public function enable(array $config, ContainerInterface $container)
$entityManager->find(Dash::class, 1);
}

#[\Override]
public function disable(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -54,6 +57,7 @@ public function disable(array $config, ContainerInterface $container)
$entityManager->find(Dash::class, 1);
}

#[\Override]
public function update(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand All @@ -71,6 +75,7 @@ public function update(array $config, ContainerInterface $container)
$entityManager->flush($newHorizon);
}

#[\Override]
public function uninstall(array $config, ContainerInterface $container)
{
echo '*******************************************'.PHP_EOL;
Expand Down
1 change: 1 addition & 0 deletions codeception/_support/AcceptanceTester.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class AcceptanceTester extends Actor
{
use AcceptanceTesterActions;

#[\Override]
public function getScenario(): Scenario
{
return $this->scenario;
Expand Down
1 change: 1 addition & 0 deletions codeception/_support/Helper/Acceptance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
// all public methods declared in helper class will be available in $I
class Acceptance extends Module
{
#[\Override]
public function _initialize()
{
$this->clearDownloadDir();
Expand Down
1 change: 1 addition & 0 deletions codeception/_support/Interactions/WaitAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public function __construct($timeout_in_second)
$this->timeout_in_second = $timeout_in_second;
}

#[\Override]
public function perform()
{
sleep($this->timeout_in_second);
Expand Down
1 change: 1 addition & 0 deletions codeception/_support/Page/Admin/AbstractAdminPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ abstract class AbstractAdminPage extends AbstractPage
*
* @return $this
*/
#[\Override]
protected function goPage($url, $pageTitle = '')
{
$config = Fixtures::get('config');
Expand Down
1 change: 1 addition & 0 deletions codeception/_support/Page/Admin/AbstractAdminPageStyleGuide.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ abstract class AbstractAdminPageStyleGuide extends AbstractAdminPage
*
* @return $this
*/
#[\Override]
protected function atPage($pageTitle)
{
$this->tester->see($pageTitle, '.c-pageTitle');
Expand Down
5 changes: 5 additions & 0 deletions codeception/acceptance/EA10PluginCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ public function __construct(AcceptanceTester $I)
$this->traits[\Plugin\Horizon\Entity\CartTrait::class] = 'src/Eccube/Entity/Cart';
}

#[\Override]
public function アップデート()
{
// アップデートで新たしいカラムが追加される
Expand All @@ -892,6 +893,7 @@ public function __construct(AcceptanceTester $I)
$this->traits[\Plugin\Horizon\Entity\CartTrait::class] = 'src/Eccube/Entity/Cart';
}

#[\Override]
public function アップデート()
{
// アップデートで新たしいカラムが追加される
Expand Down Expand Up @@ -947,6 +949,7 @@ public static function start(AcceptanceTester $I, ?Store_Plugin $dependency = nu
return new self($I, $dependency);
}

#[\Override]
public function アップデート()
{
$this->tables = ['dtb_bar'];
Expand Down Expand Up @@ -1041,13 +1044,15 @@ public function __construct(AcceptanceTester $I)
$this->tables[] = 'oauth2_authorization_code';
}

#[\Override]
public function 有効化()
{
parent::有効化();

return $this;
}

#[\Override]
public function 無効化()
{
parent::無効化();
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
},
"config": {
"platform": {
"php": "8.4.11"
"php": "8.3.24"
},
"preferred-install": {
"*": "dist"
Expand Down
2 changes: 1 addition & 1 deletion rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
ClosureToArrowFunctionRector::class, // アロー関数への変換は一旦スキップ
RemoveNullTagValueNodeRector::class, // null の @var タグを削除する
// TODO:以下を適用する
AddOverrideAttributeToOverriddenMethodsRector::class, // オーバーライドメソッドに @Override 属性を追加する PHP 8.3 以降で有効
//AddOverrideAttributeToOverriddenMethodsRector::class, // オーバーライドメソッドに @Override 属性を追加する PHP 8.3 以降で有効
AddTypeToConstRector::class, // 定数に型を追加する PHP 8.3 以降で有効

// 8.3以下が対象のものを適用する
Expand Down
1 change: 1 addition & 0 deletions src/Eccube/Twig/Template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public function getDebugInfo(): array
return [];
}

#[\Override]
protected function doDisplay(array $context, array $blocks = []): iterable
{
// Templateのキャッシュ作成時に動的に作成されるメソッド
Expand Down
1 change: 1 addition & 0 deletions tests/Eccube/Tests/Command/AbstractCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ abstract class AbstractCommandTest extends EccubeTestCase
*/
protected $loopCheckSum = 0;

#[\Override]
protected function tearDown(): void
{
parent::tearDown();
Expand Down
2 changes: 2 additions & 0 deletions tests/Eccube/Tests/Command/CsvLoaderCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ class CsvLoaderCommandTest extends AbstractCommandTest
/** @var \SplFileObject */
protected $file;

#[\Override]
public static function setUpBeforeClass(): void
{
self::markTestIncomplete();
}

#[\Override]
protected function setUp(): void
{
$this->markTestIncomplete(static::class.' は未実装です');
Expand Down
Loading