WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@markatosi
Copy link
Contributor

Avoids warnings on non-supported platform

Copilot AI review requested due to automatic review settings December 12, 2025 23:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increments the package version from 0.2.0 to 0.3.0 and introduces significant changes to improve the codebase, including migration checks, integration test improvements, API updates, and entity documentation enhancements.

Key Changes:

  • Added comprehensive migration validation system via ElectronNET.MigrationChecks.targets to enforce project structure requirements
  • Modernized integration tests with base classes, custom attributes, and improved platform-specific test handling
  • Updated API entities with Electron 39.2 compatibility and enhanced documentation
  • Added new WebContents API methods for zoom, audio, DevTools, and user agent management

Reviewed changes

Copilot reviewed 192 out of 194 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/common.props Version bump from 0.2.0 to 0.3.0
src/ElectronNET/build/ElectronNET.MigrationChecks.targets New migration validation system for project structure enforcement
src/ElectronNET/build/ElectronNET.LateImport.targets Removed PublishUrl property and added output directory configuration
src/ElectronNET/build/ElectronNET.Core.targets Imports migration checks targets
src/ElectronNET.IntegrationTests/* Refactored tests to use base class and custom attributes for better platform handling
src/ElectronNET.Host/api/webContents.* Added WebContents API methods for zoom, DevTools, audio, and user agent
src/ElectronNET.API/API/WebContents.cs Added C# API wrappers for new WebContents features
src/ElectronNET.API/API/Entities/* Updated entity documentation and added Electron 39.2 compatibility markers
Comments suppressed due to low confidence (2)

src/ElectronNET.IntegrationTests/Tests/BrowserWindowTests.cs:1

  • The ProgressBarOptions constructor call should explicitly set the Mode property if a specific mode is intended. The previous code included Mode = ProgressBarMode.normal, but the new code relies on the default. If the intent is to use the default mode (now set to 'normal' in ProgressBarOptions), this is acceptable. However, if a specific mode was intentional, it should be explicitly set for clarity.
    src/ElectronNET.API/API/Entities/PrintOptions.cs:1
  • The type of Copies was changed from bool to int, which is the correct type according to Electron's PrintOptions documentation. However, this is a breaking change that could cause compilation errors in existing code that uses this property as a boolean.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@softworkz
Copy link
Collaborator

194 changed files?

@markatosi
Copy link
Contributor Author

Uhm... no? I only modified the readme.md

@softworkz softworkz changed the base branch from main to develop December 13, 2025 01:16
@softworkz
Copy link
Collaborator

You need to mak the PR onto the develop branch. But I just noticed that I can change that - and did it.

@FlorianRappl FlorianRappl merged commit c53a5a9 into ElectronNET:develop Dec 13, 2025
40 of 41 checks passed
@FlorianRappl FlorianRappl added this to the 0.3.0 milestone Dec 13, 2025
@FlorianRappl FlorianRappl mentioned this pull request Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The use of AutoHideMenuBar in example code on landing page causes a warning.

3 participants