WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Support preprocessor directives for server-code scopes. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webbju merged 2 commits into from
Dec 5, 2025
Merged

Support preprocessor directives for server-code scopes. #20

webbju merged 2 commits into from
Dec 5, 2025

Conversation

@webbju
Copy link
Member

@webbju webbju commented Dec 5, 2025 •
edited
Loading

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

  • Support parsing of preprocessor directives using a self-contained PREPROCESSOR channel.
  • Simplify identification of existing server-only scopes (#ifdef WITH_SERVER) to prevent injection of duplicate guards.
  • Interestingly, this is a similar approach to that proposed by Add a way to lint and generate #ifdefs around UEventAPI calls. #15.

@webbju webbju marked this pull request as ready for review December 5, 2025 13:24
@webbju webbju requested a review from tvandijck as a code owner December 5, 2025 13:24
@webbju webbju requested a review from arturjpv December 5, 2025 13:24
arturjpv
arturjpv approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@arturjpv arturjpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@webbju webbju merged commit ffc8bca into main Dec 5, 2025
1 check passed
@webbju webbju deleted the webbju/support-preprocessor-guard-parsing branch December 5, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturjpv arturjpv arturjpv approved these changes

@tvandijck tvandijck Awaiting requested review from tvandijck tvandijck is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@webbju @arturjpv