WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@1-alex98
Copy link
Member

Fixes #112

@1-alex98 1-alex98 requested a review from micheljung January 19, 2019 15:25
@coveralls
Copy link

coveralls commented Jan 19, 2019

Coverage Status

Coverage decreased (-0.01%) to 84.448% when pulling 34f1633 on bugfix/#112-dont-close-peers-on-no-con into e4f2b81 on develop.

Geosearchef
Geosearchef previously approved these changes Jan 19, 2019
Copy link
Member

@Geosearchef Geosearchef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

}

/**
* Removes player from his current game. It removes player completely by default, if running it does leave the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes player from their current game ;)

}

private void removePlayer(Game game, Player player) {
private void removePlayer(Game game, Player player, boolean reconnectPossible) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowReconnect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants