-
Notifications
You must be signed in to change notification settings - Fork 7
Added Languages #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Languages #27
Conversation
williamdes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the translation method and source?
I reviewed the french part.
@MauricioFauth what do you think about localization/pt_BR.inc ?
|
I used Deepl |
Okay |
|
Yes, it would be best to have someone reasonably familiar with the language to sign off on the translation. Also, we do not need country specific locales if the text is identical (e.g. there are several english or german versions that are all identical). |
|
I can speak spanish. It translated the Spanish good. Did it not do French any justice? |
Co-authored-by: Maurício Meneghini Fauth <[email protected]>
Co-authored-by: Maurício Meneghini Fauth <[email protected]>
Co-authored-by: William Desportes <[email protected]>
Co-authored-by: William Desportes <[email protected]>
Not really, it did the mistake everybody does: using a non pure French word and with a meaning that is kind of wrong for this context as it would suggest that it is encrypted but that you have no way to decrypt it. And it changed e-mail to message. |
|
@iifawzi would you mind reviewing the languages you speak and know? |
|
I only know english and spanish and those are proper ... I used deepl to translate everything else. I have never had anyone make translations for me. I was just trying to help out. I will not use deepl anymore since we know it butchered the French file. Funny thing, the only french I know beyond greetings and goodbyes is "vous petite merde". I learned that when I was 12 years old and it stuck. I will be patient and see if others will help with translations. It will not hurt my feelings if you don't merge this with your repo. Thanks for your work ... |
Thank you for helping, this is a great initiative !
haha, this is not very complete and as is means "you small shit". It's say it should be "vous êtes une petite merde" to mean: "you are a small shit". No a nice thing but haha still 😄 I did not find you an extract to have the pronunciation but this film extract has "merde" part of it: https://www.youtube.com/watch?v=ZTg3qYpfySA
Okay, I will search for users to validate translations |
| <?php | ||
| $labels = array(); | ||
| $labels['internal'] = 'Pošta byla interní'; | ||
| $labels['unencrypted'] = 'Zpráva byla přijata přes nešifrované spojení!'; | ||
| ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nijel does this translation sound okay ?
localization/en_GB.inc
Outdated
| @@ -0,0 +1,5 @@ | |||
| <?php | |||
| $labels = array(); | |||
| $labels['internal'] = 'Mail was internal'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lack context, but Mail is the system, email is the message itself, I think here email is what's is meant, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I find the "was" odd here; again, I lack context, but I think Internal Mail/email could be more meaningful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context is appears like this:
https://github.com/GermanCoding/Roundcube_TLS_Icon/raw/master/tls_icon_example.png
Thanks for the review, you can use suggestion blocks so the change gets committed by your name
|
I mean if the English source strings are poorly worded (which then results in bad translations), we can also fix the English strings. I drafted them up years ago without giving it much thought. |
Co-authored-by: Liviu-Mihail Concioiu <[email protected]>
Co-authored-by: Fawzi Essam <[email protected]>
Co-authored-by: Fawzi Essam <[email protected]>
Co-authored-by: Fawzi Essam <[email protected]>
|
|
||
| $labels['internal'] = "E-mail werd ontvangen via een interne verbinding"; | ||
| $labels['unencrypted'] = "Bericht werd ontvangen over een onversleutelde verbinding!"; | ||
| $labels['internal'] = 'Mail was intern'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the translation here
| @@ -0,0 +1,5 @@ | |||
| <?php | |||
| $labels = array(); | |||
| $labels['internal'] = 'Mail was intern'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation
|
I want to cut a release for the bugfix we merged the other day, but I don't think this is fully ready yet. Will hold off on this for the next release. |
No description provided.