WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@texxasrulez
Copy link

No description provided.

Copy link
Collaborator

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the translation method and source?
I reviewed the french part.

@MauricioFauth what do you think about localization/pt_BR.inc ?

@texxasrulez
Copy link
Author

I used Deepl

@williamdes
Copy link
Collaborator

I used Deepl

Okay
What your take on this @GermanCoding?
for me translations should be reviewed by at least one person of the language

@GermanCoding
Copy link
Owner

Yes, it would be best to have someone reasonably familiar with the language to sign off on the translation. Also, we do not need country specific locales if the text is identical (e.g. there are several english or german versions that are all identical).

@texxasrulez
Copy link
Author

I can speak spanish. It translated the Spanish good. Did it not do French any justice?

texxasrulez and others added 4 commits September 9, 2025 15:30
Co-authored-by: Maurício Meneghini Fauth <[email protected]>
Co-authored-by: Maurício Meneghini Fauth <[email protected]>
Co-authored-by: William Desportes <[email protected]>
Co-authored-by: William Desportes <[email protected]>
@williamdes
Copy link
Collaborator

I can speak spanish. It translated the Spanish good. Did it not do French any justice?

Not really, it did the mistake everybody does: using a non pure French word and with a meaning that is kind of wrong for this context as it would suggest that it is encrypted but that you have no way to decrypt it.
a website about it https://chiffrer.info/

And it changed e-mail to message.
And also e-mail to courrier. But that means a postal letter. That kind of works but not everybody would says it makes sense. It should have been "courrier électronique". Meaning electronic letter.
But I decided to keep message for the translation.
We will see if French users want another version someday.

@williamdes
Copy link
Collaborator

@iifawzi would you mind reviewing the languages you speak and know?

@texxasrulez
Copy link
Author

I only know english and spanish and those are proper ... I used deepl to translate everything else. I have never had anyone make translations for me. I was just trying to help out. I will not use deepl anymore since we know it butchered the French file. Funny thing, the only french I know beyond greetings and goodbyes is "vous petite merde". I learned that when I was 12 years old and it stuck. I will be patient and see if others will help with translations. It will not hurt my feelings if you don't merge this with your repo. Thanks for your work ...

@williamdes
Copy link
Collaborator

I only know english and spanish and those are proper ... I used deepl to translate everything else. I have never had anyone make translations for me. I was just trying to help out. I will not use deepl anymore since we know it butchered the French file.

Thank you for helping, this is a great initiative !
And it is appreciated, let's just review a bit what the tool did output.
The French mistakes also got into the pt_BR file from what I read in the comments.
I use deepL too, it works fine but sometimes needs some adjustments.

Funny thing, the only french I know beyond greetings and goodbyes is "vous petite merde". I learned that when I was 12 years old and it stuck.

haha, this is not very complete and as is means "you small shit". It's say it should be "vous êtes une petite merde" to mean: "you are a small shit". No a nice thing but haha still 😄

I did not find you an extract to have the pronunciation but this film extract has "merde" part of it: https://www.youtube.com/watch?v=ZTg3qYpfySA

I will be patient and see if others will help with translations. It will not hurt my feelings if you don't merge this with your repo. Thanks for your work ...

Okay, I will search for users to validate translations

Comment on lines +1 to +5
<?php
$labels = array();
$labels['internal'] = 'Pošta byla interní';
$labels['unencrypted'] = 'Zpráva byla přijata přes nešifrované spojení!';
?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nijel does this translation sound okay ?

@@ -0,0 +1,5 @@
<?php
$labels = array();
$labels['internal'] = 'Mail was internal';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack context, but Mail is the system, email is the message itself, I think here email is what's is meant, no?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I find the "was" odd here; again, I lack context, but I think Internal Mail/email could be more meaningful

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context is appears like this:
https://github.com/GermanCoding/Roundcube_TLS_Icon/raw/master/tls_icon_example.png
Thanks for the review, you can use suggestion blocks so the change gets committed by your name

@GermanCoding
Copy link
Owner

I mean if the English source strings are poorly worded (which then results in bad translations), we can also fix the English strings. I drafted them up years ago without giving it much thought.


$labels['internal'] = "E-mail werd ontvangen via een interne verbinding";
$labels['unencrypted'] = "Bericht werd ontvangen over een onversleutelde verbinding!";
$labels['internal'] = 'Mail was intern';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the translation here

@@ -0,0 +1,5 @@
<?php
$labels = array();
$labels['internal'] = 'Mail was intern';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translation

@GermanCoding
Copy link
Owner

I want to cut a release for the bugfix we merged the other day, but I don't think this is fully ready yet. Will hold off on this for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants