allow customizing timeout values #5940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable timeout value for the EDW create index benchmark to accommodate varying index building times across different database providers. The change replaces a hardcoded timeout value with a configurable flag.
- Adds a new command-line flag
edw_create_index_benchmark_timeoutwith a default value of 600 seconds - Updates the
_MeasureBuildingTimefunction's default timeout parameter from 120 to 600 seconds - Modifies the
Runfunction to pass the configurable timeout value to_MeasureBuildingTime
Comment on lines
+58
to
+59
| 'Timeout for the edw_create_index_benchmark in seconds. Default is 600' | ||
| ' seconds', |
There was a problem hiding this comment.
[nitpick] The description should end with a period for consistency with other flag descriptions.
Suggested change
| 'Timeout for the edw_create_index_benchmark in seconds. Default is 600' | |
| ' seconds', | |
| 'Timeout for the edw_create_index_benchmark in seconds. Default is 600.' | |
| ' seconds.', |
Contributor
|
Having a flag for the timeout is good, although I recommend setting a default value high enough that all providers that complete in a reasonable time come in under the timeout -- if a provider finishes way before the timeout, that's no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to config timeout value for this benchmark because the time needed for index covering 100% varies a lot by provider. Hardcoded value fitting one provider will be too large/too small for other provider(s)