Auto generate import id for IAM resource tests #15306

trodge · 2025-10-03T18:21:17Z

fixes hashicorp/terraform-provider-google#8712

Release Note Template for Downstream PRs (will be copied)

trodge · 2025-10-06T19:59:55Z

*IamGenerated test failures are definitely related:

  error=
  | exit status 1
  | 
  | Error: Cannot import non-existent remote object
  | 
  | While attempting to import an existing object to
  | "google_iap_web_type_app_engine_iam_policy.foo", the provider detected that
  | no object exists with the given id. Only pre-existing objects can be
  | imported; check that the id is correct and that it is associated with the
  | provider's configured region or endpoint, or use "terraform apply" to create
  | a new remote object for this resource.

Seems like the resource name parameter is not correct, but I'm not sure where to get the correct one from based on @melinath 's comment

melinath

@trodge I think this is probably pretty close. I'd recommend checking what's happening on import for the failing tests vs the successful equivalent in nightlies. For example, TestAccHealthcareConsentStoreIamPolicyGenerated.

In this PR it's trying to import:

/v1beta1/projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-my-datasetzdt37nbfyb%20projects/ci-test-project-188019/locations/us-central1/datasets/tf-test-my-datasetzdt37nbfyb/consentStores/tf-test-my-consent-storezdt37nbfyb:getIamPolicy

vs in nightlies:

/v1beta1/projects/{project}/locations/us-central1/datasets/tf-test-my-datasetgbc74ngpjk/consentStores/tf-test-my-consent-storegbc74ngpjk

Looks like there's an extra %20 in the first one, plus it's putting in the full path of the dataset and then also the full path of the consent store, when it only actually needs the consent store.

(It's possible you'll need to convert full URLs to shortnames for each part as part of the func you're making.)

mmv1/templates/terraform/examples/base_configs/iam_test_file.go.tmpl

modular-magician · 2025-10-29T22:39:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 86 files changed, 7506 insertions(+), 634 deletions(-))
google-beta provider: Diff ( 106 files changed, 9238 insertions(+), 763 deletions(-))

modular-magician · 2025-10-29T23:42:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 86 files changed, 9246 insertions(+), 634 deletions(-))
google-beta provider: Diff ( 106 files changed, 11332 insertions(+), 763 deletions(-))

modular-magician · 2025-10-30T02:00:27Z

Tests analytics

Total tests: 3094
Passed tests: 2757
Skipped tests: 255
Affected tests: 82

Click here to see the affected service packages

servicedirectory

vertexai

bigquery

cloudrun

dataform

datafusion

dns

iap

apigee

binaryauthorization

cloudfunctions2

cloudrunv2

cloudtasks

gkehub

workstations

apigateway

containeranalysis

datacatalog

dataplex

dataprocmetastore

iambeta

notebooks

workbench

beyondcorp

bigqueryanalyticshub

bigqueryconnection

gkebackup

bigquerydatapolicy

bigquerydatapolicyv2

cloudbuildv2

colab

networksecurity

privateca

secretmanager

servicemanagement

clouddeploy

gkehub2

runtimeconfig

sourcerepo

artifactregistry

cloudfunctions

healthcare

logging

pubsub

compute

dataproc

iamworkforcepool

secretmanagerregional

securesourcemanager

Action taken

Found 82 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentIamBindingGenerated

TestAccApigeeEnvironmentIamMemberGenerated

TestAccApigeeEnvironmentIamPolicyGenerated

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition

TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition

TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition

TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition

TestAccComputeBackendServiceIamBindingGenerated_withCondition

TestAccComputeBackendServiceIamMemberGenerated_withCondition

TestAccComputeImageIamBindingGenerated_withCondition

TestAccComputeImageIamMemberGenerated_withCondition

TestAccComputeInstanceIamBindingGenerated_withCondition

TestAccComputeInstanceIamMemberGenerated_withCondition

TestAccComputeInstanceTemplateIamBindingGenerated_withCondition

TestAccComputeInstanceTemplateIamMemberGenerated_withCondition

TestAccComputeInstantSnapshotIamBindingGenerated_withCondition

TestAccComputeInstantSnapshotIamMemberGenerated_withCondition

TestAccComputeMachineImageIamBindingGenerated_withCondition

TestAccComputeMachineImageIamMemberGenerated_withCondition

TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition

TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition

TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

TestAccComputeSubnetworkIamBindingGenerated_withCondition

TestAccComputeSubnetworkIamMemberGenerated_withCondition

TestAccDataFusionInstance_dataFusionInstanceCmekExample

TestAccDataprocMetastoreDatabaseIamBindingGenerated

TestAccDataprocMetastoreDatabaseIamMemberGenerated

TestAccDataprocMetastoreDatabaseIamPolicyGenerated

TestAccDataprocMetastoreTableIamBindingGenerated

TestAccDataprocMetastoreTableIamMemberGenerated

TestAccDataprocMetastoreTableIamPolicyGenerated

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withCondition

TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withCondition

TestAccIapAppEngineVersionIamBindingGenerated

TestAccIapAppEngineVersionIamBindingGenerated_withCondition

TestAccIapAppEngineVersionIamMemberGenerated

TestAccIapAppEngineVersionIamMemberGenerated_withCondition

TestAccIapAppEngineVersionIamPolicyGenerated

TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

TestAccIapTunnelIamBindingGenerated_withCondition

TestAccIapTunnelIamMemberGenerated_withCondition

TestAccIapTunnelInstanceIamBindingGenerated_withCondition

TestAccIapTunnelInstanceIamMemberGenerated_withCondition

TestAccIapWebBackendServiceIamBindingGenerated_withCondition

TestAccIapWebBackendServiceIamMemberGenerated_withCondition

TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition

TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition

TestAccIapWebForwardingRuleServiceIamBindingGenerated_withCondition

TestAccIapWebForwardingRuleServiceIamMemberGenerated_withCondition

TestAccIapWebIamBindingGenerated_withCondition

TestAccIapWebIamMemberGenerated_withCondition

TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition

TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition

TestAccIapWebRegionForwardingRuleServiceIamBindingGenerated_withCondition

TestAccIapWebRegionForwardingRuleServiceIamMemberGenerated_withCondition

TestAccIapWebTypeAppEngineIamBindingGenerated

TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition

TestAccIapWebTypeAppEngineIamMemberGenerated

TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition

TestAccIapWebTypeAppEngineIamPolicyGenerated

TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition

TestAccIapWebTypeComputeIamBindingGenerated_withCondition

TestAccIapWebTypeComputeIamMemberGenerated_withCondition

TestAccPrivatecaCaPoolIamBindingGenerated_withCondition

TestAccPrivatecaCaPoolIamMemberGenerated_withCondition

TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition

TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition

TestAccSecretManagerRegionalRegionalSecretIamBindingGenerated_withCondition

TestAccSecretManagerRegionalRegionalSecretIamMemberGenerated_withCondition

TestAccSecretManagerSecretIamBindingGenerated_withCondition

TestAccSecretManagerSecretIamMemberGenerated_withCondition

TestAccSourceRepoRepositoryIamBindingGenerated

TestAccSourceRepoRepositoryIamMemberGenerated

TestAccSourceRepoRepositoryIamPolicyGenerated

TestAccVertexAIEndpointIamBindingGenerated

TestAccVertexAIEndpointIamMemberGenerated

TestAccVertexAIEndpointIamPolicyGenerated

TestAccVertexAIEndpoint_vertexAiEndpointPrivateServiceConnectExample

TestAccVertexAIFeaturestoreEntitytypeIamBindingGenerated

TestAccVertexAIFeaturestoreEntitytypeIamMemberGenerated

TestAccVertexAIFeaturestoreEntitytypeIamPolicyGenerated

Get to know how VCR tests work

trodge · 2025-10-30T17:40:37Z

/gcbrun

modular-magician · 2025-10-30T17:52:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 86 files changed, 9246 insertions(+), 634 deletions(-))
google-beta provider: Diff ( 106 files changed, 11332 insertions(+), 763 deletions(-))

modular-magician · 2025-10-30T20:11:07Z

Tests analytics

Total tests: 3095
Passed tests: 2762
Skipped tests: 255
Affected tests: 78

Click here to see the affected service packages

dataplex

iambeta

secretmanagerregional

binaryauthorization

dataform

healthcare

bigquerydatapolicy

bigquerydatapolicyv2

datafusion

logging

networksecurity

servicedirectory

servicemanagement

workbench

dns

gkebackup

gkehub

apigee

artifactregistry

colab

gkehub2

privateca

runtimeconfig

securesourcemanager

sourcerepo

bigquery

cloudfunctions

cloudrun

cloudtasks

compute

dataproc

iap

secretmanager

apigateway

bigqueryconnection

cloudfunctions2

cloudrunv2

dataprocmetastore

iamworkforcepool

notebooks

pubsub

beyondcorp

bigqueryanalyticshub

cloudbuildv2

datacatalog

vertexai

workstations

clouddeploy

containeranalysis

Action taken

Found 78 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentIamBindingGenerated

TestAccApigeeEnvironmentIamMemberGenerated

TestAccApigeeEnvironmentIamPolicyGenerated

TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition

TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition

TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition

TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition

TestAccComputeBackendServiceIamBindingGenerated_withCondition

TestAccComputeBackendServiceIamMemberGenerated_withCondition

TestAccComputeImageIamBindingGenerated_withCondition

TestAccComputeImageIamMemberGenerated_withCondition

TestAccComputeInstanceIamBindingGenerated_withCondition

TestAccComputeInstanceIamMemberGenerated_withCondition

TestAccComputeInstanceTemplateIamBindingGenerated_withCondition

TestAccComputeInstanceTemplateIamMemberGenerated_withCondition

TestAccComputeInstantSnapshotIamBindingGenerated_withCondition

TestAccComputeInstantSnapshotIamMemberGenerated_withCondition

TestAccComputeMachineImageIamBindingGenerated_withCondition

TestAccComputeMachineImageIamMemberGenerated_withCondition

TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition

TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition

TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

TestAccComputeSubnetworkIamBindingGenerated_withCondition

TestAccComputeSubnetworkIamMemberGenerated_withCondition

TestAccDataFusionInstance_dataFusionInstanceCmekExample

TestAccDataprocMetastoreDatabaseIamBindingGenerated

TestAccDataprocMetastoreDatabaseIamMemberGenerated

TestAccDataprocMetastoreDatabaseIamPolicyGenerated

TestAccDataprocMetastoreTableIamBindingGenerated

TestAccDataprocMetastoreTableIamMemberGenerated

TestAccDataprocMetastoreTableIamPolicyGenerated

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccIAMBetaWorkloadIdentityPoolIamBindingGenerated_withCondition

TestAccIAMBetaWorkloadIdentityPoolIamMemberGenerated_withCondition

TestAccIapAppEngineVersionIamBindingGenerated

TestAccIapAppEngineVersionIamBindingGenerated_withCondition

TestAccIapAppEngineVersionIamMemberGenerated

TestAccIapAppEngineVersionIamMemberGenerated_withCondition

TestAccIapAppEngineVersionIamPolicyGenerated

TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

TestAccIapTunnelIamBindingGenerated_withCondition

TestAccIapTunnelIamMemberGenerated_withCondition

TestAccIapTunnelInstanceIamBindingGenerated_withCondition

TestAccIapTunnelInstanceIamMemberGenerated_withCondition

TestAccIapWebBackendServiceIamBindingGenerated_withCondition

TestAccIapWebBackendServiceIamMemberGenerated_withCondition

TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition

TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition

TestAccIapWebForwardingRuleServiceIamBindingGenerated_withCondition

TestAccIapWebForwardingRuleServiceIamMemberGenerated_withCondition

TestAccIapWebIamBindingGenerated_withCondition

TestAccIapWebIamMemberGenerated_withCondition

TestAccIapWebRegionBackendServiceIamBindingGenerated_withCondition

TestAccIapWebRegionBackendServiceIamMemberGenerated_withCondition

TestAccIapWebRegionForwardingRuleServiceIamBindingGenerated_withCondition

TestAccIapWebRegionForwardingRuleServiceIamMemberGenerated_withCondition

TestAccIapWebTypeAppEngineIamBindingGenerated

TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition

TestAccIapWebTypeAppEngineIamMemberGenerated

TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition

TestAccIapWebTypeAppEngineIamPolicyGenerated

TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition

TestAccIapWebTypeComputeIamBindingGenerated_withCondition

TestAccIapWebTypeComputeIamMemberGenerated_withCondition

TestAccPrivatecaCaPoolIamBindingGenerated_withCondition

TestAccPrivatecaCaPoolIamMemberGenerated_withCondition

TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition

TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition

TestAccSecretManagerRegionalRegionalSecretIamBindingGenerated_withCondition

TestAccSecretManagerRegionalRegionalSecretIamMemberGenerated_withCondition

TestAccSecretManagerSecretIamBindingGenerated_withCondition

TestAccSecretManagerSecretIamMemberGenerated_withCondition

TestAccSourceRepoRepositoryIamBindingGenerated

TestAccSourceRepoRepositoryIamMemberGenerated

TestAccSourceRepoRepositoryIamPolicyGenerated

TestAccVertexAIFeaturestoreEntitytypeIamBindingGenerated

TestAccVertexAIFeaturestoreEntitytypeIamMemberGenerated

TestAccVertexAIFeaturestoreEntitytypeIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2025-11-03T18:58:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 87 files changed, 5434 insertions(+), 578 deletions(-))
google-beta provider: Diff ( 107 files changed, 6669 insertions(+), 694 deletions(-))

modular-magician · 2025-11-03T19:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 87 files changed, 5176 insertions(+), 578 deletions(-))
google-beta provider: Diff ( 107 files changed, 6351 insertions(+), 694 deletions(-))

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

modular-magician · 2025-12-09T22:30:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 91 files changed, 5366 insertions(+), 586 deletions(-))
google-beta provider: Diff ( 109 files changed, 6453 insertions(+), 702 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

melinath

LGTM assuming there are no related test failures. If it were possible for us to eliminate the custom import state id funcs in the future that would be great, but it seems like a reasonable cost for the benefit for now.

modular-magician · 2025-12-10T00:44:52Z

Tests analytics

Total tests: 5851
Passed tests: 5211
Skipped tests: 605
Affected tests: 35

Click here to see the affected service packages

All service packages are affected

Action taken

Found 35 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__gcp_user_access_binding

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy

TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8

TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1

TestAccBigQueryExternalDataTable_queryAcceleration

TestAccComposerEnvironmentComposer3_databaseRetention

TestAccComposerEnvironmentComposer3_updateFromEmpty

TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork

TestAccComposerEnvironmentComposer3_upgrade_expectError

TestAccComposerEnvironment_UpdateComposerV2ImageVersion

TestAccComposerEnvironment_UpdateComposerV2ResilienceMode

TestAccComposerUserWorkloadsSecret_update

TestAccComputeFutureReservation_sharedFutureReservationExample

TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

TestAccContainerCluster_networkPerformanceConfig

TestAccContainerCluster_withTPUConfig

TestAccContainerCluster_withTpu

TestAccContainerNodePool_secondaryBootDisks

TestAccDataFusionInstance_dataFusionInstanceCmekExample

TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample

TestAccDialogflowCXTestCase_update

TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample

TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update

TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccIapWebTypeAppEngineIamBindingGenerated

TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition

TestAccIapWebTypeAppEngineIamMemberGenerated

TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition

TestAccIapWebTypeAppEngineIamPolicyGenerated

TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition

TestAccSourceRepoRepositoryIamBindingGenerated

TestAccSourceRepoRepositoryIamMemberGenerated

TestAccSourceRepoRepositoryIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2025-12-10T01:37:56Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_EuropeWest8 [Debug log]
TestAccComposerEnvironmentComposer3_upgrade_expectError [Debug log]
TestAccComposerEnvironment_UpdateComposerV2ResilienceMode [Debug log]
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccBigQueryExternalDataTable_connectionIdDiff_UseIdReference_UsEast1 [Error message] [Debug log]
TestAccBigQueryExternalDataTable_queryAcceleration [Error message] [Debug log]
TestAccComposerEnvironmentComposer3_databaseRetention [Error message] [Debug log]
TestAccComposerEnvironmentComposer3_updateFromEmpty [Error message] [Debug log]
TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork [Error message] [Debug log]
TestAccComposerEnvironment_UpdateComposerV2ImageVersion [Error message] [Debug log]
TestAccComposerUserWorkloadsSecret_update [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]
TestAccDataFusionInstance_dataFusionInstanceCmekExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample [Error message] [Debug log]
TestAccDiscoveryEngineCmekConfig_discoveryengineCmekconfigDefaultExample_update [Error message] [Debug log]
TestAccGKEHubFeature_FleetDefaultMemberConfigPolicyController [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated [Error message] [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccIapWebTypeAppEngineIamMemberGenerated [Error message] [Debug log]
TestAccIapWebTypeAppEngineIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated [Error message] [Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccSourceRepoRepositoryIamBindingGenerated [Error message] [Debug log]
TestAccSourceRepoRepositoryIamMemberGenerated [Error message] [Debug log]
TestAccSourceRepoRepositoryIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician added the service/terraform label Oct 3, 2025

This comment was marked as outdated.

Sign in to view

trodge force-pushed the auto-generate-import-id branch from 7f6d491 to f0889e2 Compare October 3, 2025 23:50

This comment was marked as outdated.

Sign in to view

trodge requested a review from shuyama1 October 6, 2025 18:44

melinath requested changes Oct 7, 2025

View reviewed changes

mmv1/templates/terraform/examples/base_configs/iam_test_file.go.tmpl Outdated Show resolved Hide resolved

trodge force-pushed the auto-generate-import-id branch from a519602 to 9335680 Compare October 28, 2025 21:00

This comment was marked as outdated.

Sign in to view

trodge force-pushed the auto-generate-import-id branch from fcf7309 to 655b664 Compare October 29, 2025 22:28

trodge changed the title ~~WIP Auto generate import~~ Auto generate import id for IAM resource tests Oct 30, 2025

trodge marked this pull request as ready for review October 30, 2025 00:35

This comment was marked as outdated.

Sign in to view

trodge and others added 15 commits December 9, 2025 12:48

Use IamImportFormat

6791f88

Use IamImportQualifiersForTest

157fdb2

Add split

c4dde0e

Use IamImportParams

378ec95

Use IamImportFormatTemplate

b075f04

Replace name with parent resource name

0230a84

Add CustomStateIDFuncs

bacacd3

Prefer ImportFormat to SelfLinkUrl

3507ea0

Fix newline

244298a

Add custom state funcs

4fac165

fix typo

7276ba5

Update mmv1/third_party/terraform/acctest/resource_test_utils.go

f525adc

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

Use BuildIAMImportId

4d58816

Fix formatting

ae8e694

Fix formatting

23ddfbd

trodge force-pushed the auto-generate-import-id branch from 422ccd3 to f8e0259 Compare December 9, 2025 20:52

Use customTemplate

ccb34ab

trodge force-pushed the auto-generate-import-id branch from f8e0259 to ccb34ab Compare December 9, 2025 22:01

Rename StateIDFuncs to ImportStateIDFuncs

d49eb93

melinath approved these changes Dec 9, 2025

View reviewed changes

trodge added this pull request to the merge queue Dec 10, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 5d83324 Dec 10, 2025
26 of 27 checks passed

trodge deleted the auto-generate-import-id branch December 10, 2025 22:51

Auto generate import id for IAM resource tests #15306

Auto generate import id for IAM resource tests #15306

Conversation

trodge commented Oct 3, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

trodge commented Oct 6, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

modular-magician commented Oct 29, 2025

Diff report

Uh oh!

modular-magician commented Oct 29, 2025

Diff report

Uh oh!

This comment was marked as outdated.

modular-magician commented Oct 30, 2025

Tests analytics

Action taken

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

trodge commented Oct 30, 2025

Uh oh!

modular-magician commented Oct 30, 2025

Diff report

Uh oh!

modular-magician commented Oct 30, 2025

Tests analytics

Action taken

Uh oh!

This comment was marked as outdated.

modular-magician commented Nov 3, 2025

Diff report

Uh oh!

modular-magician commented Nov 3, 2025

Diff report

Uh oh!

modular-magician commented Dec 9, 2025

Diff report

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Dec 10, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants