WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@m-habib
Copy link
Member

@m-habib m-habib commented Dec 2, 2025

Introduce support for customization rules in Datastream stream resource, enabling the configuration of customization rules for the stream. Initially, this includes two rules for BigQuery Partitioning and BigQuery clustering.

Release Note Template for Downstream PRs (will be copied)

datastream: added support for the `rule_sets` field in the `google_datastream_stream` resource, allowing configuration of customization rules, such as BigQuery destinations partitioning and clustering (ga).

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1502 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 3 files changed, 1502 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 1791 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  rule_sets {
    customization_rules {
      bigquery_clustering {
        columns = # value needed
      }
      bigquery_partitioning {
        ingestion_time_partition {
          partitioning_time_granularity = # value needed
        }
        integer_range_partition {
          column   = # value needed
          end      = # value needed
          interval = # value needed
          start    = # value needed
        }
        require_partition_filter = # value needed
        time_unit_partition {
          column                        = # value needed
          partitioning_time_granularity = # value needed
        }
      }
    }
    object_filter {
      source_object_identifier {
        mongodb_identifier {
          collection = # value needed
          database   = # value needed
        }
        mysql_identifier {
          database = # value needed
          table    = # value needed
        }
        oracle_identifier {
          schema = # value needed
          table  = # value needed
        }
        postgresql_identifier {
          schema = # value needed
          table  = # value needed
        }
        salesforce_identifier {
          object_name = # value needed
        }
        sql_server_identifier {
          schema = # value needed
          table  = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 9
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1502 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 3 files changed, 1502 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 1791 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  rule_sets {
    customization_rules {
      bigquery_clustering {
        columns = # value needed
      }
      bigquery_partitioning {
        ingestion_time_partition {
          partitioning_time_granularity = # value needed
        }
        integer_range_partition {
          column   = # value needed
          end      = # value needed
          interval = # value needed
          start    = # value needed
        }
        require_partition_filter = # value needed
        time_unit_partition {
          column                        = # value needed
          partitioning_time_granularity = # value needed
        }
      }
    }
    object_filter {
      source_object_identifier {
        mongodb_identifier {
          collection = # value needed
          database   = # value needed
        }
        mysql_identifier {
          database = # value needed
          table    = # value needed
        }
        oracle_identifier {
          schema = # value needed
          table  = # value needed
        }
        postgresql_identifier {
          schema = # value needed
          table  = # value needed
        }
        salesforce_identifier {
          object_name = # value needed
        }
        sql_server_identifier {
          schema = # value needed
          table  = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 9
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@m-habib m-habib marked this pull request as ready for review December 8, 2025 19:13
@m-habib m-habib changed the title DRAFT - Add Customization Rules Support to google_datastream_stream Add Customization Rules Support to google_datastream_stream Dec 8, 2025
@m-habib m-habib changed the title Add Customization Rules Support to google_datastream_stream Introduce Customization Rules to google_datastream_stream Dec 8, 2025
@github-actions github-actions bot requested a review from trodge December 8, 2025 19:14
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@m-habib
Copy link
Member Author

m-habib commented Dec 8, 2025

Hi @trodge,

Testing this feature involves complex dependency creation, which makes it infeasible in the context of Terraform acceptance tests.
However, these changes have been tested locally with 100% line coverage, and I can provide the test logs privately upon request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants