-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Introduce Customization Rules to google_datastream_stream #15856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Introduce Customization Rules to google_datastream_stream #15856
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_datastream_stream" "primary" {
rule_sets {
customization_rules {
bigquery_clustering {
columns = # value needed
}
bigquery_partitioning {
ingestion_time_partition {
partitioning_time_granularity = # value needed
}
integer_range_partition {
column = # value needed
end = # value needed
interval = # value needed
start = # value needed
}
require_partition_filter = # value needed
time_unit_partition {
column = # value needed
partitioning_time_granularity = # value needed
}
}
}
object_filter {
source_object_identifier {
mongodb_identifier {
collection = # value needed
database = # value needed
}
mysql_identifier {
database = # value needed
table = # value needed
}
oracle_identifier {
schema = # value needed
table = # value needed
}
postgresql_identifier {
schema = # value needed
table = # value needed
}
salesforce_identifier {
object_name = # value needed
}
sql_server_identifier {
schema = # value needed
table = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 18 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_datastream_stream" "primary" {
rule_sets {
customization_rules {
bigquery_clustering {
columns = # value needed
}
bigquery_partitioning {
ingestion_time_partition {
partitioning_time_granularity = # value needed
}
integer_range_partition {
column = # value needed
end = # value needed
interval = # value needed
start = # value needed
}
require_partition_filter = # value needed
time_unit_partition {
column = # value needed
partitioning_time_granularity = # value needed
}
}
}
object_filter {
source_object_identifier {
mongodb_identifier {
collection = # value needed
database = # value needed
}
mysql_identifier {
database = # value needed
table = # value needed
}
oracle_identifier {
schema = # value needed
table = # value needed
}
postgresql_identifier {
schema = # value needed
table = # value needed
}
salesforce_identifier {
object_name = # value needed
}
sql_server_identifier {
schema = # value needed
table = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 18 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi @trodge, Testing this feature involves complex dependency creation, which makes it infeasible in the context of Terraform acceptance tests. |
Introduce support for customization rules in Datastream stream resource, enabling the configuration of customization rules for the stream. Initially, this includes two rules for BigQuery Partitioning and BigQuery clustering.
Release Note Template for Downstream PRs (will be copied)