feat(auditmanager): Add google_audit_manager_framework_audit resource #15879
Conversation
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| name: FrameworkAudit | ||
| base_url: "{{parent}}/frameworkAudits" | ||
| description: Represents a framework audit. | ||
| create_verb: :POST |
There was a problem hiding this comment.
It looks like you might be using docs that pre-date our move off of Ruby. You no longer need the : here or in other places, or the ruby/object declarations, etc. Please refer to https://googlecloudplatform.github.io/magic-modules/reference/ruby-go-changes/ for more details.
Fixing these will probably fix most of your bugs.
| --- | ||
| name: FrameworkAudit | ||
| base_url: "{{parent}}/frameworkAudits" | ||
| description: Represents a framework audit. |
There was a problem hiding this comment.
Please add a references section: https://googlecloudplatform.github.io/magic-modules/reference/resource/#references
| type: String | ||
| description: 'The compliance framework used for the audit.' | ||
| required: true | ||
| immutable: true |
There was a problem hiding this comment.
It looks like this resource may not support update-in-place. If that's correct, please mark the resource as a whole as immutable instead of individual fields. https://googlecloudplatform.github.io/magic-modules/reference/resource/#immutable
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // This file is maintained in the GoogleCloudPlatform/magic-modules repository and copied into the downstream provider repositories. Any changes to this file in the downstream will be overwritten. |
There was a problem hiding this comment.
Could you remove the formatting changes for this file & just make your change? We don't have a standard formatter for kotlin files, so I don't want to introduce whitespace etc. changes that might just get reverted later.
| "google_compute_region_backend_service": compute.DataSourceGoogleComputeRegionBackendService(), | ||
| "google_network_management_connectivity_test_run": networkmanagement.DataSourceGoogleNetworkManagementTestRun(), | ||
| "google_network_management_connectivity_tests": networkmanagement.DataSourceGoogleNetworkManagementConnectivityTests(), | ||
| "google_audit_manager_framework_audit_scope_report": dataSourceAuditManagerFrameworkAuditScopeReport(), |
There was a problem hiding this comment.
I don't see this function defined anywhere - does this data source exist in the codebase somewhere?
3 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.