WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@kigesui
Copy link
Contributor

@kigesui kigesui commented Dec 5, 2025

Fixes hashicorp/terraform-provider-google#24636

`google_apigee_security_feedback`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1034 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1034 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 202 insertions(+))

@kigesui kigesui marked this pull request as ready for review December 5, 2025 05:00
@github-actions github-actions bot requested a review from SirGitsalot December 5, 2025 05:01
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeSecurityFeedback_apigeeSecurityFeedbackBasicTestExample

Tests analytics

Total tests: 72
Passed tests: 34
Skipped tests: 38
Affected tests: 0

Click here to see the affected service packages
  • apigee

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1029 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1029 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 201 insertions(+))

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeSecurityFeedback_apigeeSecurityFeedbackBasicTestExample

Tests analytics

Total tests: 72
Passed tests: 34
Skipped tests: 38
Affected tests: 0

Click here to see the affected service packages
  • apigee

🟢 All tests passed!

View the build log

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Apigee Security Feedback

2 participants