phase 1 towards decoupling from filesystem ops: Retire resource.CustomTemplate in favor of customTemplate $.
#15889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling a templating method on resources means that the resource object currently means that Resources need to be aware of template locations, filesystem considerations, and in the future `fs.FS` objects.
On the other hand if we move this to the `google` package, those "global" template functions will have a way to pass through `fs.FS` objects.
Before removing the `CustomTemplate` method from Resource and Type, I've also double-checked that our private overrides do not use these.
Note that I'm forced to change Resource.HasLabelsField and remove the pointer: without this I get a `F1205 17:17:34.717325 328294 template_data.go:335] error executing resource.go.tmpl for filepath ${override}/services/compute/resource_compute_address.go template: resource.go.tmpl:442:8: executing "resource.go.tmpl" at <customTemplate $ $.CustomCode.PostCreate false>: error calling customTemplate: template: labels.tmpl:1:8: executing "labels.tmpl" at <$.HasLabelsField>: can't evaluate field HasLabelsField in type api.Resource` error.
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
nicdumz
force-pushed
the
customtemplate
branch
from
9bbd9ed to
a08282e
Compare
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling a templating method on resources means that the resource object currently means that Resources need to be aware of template locations, filesystem considerations, and in the future
fs.FSobjects.On the other hand if we move this to the
googlepackage, those "global" template functions will have a way to pass throughfs.FSobjects.Before removing the
CustomTemplatemethod from Resource and Type, I've also double-checked that our private overrides do not use these.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.