Fixing issue #35 float numbers #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynngodau
reviewed
May 27, 2021
|
|
||
| Dot(int x, float y, int targetX, float targetY, float data, int linenumber) { | ||
| Dot(double x, float y, double targetX, float targetY, float data, int linenumber) { | ||
| this.x = x; |
There was a problem hiding this comment.
Hi, did you try out your changes? I was about to add them to my fork of the library, as unfortunately this repository seems unmaintained, but your commit doesn't compile for me. For example, this.x is an int while the local x is a double, causing the assignment to fail. Other type-casting errors are also showing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #35 Float number
Float numbers can be used as x-coordinates similar to how they could be used as y-coordinates