Add progress bar to concurrent downloads #21183
Open
+15
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?I was looking over #20963 and enjoy the file size ratios (thanks!). I sometimes run on slow connections and would like some progress bars so I can look at quick glance on how the downloads are going. The prior PR's had no unit tests, and I tested this locally. Here is a video:
progress.mp4
I made sure the bar is 20% (1/5th) of the tty and that it is at least 4 characters long.
I used some unicode box drawing glyphs. I suppose we could use
=and-if we want full ASCII support, but the checkmark is already not ASCII, so we should be ok. I am open to feedback on the formatting, sizing, and appearance.