formula_auditor: skip non-core compatibility bumps check #21184
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?The audit added in #20936 doesn't always make sense for formulae in 3rd-party taps, which may need to be revision bumped in order to rebuild bottles after a core formula changes. When minor or major upgrades are made in homebrew-core, we typically recursively remove bottles of dependents in our 3rd-party tap; for example see the tracking issue osrf/homebrew-simulation#3270 and dependent bottle removal PR osrf/homebrew-simulation#3271 opened in response to the libwebsockets update to 4.5.0 in Homebrew/homebrew-core#256449. After quickly removing the broken bottles, we open a separate pull request with revision bumps in order to rebuild bottles, such as osrf/homebrew-simulation#3272, which currently fails the compatibility bumps check.
I read the feature request for
compatibility_versionin #19202, but I'm not sure why it should be added to a pull request like osrf/homebrew-simulation#3272. I opened this PR to disable the check for non-core formulae, which would resolve my issue, but I am open to other suggestions.