dnclient 0.9.0 (new cask)

[jasikpark]

This PR adds DNClient Desktop.app, from https://www.defined.net/downloads

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

[khipp]

Suggested change

	livecheck do
	url "https://api.defined.net/v1/downloads"
	regex(/^v?(\d+(?:\.\d+)+)$/i)
	strategy :json do |json, regex|
	json.dig("data", "dnclient")&.filter_map do |version, downloads|
	next if version == "latest"
	next unless downloads.key?("macos-universal-desktop")
	next unless version.match?(regex)
	version[regex, 1]
	end
	end
	end
	livecheck do
	url "https://api.defined.net/v1/downloads"
	strategy :json do |json|
	json.dig("data", "versionInfo", "latest", "dnclient")
	end
	end

We might be able to simplify the livecheck by querying the versionInfo rather than the download URLs.

[jasikpark]

The only issue is that the download url changes both due to the version change, and due to the git sha as a folder prefix

[khipp]

Thanks, I skipped over that part. We will have to capture the Git SHA as well since it changes with each version.

[jasikpark]

Ok, I think I've got it.