WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 17, 2025

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

This pull request contains two changes to address pre-commit failures and tools warnings:

Files modified/added:

  • regenerate_presentation.sh: Update the script so TMP_PDF is assigned and actually used. When LibreOffice (soffice) is available the script converts the generated PPTX to PDF, finds the generated PDF in the OUT_DIR and moves it to the expected OUT_PDF. Preserve existing fallback to pandoc->pdf when LaTeX is available.
  • .markdownlint.json: New file setting MD013 (line_length) to 120 to reduce noise from many long lines in repository Markdown files.

Notes:

  • Changes are committed on the branch fix/pre-commit.
  • This PR does NOT update workflows or address GitHub Actions pinning policy (actions/checkout and attest-build-provenance). Those require forking or vendorizing external actions and will be handled separately.

Please create the pull request from branch fix/pre-commit into main with title: "chore: fix pre-commit issues (shellcheck & markdownlint)" and include the following description in the PR body:

"Summary

  • Fix ShellCheck SC2034 in regenerate_presentation.sh by using TMP_PDF (detect and move LibreOffice-generated PDF).
  • Add .markdownlint.json to relax MD013 to 120 columns.
  • Pre-commit fixed trailing whitespace and EOF for multiple files; include those fixes in this PR.

Notes

  • This PR does not change workflow pinning for external Actions; repository policy may require forking or vendorizing external Actions."

This pull request was created as a result of the following prompt from Copilot chat.

This pull request contains two changes to address pre-commit failures and tools warnings:

Files modified/added:

  • regenerate_presentation.sh: Update the script so TMP_PDF is assigned and actually used. When LibreOffice (soffice) is available the script converts the generated PPTX to PDF, finds the generated PDF in the OUT_DIR and moves it to the expected OUT_PDF. Preserve existing fallback to pandoc->pdf when LaTeX is available.
  • .markdownlint.json: New file setting MD013 (line_length) to 120 to reduce noise from many long lines in repository Markdown files.

Notes:

  • Changes are committed on the branch fix/pre-commit.
  • This PR does NOT update workflows or address GitHub Actions pinning policy (actions/checkout and attest-build-provenance). Those require forking or vendorizing external actions and will be handled separately.

Please create the pull request from branch fix/pre-commit into main with title: "chore: fix pre-commit issues (shellcheck & markdownlint)" and include the following description in the PR body:

"Summary

  • Fix ShellCheck SC2034 in regenerate_presentation.sh by using TMP_PDF (detect and move LibreOffice-generated PDF).
  • Add .markdownlint.json to relax MD013 to 120 columns.
  • Pre-commit fixed trailing whitespace and EOF for multiple files; include those fixes in this PR.

Notes

  • This PR does not change workflow pinning for external Actions; repository policy may require forking or vendorizing external Actions."

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants