Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5177, Fixes #4581
Changes made in this Pull Request:
mypyerror inlib/util.pymypy(for the currently enabled files) seems to work with current versionThe root cause of this issue seems to be the rdkit pinning. We use
full-deps: trueat other places in our tests and they all take a few seconds, where as the one formypy, which has the rdkit pinned takes over 10 mins, leading to the timeout. Here is a run with the pinned version that times out and an unpinned run that takes only a few seconds (that is the only diff between these two runs). From earlier testing, it seems likemypydoesn't requirefull-depsto be true, but didn't change it for now as the install issue is now resolved.I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5185.org.readthedocs.build/en/5185/