fix: automatic memory injection for Google GenAI provider (#215) #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#215) This commit fixes two critical issues that prevented memory injection from working with the Google GenAI SDK: 1. _extract_user_query now handles Google GenAI's 'contents' parameter: - Supports string contents (simple query) - Supports list of strings - Supports structured contents format with parts/role 2. inject_recalled_facts now properly injects context for Google GenAI: - If config.system_instruction is available, appends context there - Otherwise, prepends context to the first user message's content - If first message is not a user role, inserts a new context message - Properly normalizes contents format (string/list/structured) - Ensures kwargs['contents'] is properly updated Also fixed a minor bug where kwargs['messages'] wasn't being assigned back in the else branch for non-Anthropic/Bedrock providers. Includes comprehensive tests for all Google GenAI scenarios: - String contents - List of strings - Structured contents with parts/role - system_instruction config - Edge case: first message not user role
Collaborator
|
@KarthikeyaKollu |
harshalmore31
added a commit
to harshalmore31/memori
that referenced
this pull request
Dec 12, 2025
fix: automatic memory injection for Google GenAI provider (MemoriLabs#215) (MemoriLabs#221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #215 This commit fixes two critical issues that prevented memory injection from working with the Google GenAI SDK:
_extract_user_query now handles Google GenAI's 'contents' parameter:
inject_recalled_facts now properly injects context for Google GenAI:
Also fixed a minor bug where kwargs['messages'] wasn't being assigned back in the else branch for non-Anthropic/Bedrock providers.
Includes comprehensive tests for all Google GenAI scenarios: