WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@jkachmar
Copy link
Contributor

@jkachmar jkachmar commented Dec 5, 2025

description

this won't be necessary whenever we update our nixpkgs pin, but for now it's not too much extra work to vendor a derivation that pulls in the precompiled CLI binary.

since this isn't something that's /strictly/ necessary for build/test, it's going in a separate 'development' overlay so people don't implicitly pull it in if they just want the native bridge library & test server.

@jkachmar jkachmar force-pushed the jkachmar/bump-temporal-cli branch from 911f0fb to 0ba5045 Compare December 5, 2025 19:30
@jkachmar jkachmar force-pushed the jkachmar/bump-temporal-cli branch 2 times, most recently from 99ece34 to 2e00863 Compare December 5, 2025 21:09
this won't be necessary whenever we update our nixpkgs pin, but for now
it's not too much extra work to vendor a derivation that pulls in the
precompiled CLI binary.

since this isn't something that's /strictly/ necessary for build/test,
it's going in a separate 'development' overlay so people don't
implicitly pull it in if they just want the native bridge library &
test server.
@jkachmar jkachmar force-pushed the jkachmar/bump-temporal-cli branch from 2e00863 to 1302b5b Compare December 5, 2025 21:31
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

📊 Code Coverage Report

Current PR Coverage

Overall Coverage: 🟠 57.9%

  • 10147 / 17539 expressions covered

Overall Summary

Category Coverage
Top-level definitions 790/2607 🔴 30.3%
Alternatives 27/57 🟠 47.4%
Expressions 9082/14450 🟡 62.9%
Local definitions 228/368 🟡 62.0%
Other 20/57 🔴 35.1%

Coverage by Module

Module Coverage Top-level Alternatives Expressions Local
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.TH.Internal 🔴 0.0% 0/15 🔴 0.0% 0/2 🔴 0.0% 0/135 🔴 0.0% 0/2 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.TH 🔴 8.2% 1/21 🔴 4.8% 0/16 🔴 0.0% 41/460 🔴 8.9% 3/36 🔴 8.3%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.SearchAttributes 🔴 15.6% 12/101 🔴 11.9% N/A 19/92 🔴 20.7% 0/6 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Common 🔴 15.9% 49/637 🔴 7.7% 1/1 🟢 100.0% 78/170 🟠 45.9% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Data.EvalRecord 🔴 21.0% 12/71 🔴 16.9% N/A 68/308 🔴 22.1% 2/12 🔴 16.7%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Worker.Types 🔴 25.0% 9/35 🔴 25.7% N/A 9/37 🔴 24.3% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Client.TestService 🔴 32.0% 7/16 🟠 43.8% 1/1 🟢 100.0% 43/139 🔴 30.9% 3/12 🔴 25.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity.Definition 🔴 35.1% 22/57 🔴 38.6% N/A 24/74 🔴 32.4% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Payload 🔴 35.4% 38/125 🔴 30.4% 0/5 🔴 0.0% 162/438 🔴 37.0% 2/4 🟠 50.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Update 🟠 40.0% 1/3 🔴 33.3% N/A 1/2 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Signal 🟠 40.0% 1/3 🔴 33.3% N/A 1/2 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Query 🟠 40.0% 1/3 🔴 33.3% N/A 1/2 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.TH.Classes 🟠 40.0% 10/27 🔴 37.0% N/A 28/68 🟠 41.2% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Definition 🟠 41.7% 8/20 🟠 40.0% N/A 32/76 🟠 42.1% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity.Types 🟠 45.0% 9/21 🟠 42.9% N/A 9/19 🟠 47.4% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Types 🟠 45.3% 49/179 🔴 27.4% N/A 81/108 🟡 75.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Bundle 🟠 45.5% 9/25 🔴 36.0% N/A 91/199 🟠 45.7% 10/18 🟠 55.6%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Unsafe.Handle 🟠 49.4% 5/8 🟡 62.5% N/A 72/148 🟠 48.6% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Coroutine 🟠 49.7% 12/23 🟠 52.2% N/A 65/132 🟠 49.2% 3/6 🟠 50.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.WorkflowInstance 🟠 50.0% 1/1 🟢 100.0% N/A 1/3 🔴 33.3% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.EphemeralServer 🟠 50.0% 4/13 🔴 30.8% N/A 64/122 🟠 52.5% 0/1 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Common.Async 🟠 50.0% 1/2 🟠 50.0% N/A 10/20 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Exception 🟠 52.0% 84/291 🔴 28.9% 2/3 🟡 66.7% 301/455 🟡 66.2% 5/5 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Testing.MockActivityEnvironment 🟠 52.9% 7/14 🟠 50.0% N/A 43/85 🟠 50.6% 5/5 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Operator 🟠 55.6% 3/12 🔴 25.0% 1/1 🟢 100.0% 53/92 🟠 57.6% 2/2 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow 🟠 58.2% 38/104 🔴 36.5% 2/3 🟡 66.7% 1237/2085 🟠 59.3% 31/56 🟠 55.4%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Worker 🟠 59.1% 42/111 🔴 37.8% 1/1 🟢 100.0% 601/997 🟡 60.3% 34/39 🟢 87.2%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Internal.Monad 🟡 60.7% 135/254 🟠 53.1% 1/3 🔴 33.3% 617/980 🟡 63.0% 2/3 🟡 66.7%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Client.Types 🟡 65.5% 49/104 🟠 47.1% N/A 124/159 🟡 78.0% 0/1 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Interceptor 🟡 67.6% 15/33 🟠 45.5% N/A 56/72 🟡 77.8% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity 🟡 69.8% 3/6 🟠 50.0% N/A 84/120 🟡 70.0% 3/3 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Duration 🟡 70.9% 27/64 🟠 42.2% 6/7 🟢 85.7% 213/274 🟡 77.7% 6/9 🟡 66.7%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.WorkflowInstance 🟡 71.2% 18/22 🟢 81.8% 2/2 🟢 100.0% 1258/1767 🟡 71.2% 29/42 🟡 69.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Client 🟡 73.6% 34/78 🟠 43.6% 5/7 🟡 71.4% 1455/1945 🟡 74.8% 26/33 🟡 78.8%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Contrib.OpenTelemetry 🟡 73.8% 3/7 🟠 42.9% N/A 518/700 🟡 74.0% 12/15 🟢 80.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Internal.Instance 🟡 74.2% 6/8 🟡 75.0% N/A 132/178 🟡 74.2% 6/8 🟡 75.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity.Worker 🟡 75.2% 23/36 🟡 63.9% N/A 420/555 🟡 75.7% 10/11 🟢 90.9%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Common.Logging 🟢 81.0% 11/14 🟡 78.6% 1/1 🟢 100.0% 87/106 🟢 82.1% 3/4 🟡 75.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Testing.Assertions 🟢 81.1% 6/11 🟠 54.5% N/A 24/26 🟢 92.3% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Worker 🟢 84.7% 15/22 🟡 68.2% 1/1 🟢 100.0% 630/740 🟢 85.1% 22/26 🟢 84.6%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Eval 🟢 91.1% 4/4 🟢 100.0% 3/3 🟢 100.0% 300/329 🟢 91.2% 9/9 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.SearchAttributes.Internal 🟢 93.3% 5/5 🟢 100.0% N/A 23/25 🟢 92.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Unsafe 🟢 100.0% 1/1 🟢 100.0% N/A 6/6 🟢 100.0% N/A

🟢 ≥80% 🟡 ≥60% 🟠 ≥40% 🔴 <40%


📈 Coverage Comparison vs. Main

➡️ Coverage unchanged at 57.9%

Main Branch Coverage (for comparison)

Overall Coverage: 🟠 57.9%

  • 10147 / 17539 expressions covered

Overall Summary

Category Coverage
Top-level definitions 790/2607 🔴 30.3%
Alternatives 27/57 🟠 47.4%
Expressions 9082/14450 🟡 62.9%
Local definitions 228/368 🟡 62.0%
Other 20/57 🔴 35.1%

Coverage by Module

Module Coverage Top-level Alternatives Expressions Local
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.TH.Internal 🔴 0.0% 0/15 🔴 0.0% 0/2 🔴 0.0% 0/135 🔴 0.0% 0/2 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.TH 🔴 8.2% 1/21 🔴 4.8% 0/16 🔴 0.0% 41/460 🔴 8.9% 3/36 🔴 8.3%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.SearchAttributes 🔴 15.6% 12/101 🔴 11.9% N/A 19/92 🔴 20.7% 0/6 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Common 🔴 15.9% 49/637 🔴 7.7% 1/1 🟢 100.0% 78/170 🟠 45.9% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Data.EvalRecord 🔴 21.0% 12/71 🔴 16.9% N/A 68/308 🔴 22.1% 2/12 🔴 16.7%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Worker.Types 🔴 25.0% 9/35 🔴 25.7% N/A 9/37 🔴 24.3% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Client.TestService 🔴 32.0% 7/16 🟠 43.8% 1/1 🟢 100.0% 43/139 🔴 30.9% 3/12 🔴 25.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity.Definition 🔴 35.1% 22/57 🔴 38.6% N/A 24/74 🔴 32.4% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Payload 🔴 35.4% 38/125 🔴 30.4% 0/5 🔴 0.0% 162/438 🔴 37.0% 2/4 🟠 50.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Update 🟠 40.0% 1/3 🔴 33.3% N/A 1/2 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Signal 🟠 40.0% 1/3 🔴 33.3% N/A 1/2 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Query 🟠 40.0% 1/3 🔴 33.3% N/A 1/2 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.TH.Classes 🟠 40.0% 10/27 🔴 37.0% N/A 28/68 🟠 41.2% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Definition 🟠 41.7% 8/20 🟠 40.0% N/A 32/76 🟠 42.1% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity.Types 🟠 45.0% 9/21 🟠 42.9% N/A 9/19 🟠 47.4% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Types 🟠 45.3% 49/179 🔴 27.4% N/A 81/108 🟡 75.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Bundle 🟠 45.5% 9/25 🔴 36.0% N/A 91/199 🟠 45.7% 10/18 🟠 55.6%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Unsafe.Handle 🟠 49.4% 5/8 🟡 62.5% N/A 72/148 🟠 48.6% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Coroutine 🟠 49.7% 12/23 🟠 52.2% N/A 65/132 🟠 49.2% 3/6 🟠 50.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.WorkflowInstance 🟠 50.0% 1/1 🟢 100.0% N/A 1/3 🔴 33.3% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.EphemeralServer 🟠 50.0% 4/13 🔴 30.8% N/A 64/122 🟠 52.5% 0/1 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Common.Async 🟠 50.0% 1/2 🟠 50.0% N/A 10/20 🟠 50.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Exception 🟠 52.0% 84/291 🔴 28.9% 2/3 🟡 66.7% 301/455 🟡 66.2% 5/5 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Testing.MockActivityEnvironment 🟠 52.9% 7/14 🟠 50.0% N/A 43/85 🟠 50.6% 5/5 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Operator 🟠 55.6% 3/12 🔴 25.0% 1/1 🟢 100.0% 53/92 🟠 57.6% 2/2 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow 🟠 58.2% 38/104 🔴 36.5% 2/3 🟡 66.7% 1237/2085 🟠 59.3% 31/56 🟠 55.4%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Worker 🟠 59.1% 42/111 🔴 37.8% 1/1 🟢 100.0% 601/997 🟡 60.3% 34/39 🟢 87.2%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Internal.Monad 🟡 60.7% 135/254 🟠 53.1% 1/3 🔴 33.3% 617/980 🟡 63.0% 2/3 🟡 66.7%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Client.Types 🟡 65.5% 49/104 🟠 47.1% N/A 124/159 🟡 78.0% 0/1 🔴 0.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Interceptor 🟡 67.6% 15/33 🟠 45.5% N/A 56/72 🟡 77.8% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity 🟡 69.8% 3/6 🟠 50.0% N/A 84/120 🟡 70.0% 3/3 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Duration 🟡 70.9% 27/64 🟠 42.2% 6/7 🟢 85.7% 213/274 🟡 77.7% 6/9 🟡 66.7%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.WorkflowInstance 🟡 71.2% 18/22 🟢 81.8% 2/2 🟢 100.0% 1258/1767 🟡 71.2% 29/42 🟡 69.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Client 🟡 73.6% 34/78 🟠 43.6% 5/7 🟡 71.4% 1455/1945 🟡 74.8% 26/33 🟡 78.8%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Contrib.OpenTelemetry 🟡 73.8% 3/7 🟠 42.9% N/A 518/700 🟡 74.0% 12/15 🟢 80.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Internal.Instance 🟡 74.2% 6/8 🟡 75.0% N/A 132/178 🟡 74.2% 6/8 🟡 75.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Activity.Worker 🟡 75.2% 23/36 🟡 63.9% N/A 420/555 🟡 75.7% 10/11 🟢 90.9%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Common.Logging 🟢 81.0% 11/14 🟡 78.6% 1/1 🟢 100.0% 87/106 🟢 82.1% 3/4 🟡 75.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Testing.Assertions 🟢 81.1% 6/11 🟠 54.5% N/A 24/26 🟢 92.3% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Worker 🟢 84.7% 15/22 🟡 68.2% 1/1 🟢 100.0% 630/740 🟢 85.1% 22/26 🟢 84.6%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Eval 🟢 91.1% 4/4 🟢 100.0% 3/3 🟢 100.0% 300/329 🟢 91.2% 9/9 🟢 100.0%
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.SearchAttributes.Internal 🟢 93.3% 5/5 🟢 100.0% N/A 23/25 🟢 92.0% N/A
temporal-sdk-2025.10.1.0-2GLkjAgtube2wLzBMhfM5i/Temporal.Workflow.Unsafe 🟢 100.0% 1/1 🟢 100.0% N/A 6/6 🟢 100.0% N/A

🟢 ≥80% 🟡 ≥60% 🟠 ≥40% 🔴 <40%

@jkachmar jkachmar merged commit 45b1665 into main Dec 5, 2025
21 checks passed
@jkachmar jkachmar deleted the jkachmar/bump-temporal-cli branch December 5, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants