WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Fix gas limit in eth_sendTransaction calls #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dahu33 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix gas limit in eth_sendTransaction calls #257

dahu33 wants to merge 1 commit into from

Conversation

@dahu33
Copy link

@dahu33 dahu33 commented Sep 14, 2023

This PR fixes two issues:

  1. The specs of the eth_sendTransaction method requires to specify the gas limit as the gas parameter and not the gasLimit parameter (see the specs here: https://ethereum.github.io/execution-apis/api-documentation/)
  2. Increase the gas limit to the minimum required for Ethereum (21,000)

@adonesky1 adonesky1 mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dahu33