WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@lanodan
Copy link
Contributor

@lanodan lanodan commented Aug 3, 2025

  • configure.ac: use pkg-config for OpenSSL

Incidentally support for it got added in OpenSSL 0.9.7 which is already required.

https://github.com/openssl/openssl/releases/tag/OpenSSL_0_9_7

Support for pkg-config.

  • acx_nlnetlabs.m4: cleanup now unused functions for OpenSSL

@lanodan lanodan force-pushed the openssl-pkgconfig branch 2 times, most recently from a30abb1 to fa693ee Compare August 3, 2025 14:09
@lanodan lanodan force-pushed the openssl-pkgconfig branch from fa693ee to bdb94c9 Compare August 3, 2025 14:41
@lanodan lanodan force-pushed the openssl-pkgconfig branch from bdb94c9 to 96754f8 Compare August 3, 2025 15:07
@wcawijngaards
Copy link
Member

I do not really want a reliance on pkg-config. That seems to be what is there on this platform, but is not nice as a non-optional dependency. As an optional depedency, where it could be used if present, that would be acceptable. That would not remove the, then not unused, functions about ssl. Also, this is likely to break package install for most; even more so if the pkg-config entry for openssl on the system contains flags that are unexpected, I mean different from what is used to package now.

So it sure removes a bunch of code and simplifies, but the dependency on another build tool is not really that nice. It is nicer to have less dependencies for building from source.

@lanodan
Copy link
Contributor Author

lanodan commented Aug 5, 2025

Given the existing one is defined as CHECK_SSL maybe it could be kept as fallback in case detection via pkg-config fails?

Also, this is likely to break package install for most; even more so if the pkg-config entry for openssl on the system contains flags that are unexpected, I mean different from what is used to package now.

Not really sure how that would happen, specially given how frequently pkg-config is used by most buildsystems out there.
Meanwhile it would be likely to have missing flags with the existing heuristics, and almost silently so given autotools redirects compiler output into config.log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants