WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Dec 8, 2025

  • add "-std=gnu17" to env.NIX_CFLAGS_COMPILE

Upstream issue:
https://www.github.com/cpan-authors/YAML-Syck/issues/61

There is a PR with proposed patch:
https://www.github.com/cpan-authors/YAML-Syck/pull/64
alpine uses it:
https://gitlab.alpinelinux.org/alpine/aports/-/commit/7dab2a77194967a52df82378c817f686d32056a7

Other distros settled on "-std=gnu17":
https://gitlab.archlinux.org/archlinux/packaging/packages/perl-yaml-syck/-/commit/9355df2bddfdda80963a629d750d0dbc1c1d8aa8
https://src.fedoraproject.org/rpms/perl-YAML-Syck/c/5fb93f7185d99ad738c985a944191ceb89368a82

Fixes build failure with gcc15:

emitter.c:161:9: error: too many arguments to function 'st_foreach';
expected 0, have 3
  161 |         st_foreach( e->anchors, syck_st_free_anchors, 0 );
      |         ^~~~~~~~~~  ~~~~~~~~~~
In file included from syck.h:36,
                 from emitter.c:15:
syck_st.h:35:6: note: declared here
   35 | void st_foreach(), st_add_direct(), st_free_table(), st_cleanup_safe();
      |      ^~~~~~~~~~
emitter.c:162:9: error: too many arguments to function 'st_free_table';
expected 0, have 1
  162 |         st_free_table( e->anchors );
      |         ^~~~~~~~~~~~~  ~~~~~~~~~~
syck_st.h:35:37: note: declared here
   35 | void st_foreach(), st_add_direct(), st_free_table(), st_cleanup_safe();
      |                                     ^~~~~~~~~~~~~
emitter.c:400:9: error: too many arguments to function 'st_lookup';
expected 0, have 3
  400 |         st_lookup( e->markers, n, (st_data_t *)&oid ) &&
      |         ^~~~~~~~~  ~~~~~~~~~~
syck_st.h:34:18: note: declared here
   34 | int st_insert(), st_lookup();
      |                  ^~~~~~~~~

Tested build with:

nix-build --expr 'with import ./. {}; (perlPackages.overrideScope (final: prev: { stdenv = gcc15Stdenv; })).YAMLSyck'

Part of fixes for gcc15 update:
#440456

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Dec 8, 2025
@ghpzin
Copy link
Contributor Author

ghpzin commented Dec 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 468898
Commit: 192988ed10b5d300cf77e8bfa6cb07b9db9a135c


x86_64-linux

✅ 25 packages built:
  • perl538Packages.BeanstalkClient
  • perl538Packages.BeanstalkClient.devdoc
  • perl538Packages.CPAN
  • perl538Packages.CPAN.devdoc
  • perl538Packages.GraphicsColor
  • perl538Packages.GraphicsColor.devdoc
  • perl538Packages.MooseXStorage
  • perl538Packages.MooseXStorage.devdoc
  • perl538Packages.MooseXStorageFormatJSONpm
  • perl538Packages.MooseXStorageFormatJSONpm.devdoc
  • perl538Packages.YAMLSyck
  • perl538Packages.YAMLSyck.devdoc
  • perlPackages.BeanstalkClient (perl540Packages.BeanstalkClient)
  • perlPackages.BeanstalkClient.devdoc (perl540Packages.BeanstalkClient.devdoc)
  • perlPackages.CPAN (perl540Packages.CPAN)
  • perlPackages.CPAN.devdoc (perl540Packages.CPAN.devdoc)
  • perlPackages.GraphicsColor (perl540Packages.GraphicsColor)
  • perlPackages.GraphicsColor.devdoc (perl540Packages.GraphicsColor.devdoc)
  • perlPackages.MooseXStorage (perl540Packages.MooseXStorage)
  • perlPackages.MooseXStorage.devdoc (perl540Packages.MooseXStorage.devdoc)
  • perlPackages.MooseXStorageFormatJSONpm (perl540Packages.MooseXStorageFormatJSONpm)
  • perlPackages.MooseXStorageFormatJSONpm.devdoc (perl540Packages.MooseXStorageFormatJSONpm.devdoc)
  • perlPackages.YAMLSyck (perl540Packages.YAMLSyck)
  • perlPackages.YAMLSyck.devdoc (perl540Packages.YAMLSyck.devdoc)
  • shelldap

@ghpzin ghpzin force-pushed the pr-perlPackages.YAMLSyck-gcc15 branch from 192988e to af778a4 Compare December 8, 2025 07:47
github-actions[bot]

This comment was marked as resolved.

@ghpzin ghpzin changed the base branch from master to staging December 8, 2025 07:48
@nixpkgs-ci nixpkgs-ci bot closed this Dec 8, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 8, 2025
@github-actions github-actions bot dismissed their stale review December 8, 2025 07:49

All good now, thank you!

@ghpzin ghpzin force-pushed the pr-perlPackages.YAMLSyck-gcc15 branch from af778a4 to a060f75 Compare December 8, 2025 07:49
@ghpzin ghpzin marked this pull request as ready for review December 8, 2025 08:05
- add "-std=gnu17" to `env.NIX_CFLAGS_COMPILE`

Upstream issue:
https://www.github.com/cpan-authors/YAML-Syck/issues/61

There is a PR with proposed patch:
https://www.github.com/cpan-authors/YAML-Syck/pull/64
alpine uses it:
https://gitlab.alpinelinux.org/alpine/aports/-/commit/7dab2a77194967a52df82378c817f686d32056a7

Other distros settled on "-std=gnu17":
https://gitlab.archlinux.org/archlinux/packaging/packages/perl-yaml-syck/-/commit/9355df2bddfdda80963a629d750d0dbc1c1d8aa8
https://src.fedoraproject.org/rpms/perl-YAML-Syck/c/5fb93f7185d99ad738c985a944191ceb89368a82

Fixes build failure with gcc15:
```
emitter.c:161:9: error: too many arguments to function 'st_foreach';
expected 0, have 3
  161 |         st_foreach( e->anchors, syck_st_free_anchors, 0 );
      |         ^~~~~~~~~~  ~~~~~~~~~~
In file included from syck.h:36,
                 from emitter.c:15:
syck_st.h:35:6: note: declared here
   35 | void st_foreach(), st_add_direct(), st_free_table(), st_cleanup_safe();
      |      ^~~~~~~~~~
emitter.c:162:9: error: too many arguments to function 'st_free_table';
expected 0, have 1
  162 |         st_free_table( e->anchors );
      |         ^~~~~~~~~~~~~  ~~~~~~~~~~
syck_st.h:35:37: note: declared here
   35 | void st_foreach(), st_add_direct(), st_free_table(), st_cleanup_safe();
      |                                     ^~~~~~~~~~~~~
emitter.c:400:9: error: too many arguments to function 'st_lookup';
expected 0, have 3
  400 |         st_lookup( e->markers, n, (st_data_t *)&oid ) &&
      |         ^~~~~~~~~  ~~~~~~~~~~
syck_st.h:34:18: note: declared here
   34 | int st_insert(), st_lookup();
      |                  ^~~~~~~~~
```
@ghpzin ghpzin marked this pull request as draft December 8, 2025 13:45
@ghpzin ghpzin force-pushed the pr-perlPackages.YAMLSyck-gcc15 branch from a060f75 to 8b97a64 Compare December 8, 2025 13:45
@ghpzin ghpzin marked this pull request as ready for review December 8, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant