-
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
perlPackages.YAMLSyck: fix build with gcc15 #468898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghpzin
wants to merge
1
commit into
NixOS:staging
Choose a base branch
from
ghpzin:pr-perlPackages.YAMLSyck-gcc15
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
192988e to
af778a4
Compare
af778a4 to
a060f75
Compare
- add "-std=gnu17" to `env.NIX_CFLAGS_COMPILE` Upstream issue: https://www.github.com/cpan-authors/YAML-Syck/issues/61 There is a PR with proposed patch: https://www.github.com/cpan-authors/YAML-Syck/pull/64 alpine uses it: https://gitlab.alpinelinux.org/alpine/aports/-/commit/7dab2a77194967a52df82378c817f686d32056a7 Other distros settled on "-std=gnu17": https://gitlab.archlinux.org/archlinux/packaging/packages/perl-yaml-syck/-/commit/9355df2bddfdda80963a629d750d0dbc1c1d8aa8 https://src.fedoraproject.org/rpms/perl-YAML-Syck/c/5fb93f7185d99ad738c985a944191ceb89368a82 Fixes build failure with gcc15: ``` emitter.c:161:9: error: too many arguments to function 'st_foreach'; expected 0, have 3 161 | st_foreach( e->anchors, syck_st_free_anchors, 0 ); | ^~~~~~~~~~ ~~~~~~~~~~ In file included from syck.h:36, from emitter.c:15: syck_st.h:35:6: note: declared here 35 | void st_foreach(), st_add_direct(), st_free_table(), st_cleanup_safe(); | ^~~~~~~~~~ emitter.c:162:9: error: too many arguments to function 'st_free_table'; expected 0, have 1 162 | st_free_table( e->anchors ); | ^~~~~~~~~~~~~ ~~~~~~~~~~ syck_st.h:35:37: note: declared here 35 | void st_foreach(), st_add_direct(), st_free_table(), st_cleanup_safe(); | ^~~~~~~~~~~~~ emitter.c:400:9: error: too many arguments to function 'st_lookup'; expected 0, have 3 400 | st_lookup( e->markers, n, (st_data_t *)&oid ) && | ^~~~~~~~~ ~~~~~~~~~~ syck_st.h:34:18: note: declared here 34 | int st_insert(), st_lookup(); | ^~~~~~~~~ ```
a060f75 to
8b97a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 11-100
This PR causes between 11 and 100 packages to rebuild on Darwin.
10.rebuild-linux: 11-100
This PR causes between 11 and 100 packages to rebuild on Linux.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.NIX_CFLAGS_COMPILEUpstream issue:
https://www.github.com/cpan-authors/YAML-Syck/issues/61
There is a PR with proposed patch:
https://www.github.com/cpan-authors/YAML-Syck/pull/64
alpine uses it:
https://gitlab.alpinelinux.org/alpine/aports/-/commit/7dab2a77194967a52df82378c817f686d32056a7
Other distros settled on "-std=gnu17":
https://gitlab.archlinux.org/archlinux/packaging/packages/perl-yaml-syck/-/commit/9355df2bddfdda80963a629d750d0dbc1c1d8aa8
https://src.fedoraproject.org/rpms/perl-YAML-Syck/c/5fb93f7185d99ad738c985a944191ceb89368a82
Fixes build failure with gcc15:
Tested build with:
nix-build --expr 'with import ./. {}; (perlPackages.overrideScope (final: prev: { stdenv = gcc15Stdenv; })).YAMLSyck'Part of fixes for gcc15 update:
#440456
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.