WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@LabordePierre
Copy link
Member

No description provided.

@LabordePierre LabordePierre self-assigned this Jul 4, 2025
@LabordePierre LabordePierre added the ci/cd Continuous integration / continuous delivery stuff label Jul 4, 2025
@LabordePierre
Copy link
Member Author

@SullyMLT the baseline is not loading here, have you fixed that?

@LabordePierre
Copy link
Member Author

Pended by #226

@labordep labordep added bug Something isn't working technical work Some technical stuff: technical debt, refactoring, cleanup, performance, writing unit tests, etc. and removed pending Waiting for something labels Jul 10, 2025
@labordep
Copy link
Member

Hi @SullyMLT is it possible for you to fix tests of this pull-request?

@LabordePierre
Copy link
Member Author

LabordePierre commented Jul 29, 2025

@LabordePierre LabordePierre added the pending Waiting for something label Jul 29, 2025
@labordep labordep removed the pending Waiting for something label Jul 29, 2025
@labordep
Copy link
Member

labordep commented Jul 29, 2025

Tests pipelines:

  • Pharo 11
  • Pharo 12
  • Pharo 13

@labordep
Copy link
Member

labordep commented Jul 29, 2025

@SullyMLT could you check?
https://github.com/OpenSmock/Pyramid/actions/runs/16602926994/job/46967238995?pr=225
###########

Summary

###########

PyramidPointInputPresenterTest
✗ #testTrigger (10ms)

PyramidColorInputSingleLinePresenterTest
✗ #testTrigger (3ms)

PyramidTextInputPresenterTest
✗ #testTrigger (8ms)

PyramidNumberArrayInputPresenterTest
✗ #testTrigger (8ms)

PyramidCornerRadiiInputPresenterTest
✗ #testTrigger (3ms)

PyramidColorInputMultiLinesPresenterTest
✗ #testTrigger (12ms)

PyramidHorizontalFrameConstraintsInputPresenterTest
✗ #testTrigger (9ms)

PyramidColorInputSingleLineWithPickupButtonPresenterTest
✗ #testTrigger (8ms)

PyramidVerticalFrameConstraintsInputPresenterTest
✗ #testTrigger (8ms)

PyramidNumberInputPresenterTest
✗ #testTrigger (1ms)

PyramidInsetsInputPresenterTest
✗ #testTrigger (1ms)

@Nyan11
Copy link
Collaborator

Nyan11 commented Jul 30, 2025

Apparently ther are problem with the proposed fix for Pharo 13. But now the Pharo 12 and 11 should work.
@SullyMLT Do you have other ideas to fix Pharo13 CI?

The bug is:
Instance of SpTextInputFieldPresenter did not understand #ensureActionGroup
See: https://github.com/OpenSmock/Pyramid/actions/runs/16627861494/job/47049188471?pr=225

@SullyMLT
Copy link
Collaborator

@Nyan11 I change the ensureInternalActions and put it like it was before natively in pharo 13

@SullyMLT
Copy link
Collaborator

SullyMLT commented Aug 11, 2025

Don't run test in Pharo 13, the class PyramidSaveModelVerifier rewrite the message methodIsValid
Original :

^ self new
	  verifyBlock: [ :model |
		  model savingMethodName isValidSelector ];
	  showBlock: [ :view | view showMethodIsNotValidError ];
	  yourself

to :

^ self new
	  verifyBlock: [ :model |
		  OCScanner isSelector: model savingMethodName ];
	  showBlock: [ :view | view showMethodIsNotValidError ];
	  yourself

The problem is if we run it and commit push the methodIsValid is pushed with the rewrite version on github so we don't run at local before and the Pharo 12 CI used it and don't pass the test

@LabordePierre LabordePierre merged commit b575b9a into main Aug 11, 2025
9 checks passed
@LabordePierre LabordePierre deleted the dev-p13 branch August 11, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/cd Continuous integration / continuous delivery stuff technical work Some technical stuff: technical debt, refactoring, cleanup, performance, writing unit tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants