-
Notifications
You must be signed in to change notification settings - Fork 7
add pharo 13 CI + update readme file #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SullyMLT the baseline is not loading here, have you fixed that? |
|
Pended by #226 |
|
Hi @SullyMLT is it possible for you to fix tests of this pull-request? |
|
Waiting for P13 fix, P12/P11 legacy project update and Bloc-Serialization fix: |
|
Tests pipelines:
|
|
@SullyMLT could you check? Summary########### PyramidPointInputPresenterTest PyramidColorInputSingleLinePresenterTest PyramidTextInputPresenterTest PyramidNumberArrayInputPresenterTest PyramidCornerRadiiInputPresenterTest PyramidColorInputMultiLinesPresenterTest PyramidHorizontalFrameConstraintsInputPresenterTest PyramidColorInputSingleLineWithPickupButtonPresenterTest PyramidVerticalFrameConstraintsInputPresenterTest PyramidNumberInputPresenterTest PyramidInsetsInputPresenterTest |
|
Apparently ther are problem with the proposed fix for Pharo 13. But now the Pharo 12 and 11 should work. The bug is: |
|
@Nyan11 I change the ensureInternalActions and put it like it was before natively in pharo 13 |
|
Don't run test in Pharo 13, the class PyramidSaveModelVerifier rewrite the message methodIsValid to : The problem is if we run it and commit push the methodIsValid is pushed with the rewrite version on github so we don't run at local before and the Pharo 12 CI used it and don't pass the test |
No description provided.