WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fixes: Refactor The Login and Registration Screens (#4818) #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rasesh-here wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

fixes: Refactor The Login and Registration Screens (#4818) #4951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bdcffa5
auth refactor CP-1: reusable components
rasesh-here Dec 4, 2025
d81c92b
auth refactor as per figma
rasesh-here Dec 5, 2025
7a342b5
CR review
rasesh-here Dec 6, 2025
c2fcd35
CR review & improovements
rasesh-here Dec 6, 2025
27bb77f
CR review & fonts refactored
rasesh-here Dec 6, 2025
e46485e
CR review
rasesh-here Dec 6, 2025
241a071
all reviews applied
rasesh-here Dec 7, 2025
034b294
Deleted docs/src/css/custom.css
rasesh-here Dec 7, 2025
5b77773
Deleted index.html
rasesh-here Dec 7, 2025
37e9e59
Merge branch 'develop' into auth-refactor
rasesh-here Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
830 changes: 0 additions & 830 deletions docs/src/css/custom.css
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions index.html
View file
Open in desktop

This file was deleted.

46 changes: 10 additions & 36 deletions public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,16 @@
"loginPage": {
"title": "Talawa Admin",
"fromPalisadoes": "An open source application by Palisadoes Foundation volunteers",
"userLogin": "User Login",
"userLogin": "Login",
"loginSubHead": "Log in to your account",
"adminLogin": "Admin Login",
"atleast_8_char_long": "Atleast 8 Character long",
"atleast_6_char_long": "Atleast 6 Character long",
"firstName_invalid": "First name should contain only lower and upper case letters",
"lastName_invalid": "Last name should contain only lower and upper case letters",
"password_invalid": "Password should contain atleast one lowercase letter, one uppercase letter, one numeric value and one special character",
"email_invalid": "Email should have atleast 8 characters",
"Password_and_Confirm_password_mismatches.": "Password and Confirm password mismatches.",
"Password_and_Confirm_password_mismatches": "Password and Confirm password mismatches.",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use one canonical key for password mismatch.

Remove "Password_and_Confirm_password_mismatches" in favor of "passwordMismatches" across loginPage and userRegister to prevent duplicate keys and missed updates.

-    "Password_and_Confirm_password_mismatches": "Password and Confirm password mismatches.",

As per coding guidelines and prior learnings, standardize i18n keys.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In public/locales/en/translation.json around line 26, the key
"Password_and_Confirm_password_mismatches" should be removed and replaced by
using the canonical key "passwordMismatches"; delete the existing entry, add or
ensure an entry "passwordMismatches": "Password and Confirm password
mismatches." exists, then update all references in loginPage and userRegister to
use "passwordMismatches" (search for the old key and replace it), and run a
quick i18n key check or tests to confirm no remaining references to the old key.

"doNotOwnAnAccount": "Do not own an account?",
"captchaError": "Captcha Error!",
"Please_check_the_captcha": "Please, check the captcha.",
Expand All @@ -41,7 +42,7 @@
"register": "register",
"firstName": "firstName",
"lastName": "lastName",
"email": "email",
"email": "Email Address",
"password": "password",
"confirmPassword": "confirmPassword",
"forgotPassword": "forgotPassword",
Expand All @@ -55,38 +56,6 @@
"user": "user",
"loading": "loading"
},
"userLoginPage": {
"title": "Talawa Admin",
"fromPalisadoes": "An open source application by Palisadoes Foundation volunteers",
"atleast_8_char_long": "Atleast 8 Character long",
"Password_and_Confirm_password_mismatches.": "Password and Confirm password mismatches.",
"doNotOwnAnAccount": "Do not own an account?",
"captchaError": "Captcha Error!",
"Please_check_the_captcha": "Please, check the captcha.",
"Something_went_wrong": "Something went wrong, Please try after sometime.",
"passwordMismatches": "Password and Confirm password mismatches.",
"fillCorrectly": "Fill all the Details Correctly.",
"successfullyRegistered": "Successfully Registered. Please wait until you will be approved.",
"userLogin": "User Login",
"afterRegister": "Successfully registered. Please wait for admin to approve your request.",
"selectOrg": "Select an organization",
"talawa_portal": "talawa_portal",
"login": "login",
"register": "register",
"firstName": "firstName",
"lastName": "lastName",
"email": "email",
"password": "password",
"confirmPassword": "confirmPassword",
"forgotPassword": "forgotPassword",
"enterEmail": "enterEmail",
"enterPassword": "enterPassword",
"talawaApiUnavailable": "talawaApiUnavailable",
"notAuthorised": "notAuthorised",
"notFound": "notFound",
"OR": "OR",
"loading": "loading"
},
"latestEvents": {
"eventCardTitle": "Upcoming Events",
"eventCardSeeAll": "See All",
Expand Down Expand Up @@ -1047,7 +1016,7 @@
},
"userLogin": {
"login": "Login",
"loginIntoYourAccount": "Login into your account",
"loginIntoYourAccount": "Log in to your account",
"invalidDetailsMessage": "Please enter a valid email and password.",
"notAuthorised": "Sorry! you are not Authorised!",
"invalidCredentials": "Entered credentials are incorrect. Please enter valid credentials.",
Expand All @@ -1060,6 +1029,11 @@
"talawaApiUnavailable": "talawaApiUnavailable"
},
"userRegister": {
"firstName_invalid": "First name should contain only lower and upper case letters",
"lastName_invalid": "Last name should contain only lower and upper case letters",
"password_invalid": "Password should contain atleast one lowercase letter, one uppercase letter, one numeric value and one special character",
"email_invalid": "Email should have atleast 8 characters",
"Password_and_Confirm_password_mismatches": "Password and Confirm password mismatches.",
"enterFirstName": "Enter your first name",
"enterLastName": "Enter your last name",
"enterConfirmPassword": "Enter Password to confirm",
Expand Down
43 changes: 9 additions & 34 deletions public/locales/es/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"fromPalisadoes": "Una aplicación de código abierto de los voluntarios de la Fundación palisados",
"talawa_portal": "Portal De Administración Talawa",
"login": "Acceso",
"userLogin": "Inicio de sesión de usuario",
"userLogin": "Acceso",
"loginSubHead": "Inicio de sesión",
"adminLogin": "Inicio de sesión de administrador",
Comment on lines +19 to 21
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

OK: “userLogin” → “Acceso” and added subhead

Consistent with the refactor. Optional: more natural subhead could be “Inicia sesión en tu cuenta”.

🤖 Prompt for AI Agents 
In public/locales/es/translation.json around lines 19 to 21, the "loginSubHead"
value is currently "Inicio de sesión" which is fine but the reviewer suggests a
more natural subhead; update the "loginSubHead" translation to "Inicia sesión en
tu cuenta" (or another preferred natural phrasing) to improve UX consistency
while keeping "userLogin": "Acceso" and "adminLogin": "Inicio de sesión de
administrador" unchanged.

"register": "Registro",
"firstName": "Primer nombre",
Expand All @@ -29,7 +30,7 @@
"lastName_invalid": "El apellido debe contener solo letras minúsculas y mayúsculas.",
"password_invalid": "La contraseña debe contener al menos una letra minúscula, una letra mayúscula, un valor numérico y un carácter especial.",
"email_invalid": "El correo electrónico debe tener al menos 8 caracteres.",
"Password_and_Confirm_password_mismatches.": "Contraseña y Confirmar contraseña no coinciden.",
"Password_and_Confirm_password_mismatches": "Contraseña y Confirmar contraseña no coinciden.",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Consolidate password mismatch key.

Prefer single key "passwordMismatches"; remove "Password_and_Confirm_password_mismatches".

-    "Password_and_Confirm_password_mismatches": "Contraseña y Confirmar contraseña no coinciden.",

Ensure usages updated. Based on learnings, standardize i18n keys.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In public/locales/es/translation.json around line 33, the key
"Password_and_Confirm_password_mismatches" should be removed and replaced by a
single standardized key "passwordMismatches" with the same Spanish value
("Contraseña y Confirmar contraseña no coinciden."). Update all code references
to use "passwordMismatches" instead of the old key, and apply the same key
change across other locale files to keep i18n keys consistent.

"confirmPassword": "Confirmar contraseña",
"forgotPassword": "Has olvidado tu contraseña ?",
"enterEmail": "ingrese correo electrónico",
Expand All @@ -55,38 +56,6 @@
"selectOrg": "Seleccione una organización",
"afterRegister": "Registro exitoso. Por favor, espere a que el administrador apruebe su solicitud."
},
"userLoginPage": {
"title": "Administrador Talawa",
"fromPalisadoes": "Una aplicación de código abierto de los voluntarios de la Fundación palisados",
"talawa_portal": "Portal De Administración Talawa",
"login": "Acceso",
"register": "Registro",
"firstName": "Primer nombre",
"lastName": "Apellido",
"email": "Correo electrónico",
"password": "Clave",
"atleast_8_char_long": "Al menos 8 caracteres de largo",
"Password_and_Confirm_password_mismatches.": "Contraseña y Confirmar contraseña no coinciden.",
"confirmPassword": "Confirmar contraseña",
"forgotPassword": "Has olvidado tu contraseña ?",
"enterEmail": "ingrese correo electrónico",
"enterPassword": "introducir la contraseña",
"doNotOwnAnAccount": "¿No tienes una cuenta?",
"talawaApiUnavailable": "El servicio Talawa-API no está disponible. ¿Está funcionando? Verifica también la conectividad de tu red.",
"captchaError": "¡Error de captcha!",
"Please_check_the_captcha": "Por favor, revisa el captcha.",
"Something_went_wrong": "Algo salió mal. Inténtalo después de un tiempo",
"passwordMismatches": "Contraseña y Confirmar contraseña no coinciden.",
"fillCorrectly": "Complete todos los detalles correctamente.",
"notAuthorised": "¡Lo siento! ¡No estás autorizado!",
"notFound": "¡Usuario no encontrado!",
"successfullyRegistered": "Registrado con éxito. Espere hasta que sea aprobado",
"userLogin": "Inicio de sesión de usuario",
"afterRegister": "Registrado exitosamente. Espere a que el administrador apruebe su solicitud.",
"OR": "O",
"loading": "Cargando...",
"selectOrg": "Seleccione una organización"
},
"latestEvents": {
"eventCardTitle": "Próximos Eventos",
"eventCardSeeAll": "Ver Todos",
Expand Down Expand Up @@ -1019,6 +988,12 @@
"nothingToShow": "Nada que mostrar aquí."
},
"userRegister": {
"firstName_invalid": "El nombre debe contener solo letras minúsculas y mayúsculas.",
"lastName_invalid": "El apellido debe contener solo letras minúsculas y mayúsculas.",
"password_invalid": "La contraseña debe contener al menos una letra minúscula, una letra mayúscula, un valor numérico y un carácter especial.",
"email_invalid": "El correo electrónico debe tener al menos 8 caracteres.",
"passwordMismatches": "Contraseña y Confirmar contraseña no coinciden.",
"Password_and_Confirm_password_mismatches": "Contraseña y Confirmar contraseña no coinciden.",
"register": "Registro",
Comment on lines +991 to 997
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove duplicate keys for the same error.

Keep only "passwordMismatches".

-    "passwordMismatches": "Contraseña y Confirmar contraseña no coinciden.",
-    "Password_and_Confirm_password_mismatches": "Contraseña y Confirmar contraseña no coinciden.",
+    "passwordMismatches": "Contraseña y Confirmar contraseña no coinciden.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"firstName_invalid": "El nombre debe contener solo letras minúsculas y mayúsculas.",
"lastName_invalid": "El apellido debe contener solo letras minúsculas y mayúsculas.",
"password_invalid": "La contraseña debe contener al menos una letra minúscula, una letra mayúscula, un valor numérico y un carácter especial.",
"email_invalid": "El correo electrónico debe tener al menos 8 caracteres.",
"passwordMismatches": "Contraseña y Confirmar contraseña no coinciden.",
"Password_and_Confirm_password_mismatches": "Contraseña y Confirmar contraseña no coinciden.",
"register": "Registro",
"firstName_invalid": "El nombre debe contener solo letras minúsculas y mayúsculas.",
"lastName_invalid": "El apellido debe contener solo letras minúsculas y mayúsculas.",
"password_invalid": "La contraseña debe contener al menos una letra minúscula, una letra mayúscula, un valor numérico y un carácter especial.",
"email_invalid": "El correo electrónico debe tener al menos 8 caracteres.",
"passwordMismatches": "Contraseña y Confirmar contraseña no coinciden.",
"register": "Registro",
🤖 Prompt for AI Agents 
In public/locales/es/translation.json around lines 991 to 997 there are
duplicate keys for the same error ("passwordMismatches" and
"Password_and_Confirm_password_mismatches"); remove the duplicate
"Password_and_Confirm_password_mismatches" entry and keep only
"passwordMismatches", ensuring the JSON remains valid (no trailing commas) and
that the retained key's value is the expected Spanish string.

"firstName": "Nombre de pila",
"enterFirstName": "Ponga su primer nombre",
Expand Down
43 changes: 9 additions & 34 deletions public/locales/fr/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,16 @@
"loginPage": {
"title": "Administrateur Talawa",
"fromPalisadoes": "Une application open source réalisée par les bénévoles de la Fondation Palisadoes",
"userLogin": "Utilisateur en ligne",
"userLogin": "Connexion",
"loginSubHead": "Connexion à votre compte",
"adminLogin": "Connexion administrateur",
"atleast_8_char_long": "Au moins 8 caractères",
"atleast_6_char_long": "Au moins 6 caractères",
"firstName_invalid": "Le prénom ne doit contenir que des lettres minuscules et majuscules",
"lastName_invalid": "Le nom de famille ne doit contenir que des lettres minuscules et majuscules",
"password_invalid": "Le mot de passe doit contenir au moins une lettre minuscule, une lettre majuscule, une valeur numérique et un caractère spécial",
"email_invalid": "L'e-mail doit contenir au moins 8 caractères",
"Password_and_Confirm_password_mismatches.": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"Password_and_Confirm_password_mismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Unify password‑mismatch key across app.

Remove "Password_and_Confirm_password_mismatches"; use "passwordMismatches" everywhere to avoid duplicated strings and usage.

-    "Password_and_Confirm_password_mismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",

Ensure components reference t('...passwordMismatches'). Based on learnings, standardize i18n keys.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In public/locales/fr/translation.json around line 26, remove the redundant key
"Password_and_Confirm_password_mismatches" and replace it with the standardized
key "passwordMismatches" (keeping the French string value), then scan the
codebase for any references to the old key and update them to
t('passwordMismatches') so all components use the unified i18n key.

"doNotOwnAnAccount": "Vous ne possédez pas de compte ?",
"captchaError": "Erreur CAPTCHA!",
"Please_check_the_captcha": "S'il vous plaît, vérifiez le captcha.",
Expand Down Expand Up @@ -55,38 +56,6 @@
"user": "Utilisateur",
"loading": "Chargement"
},
"userLoginPage": {
"title": "Administrateur Talawa",
"fromPalisadoes": "Une application open source réalisée par les bénévoles de la Fondation Palisadoes",
"atleast_8_char_long": "Au moins 8 caractères",
"Password_and_Confirm_password_mismatches.": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"doNotOwnAnAccount": "Vous ne possédez pas de compte ?",
"captchaError": "Erreur CAPTCHA!",
"Please_check_the_captcha": "S'il vous plaît, vérifiez le captcha.",
"Something_went_wrong": "Quelque chose s'est mal passé. Veuillez réessayer plus tard.",
"passwordMismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"fillCorrectly": "Remplissez correctement tous les détails.",
"successfullyRegistered": "Enregistré avec succès. ",
"userLogin": "Utilisateur en ligne",
"afterRegister": "Enregistré avec succès. ",
"selectOrg": "Sélectionnez une organisation",
"talawa_portal": "Portail Talawa",
"login": "Connexion",
"register": "S'inscrire",
"firstName": "Prénom",
"lastName": "Nom de famille",
"email": "E-mail",
"password": "Mot de passe",
"confirmPassword": "Confirmer le mot de passe",
"forgotPassword": "Mot de passe oublié",
"enterEmail": "Entrer l'e-mail",
"enterPassword": "Entrer le mot de passe",
"talawaApiUnavailable": "API Talawa indisponible",
"notAuthorised": "Non autorisé",
"notFound": "Non trouvé",
"OR": "OU",
"loading": "Chargement"
},
"latestEvents": {
"eventCardTitle": "évènements à venir",
"eventCardSeeAll": "Voir tout",
Expand Down Expand Up @@ -1019,6 +988,12 @@
"talawaApiUnavailable": "API Talawa non disponible"
},
"userRegister": {
"firstName_invalid": "Le prénom ne doit contenir que des lettres minuscules et majuscules",
"lastName_invalid": "Le nom de famille ne doit contenir que des lettres minuscules et majuscules",
"password_invalid": "Le mot de passe doit contenir au moins une lettre minuscule, une lettre majuscule, une valeur numérique et un caractère spécial",
"email_invalid": "L'e-mail doit contenir au moins 8 caractères",
"Password_and_Confirm_password_mismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"passwordMismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"enterFirstName": "Entrez votre prénom",
Comment on lines +991 to 997
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Deduplicate mismatch keys in userRegister.

Keep only "passwordMismatches".

-    "Password_and_Confirm_password_mismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
-    "passwordMismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
+    "passwordMismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"firstName_invalid": "Le prénom ne doit contenir que des lettres minuscules et majuscules",
"lastName_invalid": "Le nom de famille ne doit contenir que des lettres minuscules et majuscules",
"password_invalid": "Le mot de passe doit contenir au moins une lettre minuscule, une lettre majuscule, une valeur numérique et un caractère spécial",
"email_invalid": "L'e-mail doit contenir au moins 8 caractères",
"Password_and_Confirm_password_mismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"passwordMismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"enterFirstName": "Entrez votre prénom",
"firstName_invalid": "Le prénom ne doit contenir que des lettres minuscules et majuscules",
"lastName_invalid": "Le nom de famille ne doit contenir que des lettres minuscules et majuscules",
"password_invalid": "Le mot de passe doit contenir au moins une lettre minuscule, une lettre majuscule, une valeur numérique et un caractère spécial",
"email_invalid": "L'e-mail doit contenir au moins 8 caractères",
"passwordMismatches": "Mot de passe et Confirmer les incompatibilités de mot de passe.",
"enterFirstName": "Entrez votre prénom",
🤖 Prompt for AI Agents 
In public/locales/fr/translation.json around lines 991 to 997, there are two
duplicate keys for the same message ("Password_and_Confirm_password_mismatches"
and "passwordMismatches"); remove the "Password_and_Confirm_password_mismatches"
entry and keep only "passwordMismatches" with the existing French translation
string, ensuring that no duplicate keys remain and JSON syntax remains valid
(commas adjusted as needed).

"enterLastName": "Entrez votre nom de famille",
"enterConfirmPassword": "Entrez votre mot de passe pour confirmer",
Expand Down
43 changes: 9 additions & 34 deletions public/locales/hi/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,16 @@
"loginPage": {
"title": "तालावा व्यवस्थापक",
"fromPalisadoes": "Palisadoes फाउंडेशन स्वयंसेवकों द्वारा विकसित एक ओपन-सोर्स एप्लिकेशन",
"userLogin": "उपयोगकर्ता लॉगिन",
"userLogin": "लॉगिन",
"loginSubHead": "अपने खाते में लॉगिन करें",
"adminLogin": "एडमिन लॉगिन",
"atleast_8_char_long": "कम से कम 8 अक्षर लंबे",
"atleast_6_char_long": "कम से कम 6 अक्षर लंबे",
"firstName_invalid": "पहला नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"lastName_invalid": "अंतिम नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"password_invalid": "पासवर्ड में कम से कम 1 छोटा अक्षर, 1 बड़ा अक्षर, 1 संख्या और 1 विशेष अक्षर होना चाहिए",
"email_invalid": "ईमेल में कम से कम 8 अक्षर होने चाहिए",
"Password_and_Confirm_password_mismatches.": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"Password_and_Confirm_password_mismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Standardize password mismatch key (use one key only).

Avoid keeping both "Password_and_Confirm_password_mismatches" and "passwordMismatches". Pick one canonical key (recommend: "passwordMismatches") across loginPage and userRegister to prevent drift.

Apply:

-    "Password_and_Confirm_password_mismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",

Then ensure all UI uses "passwordMismatches". Based on learnings, standardize i18n keys.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
public/locales/hi/translation.json around lines 26 to 26: the file contains a
nonstandard i18n key "Password_and_Confirm_password_mismatches"; replace it with
the canonical key "passwordMismatches" (remove the old key entry and add the
translation under "passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं
खाते।"), then search the codebase (loginPage and userRegister components and any
other UI files) for occurrences of "Password_and_Confirm_password_mismatches" or
similar variants and update them to use "passwordMismatches" so only the single
canonical key is referenced everywhere.

"doNotOwnAnAccount": "कोई खाता नहीं है?",
"captchaError": "कैप्चा त्रुटि!",
"Please_check_the_captcha": "कृपया कैप्चा जांचें।",
Expand Down Expand Up @@ -55,38 +56,6 @@
"user": "उपयोगकर्ता",
"loading": "लोड हो रहा है"
},
"userLoginPage": {
"title": "तालावा व्यवस्थापक",
"fromPalisadoes": "Palisadoes फाउंडेशन स्वयंसेवकों द्वारा विकसित एक ओपन-सोर्स एप्लिकेशन",
"atleast_8_char_long": "कम से कम 8 अक्षर लंबे",
"Password_and_Confirm_password_mismatches.": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"doNotOwnAnAccount": "कोई खाता नहीं है?",
"captchaError": "कैप्चा त्रुटि!",
"Please_check_the_captcha": "कृपया कैप्चा जांचें।",
"Something_went_wrong": "कुछ गलत हो गया, कृपया बाद में पुनः प्रयास करें।",
"passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"fillCorrectly": "सभी विवरण सही ढंग से भरें।",
"successfullyRegistered": "सफलतापूर्वक पंजीकृत।",
"userLogin": "उपयोगकर्ता लॉगिन",
"afterRegister": "सफलतापूर्वक पंजीकृत।",
"selectOrg": "एक संगठन चुनें",
"talawa_portal": "तालावा पोर्टल",
"login": "लॉगिन",
"register": "पंजीकरण",
"firstName": "पहला नाम",
"lastName": "अंतिम नाम",
"email": "ईमेल",
"password": "पासवर्ड",
"confirmPassword": "पुष्टि पासवर्ड",
"forgotPassword": "पासवर्ड भूल गए",
"enterEmail": "ईमेल दर्ज करें",
"enterPassword": "पासवर्ड दर्ज करें",
"talawaApiUnavailable": "तालावा एपीआई अनुपलब्ध",
"notAuthorised": "अनधिकृत",
"notFound": "नहीं मिला",
"OR": "या",
"loading": "लोड हो रहा है"
},
"latestEvents": {
"eventCardTitle": "आगामी घटनाएँ",
"eventCardSeeAll": "सभी देखें",
Expand Down Expand Up @@ -1019,6 +988,12 @@
"talawaApiUnavailable": "Talawa API अनुपलब्ध"
},
"userRegister": {
"firstName_invalid": "पहला नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"lastName_invalid": "अंतिम नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"password_invalid": "पासवर्ड में कम से कम 1 छोटा अक्षर, 1 बड़ा अक्षर, 1 संख्या और 1 विशेष अक्षर होना चाहिए",
"email_invalid": "ईमेल में कम से कम 8 अक्षर होने चाहिए",
"Password_and_Confirm_password_mismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"enterFirstName": "अपना पहला नाम दर्ज करें",
Comment on lines +991 to 997
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Duplicate validation keys for same message.

Both "Password_and_Confirm_password_mismatches" and "passwordMismatches" exist. Keep only "passwordMismatches" for consistency.

-    "Password_and_Confirm_password_mismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
-    "passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
+    "passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"firstName_invalid": "पहला नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"lastName_invalid": "अंतिम नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"password_invalid": "पासवर्ड में कम से कम 1 छोटा अक्षर, 1 बड़ा अक्षर, 1 संख्या और 1 विशेष अक्षर होना चाहिए",
"email_invalid": "ईमेल में कम से कम 8 अक्षर होने चाहिए",
"Password_and_Confirm_password_mismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"enterFirstName": "अपना पहला नाम दर्ज करें",
"firstName_invalid": "पहला नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"lastName_invalid": "अंतिम नाम केवल छोटे और बड़े अक्षरों को शामिल कर सकता है",
"password_invalid": "पासवर्ड में कम से कम 1 छोटा अक्षर, 1 बड़ा अक्षर, 1 संख्या और 1 विशेष अक्षर होना चाहिए",
"email_invalid": "ईमेल में कम से कम 8 अक्षर होने चाहिए",
"passwordMismatches": "पासवर्ड और पुष्टि पासवर्ड मेल नहीं खाते।",
"enterFirstName": "अपना पहला नाम दर्ज करें",
🤖 Prompt for AI Agents 
In public/locales/hi/translation.json around lines 991 to 997, there are
duplicate keys for the same validation message
("Password_and_Confirm_password_mismatches" and "passwordMismatches"); remove
the "Password_and_Confirm_password_mismatches" entry and keep only
"passwordMismatches" to maintain a single consistent key, then ensure the JSON
remains valid (no trailing commas) and run a quick search to confirm no code
expects the removed key.

"enterLastName": "अपना अंतिम नाम दर्ज करें",
"enterConfirmPassword": "पुष्टि करने के लिए अपना पासवर्ड दर्ज करें",
Expand Down
Loading