Increase click area for file tree nodes #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the file tree UI in the sidebar to improve usability and maintainability. The main changes include increasing the clickable area for file tree nodes and replacing specific color classes with semantic ones.
Key changes:
- Refactored the
FileTreeNodeDatatype to a discriminated union for better type safety - Restructured the tree node rendering to make the entire node clickable (not just the inner content)
- Replaced hardcoded color classes (
text-primary,text-gray-600) with semantic tokens (text-em-med)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/routes/Sidebar.svelte | Refactored file tree rendering with new click handling, unified tree node wrapper, and updated color classes to use semantic tokens |
| web/src/routes/FileHeader.svelte | Updated tree node selector to work with discriminated union type |
| web/src/routes/DiffSearch.svelte | Minor positioning adjustment for search icon |
| web/src/lib/util.ts | Refactored FileTreeNodeData to discriminated union and removed unused type exports |
| web/src/lib/diff-viewer.svelte.ts | Updated renamed file icon color class to semantic token |
| web/src/lib/components/tree/index.svelte.ts | Added depth tracking to tree nodes for dynamic indentation |
| web/src/lib/components/diff/concise-diff-view.svelte.ts | Updated imports to use types directly from their source library |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reduce the blue-500 spam