WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@khwilliamson
Copy link

No description provided.

@karenetheridge
Copy link
Member

Is there any way to test this, so someone doesn't come along later and go "well tests pass without this, so I guess it's not necessary"?

@Leont
Copy link
Member

Leont commented Dec 19, 2021

Essentially this is a constant, and hence should probably be computed in a BEGIN block?

@khwilliamson
Copy link
Author

khwilliamson commented Dec 24, 2021

Without this patch, it fails on z/OS EBCDIC with:

#   Failed test 'version for ASCII package'
#   at t/encoding.t line 27.
#          got: undef
#     expected: '1'

#   Failed test 'version for Unicode package'
#   at t/encoding.t line 28.
#          got: undef
#     expected: '2'
# Looks like you failed 2 tests of 12.
../cpan/Module-Metadata/t/encoding.t ................................. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/12 subtests

So, I guess I'm claiming there already is a test.

@khwilliamson
Copy link
Author

BEGIN block comment is now addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants