RenameProvider for variable/function renaming#2152

Open

Razmo99 wants to merge 215 commits intoPowerShell:mainfrom

Razmo99:rename-function-customvisitor

Commits on Mar 18, 2025

v3.3.0: Logging updates and dropped EOL PowerShell

andyleejordan
authored and
JustinGrote
committed
adding in rename symbol service

Razmo99
authored and
JustinGrote
committed
switched to using a task not sure if there is a better way

Razmo99
authored and
JustinGrote
committed
completed rename function

Razmo99
authored and
JustinGrote
committed
slight refactoring

Razmo99
authored and
JustinGrote
committed
Adding in unit teste for refactoring functions

Razmo99
authored and
JustinGrote
committed
test case for a function that is flat or inline

Razmo99
authored and
JustinGrote
committed
added new test case

Razmo99
authored and
JustinGrote
committed
initial commit

Razmo99
authored and
JustinGrote
committed
converted visitor class from powershell to C#

Razmo99
authored and
JustinGrote
committed
Updated to using ps1 file with a renamed varient

Razmo99
authored and
JustinGrote
committed
Bug Fixes now passing all tests

Razmo99
authored and
JustinGrote
committed
Stripped un-needed functions now using FunctionRename class

Razmo99
authored and
JustinGrote
committed
small clean up of init of class

Razmo99
authored and
JustinGrote
committed
unneeded init of class var

Razmo99
authored and
JustinGrote
committed
init commit of variable visitor class

Razmo99
authored and
JustinGrote
committed
piping for vscode rename symbol

Razmo99
authored and
JustinGrote
committed
initial tests for variable visitor class

Razmo99
authored and
JustinGrote
committed
fixing typo

Razmo99
authored and
JustinGrote
committed
adjusting scopestack to store Ast objects

Razmo99
authored and
JustinGrote
committed
added additional tests for variablerename visitor

Razmo99
authored and
JustinGrote
committed
adjusting so it finds the first variable definition within scope

Razmo99
authored and
JustinGrote
committed
added function to get variable top assignment

Razmo99
authored and
JustinGrote
committed
renamed scriptfile to scriptast

Razmo99
authored and
JustinGrote
committed
can visit binary expressions now

Razmo99
authored and
JustinGrote
committed
can visit dountil and dowhile

Razmo99
authored and
JustinGrote
committed
logic to stop start shouldrename

Razmo99
authored and
JustinGrote
committed
can visit scriptexpressions now

Razmo99
authored and
JustinGrote
committed
start stop logic for if a redefinition is found

Razmo99
authored and
JustinGrote
committed
formatting

Razmo99
authored and
JustinGrote
committed
implemented visithastable

Razmo99
authored and
JustinGrote
committed
function to determine if a node is within a targets scope

Razmo99
authored and
JustinGrote
committed
adjusted get variable top assignment for better detection

Razmo99
authored and
JustinGrote
committed
additional test cases

Razmo99
authored and
JustinGrote
committed
additional tests

Razmo99
authored and
JustinGrote
committed
added break for finding the top variable assignment

Razmo99
authored and
JustinGrote
committed
implemented visit command parameter

Razmo99
authored and
JustinGrote
committed
implemented visit member expression

Razmo99
authored and
JustinGrote
committed
implemented visitparentexpression

Razmo99
authored and
JustinGrote
committed
altered logic for variable renamed to check operator is equals

Razmo99
authored and
JustinGrote
committed
removing examples file

Razmo99
authored and
JustinGrote
committed
formatting and additional test

Razmo99
authored and
JustinGrote
committed
formatting and proper sorting for gettestscript

Razmo99
authored and
JustinGrote
committed
additional test data

Razmo99
authored and
JustinGrote
committed
reworked class so that oldname is no longer needed

Razmo99
authored and
JustinGrote
committed
implemented some new visitors

Razmo99
authored and
JustinGrote
committed
early start on commandparameter renaming

Razmo99
authored and
JustinGrote
committed
more implementations and some formatting

Razmo99
authored and
JustinGrote
committed
logic to determin if we are renaming a var or parameter

Razmo99
authored and
JustinGrote
committed
additional test

Razmo99
authored and
JustinGrote
committed
additional tests for parameters

Razmo99
authored and
JustinGrote
committed
adjusting checks for parameters

Razmo99
authored and
JustinGrote
committed
case insensitive compare & adjustment for get ast parent scope to favour functions

Razmo99
authored and
JustinGrote
committed
initial implentation of prepare rename provider

Razmo99
authored and
JustinGrote
committed
new test to handle detection for if the target function is a param ast

Razmo99
authored and
JustinGrote
committed
new exception for when dot sourcing is detected

Razmo99
authored and
JustinGrote
committed
added more detection and errors for prepare rename symbol

Razmo99
authored and
JustinGrote
committed
new exception for when the function definition cannot be found

Razmo99
authored and
JustinGrote
committed
no longer using trygetsymbolatposition as it doesnt detect parameterAst tokents

Razmo99
authored and
JustinGrote
committed
further adjustments to detection

Razmo99
authored and
JustinGrote
committed
switched to processing using iteration to avoid stack overflow

Razmo99
authored and
JustinGrote
committed
Fixing typo

Razmo99
authored and
JustinGrote
committed
Switching tests to use iterative class

Razmo99
authored and
JustinGrote
committed
init version of the variable rename iterative

Razmo99
authored and
JustinGrote
committed
switched tests and vscode to use iterative class

Razmo99
authored and
JustinGrote
committed
new test to check for method with the same parameter name

Razmo99
authored and
JustinGrote
committed
fixing up tests for VariableParameterCommandWithSameName

Razmo99
authored and
JustinGrote
committed
fixing up tests

Razmo99
authored and
JustinGrote
committed
adjusting tests for more complexity

Razmo99
authored and
JustinGrote
committed
now adds Alias on commandParameterRenaming

Razmo99
authored and
JustinGrote
committed
refactored alias creation for readability

Razmo99
authored and
JustinGrote
committed
updated prepeare rename symbol to use iterative and added msg for if symbol isnt found

Razmo99
authored and
JustinGrote
committed
renamed renamevariableiterative to IterativeVariableRename

Razmo99
authored and
JustinGrote
committed
using switch instead of else if

Razmo99
authored and
JustinGrote
committed
formatting for rename symbol

Razmo99
authored and
JustinGrote
committed
moved Function shared test content into its own folder

Razmo99
authored and
JustinGrote
committed
New Test for splatted variable parameter renaming

Razmo99
authored and
JustinGrote
committed
first stage of supporting symbol renaming for splatted command Ast calls

Razmo99
authored and
JustinGrote
committed
split out exceptions into generic file

Razmo99
authored and
JustinGrote
committed
updated to use its own internal version

Razmo99
authored and
JustinGrote
committed
added functionality to reverse lookup the top variable from a splat

Razmo99
authored and
JustinGrote
committed
Detter symbol detection was timing out on larger files

Razmo99
authored and
JustinGrote
committed
added utilities for common renaming functions updated tests

Razmo99
authored and
JustinGrote
committed
adjusted rename to use utilities

Razmo99
authored and
JustinGrote
committed
added comments to NewSplattedModification

Razmo99
authored and
JustinGrote
committed
adjusted test to use -username param instead of -password due to Alias creation

Razmo99
authored and
JustinGrote
committed
extracted method of LookForParentOfType from GetFuncDecFromCommAst

Razmo99
authored and
JustinGrote
committed
adjusted LookForParent so it accepts multiple types to look for

Razmo99
authored and
JustinGrote
committed
adjusting iterative functions to use LookForParentOfType method

Razmo99
authored and
JustinGrote
committed
Moved GetAstNodeByLineAndColumn to a generic method

Razmo99
authored and
JustinGrote
committed
updated visitors to use generic GetAstNodeByLineAndColumn

Razmo99
authored and
JustinGrote
committed
formatting moved GetFunctionDefByCommandAst to Utilities

Razmo99
authored and
JustinGrote
committed
Refactoring to use Utilities class for generic methods

Razmo99
authored and
JustinGrote
committed
Renaming methods to be clearer

Razmo99
authored and
JustinGrote
committed
Added a test to get a function definition ast

Razmo99
authored and
JustinGrote
committed
additional checks in getast for namedblock detection

Razmo99
authored and
JustinGrote
committed
formatting an new test for finding a function

Razmo99
authored and
JustinGrote
committed
reworked GetAst for better detection

Razmo99
authored and
JustinGrote
committed
additional changes to getast utility method

Razmo99
authored and
JustinGrote
committed
reverting changes from bad merge request pull

Razmo99
authored and
JustinGrote
committed
removing unused properties of the class

Razmo99
authored and
JustinGrote
committed
migrated FunctionDefinitionNotFoundException to exceptions.cs

Razmo99
authored and
JustinGrote
committed
removed original recursive visitor classes

Razmo99
authored and
JustinGrote
committed
removed unsued class properties from function visitor

Razmo99
authored and
JustinGrote
committed
condensing if statements

Razmo99
authored and
JustinGrote
committed
Broke up Process node into 3 sub functions for readability

Razmo99
authored and
JustinGrote
committed
fixing comment grammar

Razmo99
authored and
JustinGrote
committed
New Method and tests to check if a script ast contains dot sourcing

Razmo99
authored and
JustinGrote
committed
finalised dot source detection and notification

Razmo99
authored and
JustinGrote
committed
fixing spelling / naming mistakes

Razmo99
authored and
JustinGrote
committed
removing .vscode files

Razmo99
authored and
JustinGrote
committed
deleting package-lock.json

Razmo99
authored and
JustinGrote
committed
cleaning up comments and removed unused code

Razmo99
authored and
JustinGrote
committed
Adjusted refactoring Tests to use IAsyncLifetime instead of IDisposable

Razmo99
authored and
JustinGrote
committed
Fix Path.Combine to be cross platform
JustinGrote
committed
Fixing an odd edge case, of not being to rename a variable directly under a function definition, but selecting one column to the right worked

Razmo99
authored and
JustinGrote
committed
added tests and logic for duplicate assignment cases for; foreach and for loops

Razmo99
authored and
JustinGrote
committed
Adding in out of scope $i to test case which shouldnt be renamed

Razmo99
authored and
JustinGrote
committed
.net 8 requires a newline at the start of the script to recognise the scriptAST correctly otherwise it just picks up the $a = 1..5

Razmo99
authored and
JustinGrote
committed
fixing type in test name

Razmo99
authored and
JustinGrote
committed
CommandAst input was being sent to variable renamer not function renamer, proper error return's now when renaming commandAST thats not defined in the script file

Razmo99
authored and
JustinGrote
committed
additional condition so that a function CommandAst will not be touched if it exists before the functions definition

Razmo99
authored and
JustinGrote
committed
Making RenameSymbolParams public for xunit serializer

Razmo99
authored and
JustinGrote
committed
Renamed Test .ps1 to match class property name, reworked test cases to use TheoryData / parameterized tests

Razmo99
authored and
JustinGrote
committed
consolidated tests as their are no special requirements

Razmo99
authored and
JustinGrote
committed
moved serializer and getmodifiedscriptcontent seperate file as it will be reused for variable tests

Razmo99
authored and
JustinGrote
committed
Adding missing test case renamed.ps1 varient

Razmo99
authored and
JustinGrote
committed
removing unused test case data

Razmo99
authored and
JustinGrote
committed
updated GetModifiedScript with changes from the VariableRenameTests, which is just sorting the changes

Razmo99
authored and
JustinGrote
committed
modified variable test cases to use parameterized test cases

Razmo99
authored and
JustinGrote
committed
Added a new test case for renaming an inner variable leaking out the functions scope

Razmo99
authored and
JustinGrote
committed
reworked applicable utilities tests to be parameterized

Razmo99
authored and
JustinGrote
committed
Added test case for simple function parameter rename, added clause for is target is within a parameter block within a function to solve

Razmo99
authored and
JustinGrote
committed
adding plumbling for shouldgenerateAlias on server side

Razmo99
authored and
JustinGrote
committed
Passing through shouldGenerateAlias to VariableVisitor Class

Razmo99
authored and
JustinGrote
committed
added new test cases for functions with variables defined outside of scope and a helper method IsVariableExpressionAssignedInTargetScope

Razmo99
authored and
JustinGrote
committed
renaming ShouldGenerateAlias to create CreateAlias

Razmo99
authored and
JustinGrote
committed
Add Missing Disclaimer
JustinGrote
committed
Explicitly Show Unsaved Files as currently unsupported. It's probably doable but will take work
JustinGrote
committed
Move all Handling to OmniSharp LSP types
JustinGrote
committed
Move HandlerError
JustinGrote
committed
Rework initial AST filter
JustinGrote
committed
Reorganize Tests under Handler folder
JustinGrote
committed
Lots of removing of custom types. Currently broken until I create a ScriptExtent/Position Adapter
JustinGrote
committed
Rework RenameHandler to use Adapters
JustinGrote
committed
Fix namespacing
JustinGrote
committed
Remove Alias from tests for now, will have separate Alias test in future
JustinGrote
committed
Default CreateAlias to false per feedback
JustinGrote
committed
Reworked Visitor to use ScriptPositionAdapter
JustinGrote
committed
Fixup tests with default PowerShell Formatting
JustinGrote
committed
Refine VariableVisitor to use ScriptExtentAdapter
JustinGrote
committed
Extract some duplicate functions and enable NRT checking for RenameHandler
JustinGrote
committed
Add initial EUA prompt scaffolding
JustinGrote
committed
Move RenameHandler to TextDocument (more appropriate context)
JustinGrote
committed
Remove Unnecessary code
JustinGrote
committed
Split out RenameService. **TESTS NEED FIXING**
JustinGrote
committed
Introduce service to the Extension
JustinGrote
committed
Redo tests to be data-driven
JustinGrote
committed
Fixup Tests, still a bug in rename logic with functions
JustinGrote
committed
Fixed all function Prepare tests
JustinGrote
committed
Fixed all variable PrepareRenameHandler Tests
JustinGrote
committed
First Stage work to move to a more stateless AstVisitor for renames
JustinGrote
committed
Separate out AstExtensions and continue Functions Reimplement. FunctionsSingle test works at least
JustinGrote
committed
Move renameservice
JustinGrote
committed
Breakout and simplify matching logic, fixes more test cases
JustinGrote
committed
SkipChildren doesn't work for nested function situations. More tests fixed
JustinGrote
committed
All rename function tests fixed
JustinGrote
committed
Add disclaimer scaffolding (needs config)
JustinGrote
committed
Add more config setup and lock down some classes
JustinGrote
committed
Add configuration and adjust opt-in message due to server-side LSP config limitation
JustinGrote
committed
Add mocks for configuration for testing, still need to fix some parameter tests
JustinGrote
committed
Bonus Assertions
JustinGrote
committed
Fix all Tests
JustinGrote
committed
Actually fix tests (missing some pattern matching on AST types)
JustinGrote
committed
Small format adjust
JustinGrote
committed
Format Update
JustinGrote
committed
Move IterativeVariableVisitor into RenameService class
JustinGrote
committed
Remove unnecessary intermediate tests
JustinGrote
committed
Internalize rename visitor into renameservice
JustinGrote
committed
Perform initial abstraction of visitors to a base class
JustinGrote
committed
Add disclaimer link
JustinGrote
committed
Apply formatting to test fixtures
JustinGrote
committed
Fix issue with dependency injection weirdly setting Disclaimer to true and fix when dialog is closed rather than just button
JustinGrote
committed
Change name of Alias Setting
JustinGrote
committed
Make the PrepareRenameSymbol return more legible
JustinGrote
committed
Add support for negative test cases
JustinGrote
committed
I thought I fixed all these...
JustinGrote
committed
Small test fixes and naming updates
JustinGrote
committed
Move AstExtensions to Utility
JustinGrote
committed
Remove utilities as they have been moved into RenameService or AstExtensions
JustinGrote
committed
Rewrote Variable Handler, all tests passing except a stringconstant splat reference
JustinGrote
committed
Fix up Splat function finding, all tests pass
JustinGrote
committed
Clean out some dead code
JustinGrote
committed
Add name validation and related tests, also rearrange/rename some test fixtures
JustinGrote
committed
Update readme with current unsupported scenarios
JustinGrote
committed
Rework function name check to be ast based
JustinGrote
committed
Add Limitation about scriptblocks
JustinGrote
committed
Cleanup and refactor a lot of logic out to the extension functions, reduce some unnecessary ast searches
JustinGrote
committed
Simplify GetTopVariableAssignment using new extension methods
JustinGrote
committed
Add Test case and more info
JustinGrote
committed
Add Rename Parameter Alias Support
JustinGrote
committed
Add note about Get/Set variable limitation
JustinGrote
committed
Fix readme markdown formatting
JustinGrote
committed
Rolyn Lint Fixes
JustinGrote
committed
Fix closing param
JustinGrote
committed
Remove unused function
JustinGrote
committed
Fix Typo
JustinGrote
committed
Fix bad indentation
JustinGrote
committed
Implement Roslynator Recommendation
JustinGrote
committed
Add back GetFullScript
JustinGrote
committed
Remove unused script extensions
JustinGrote
committed
Fix minor script extension update
JustinGrote
committed

RenameProvider for variable/function renaming#2152Razmo99 wants to merge 215 commits intoPowerShell:mainPowerShell/PowerShellEditorServices:mainfrom Razmo99:rename-function-customvisitorRazmo99/PowerShellEditorServices:rename-function-customvisitorCopy head branch name to clipboard

Commits

Commits on Mar 18, 2025

RenameProvider for variable/function renaming#2152
Razmo99 wants to merge 215 commits intoPowerShell:mainfrom
Razmo99:rename-function-customvisitor