-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(PMD-277): give every activity a regex #10197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @@ -10,7 +10,8 @@ | |||
| "en": "Discover new games, compete for weekly prizes and share your experience with friends" | |||
| }, | |||
| "url": "gx.games", | |||
| "version": "1.0.7", | |||
| "regExp": "([a-z0-9-]+[.])*gx[.]games[/]", | |||
| "version": "1.1.0", | |||
Check failure
Code scanning / pmd
Makes sure the version is bumped
Bas950
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
113 / 1000 viewed
| "home.aliexpress.com" | ||
| ], | ||
| "version": "1.2.27", | ||
| "regExp": "(ru|pt|es|fr|de|it|nl|tr|ja|ko|th|vi|ar|he|pl|www|sale|sell|seller|helppage|report|shoppingcart|my|message|msg|trade|feedback|coupon|ilogisticsaddress|star|home)[.]aliexpress[.]com[/]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(ru|pt|es|fr|de|it|nl|tr|ja|ko|th|vi|ar|he|pl|www|sale|sell|seller|helppage|report|shoppingcart|my|message|msg|trade|feedback|coupon|ilogisticsaddress|star|home)[.]aliexpress[.]com[/]", | |
| "regExp": "([a-z0-9-]+[.])*aliexpress[.]com[/]", |
| "www.animetickets.de" | ||
| ], | ||
| "version": "1.2.29", | ||
| "regExp": "((www)[.]animeradio[.]de|(www)[.]animefanshop[.]de|(www)[.]animenews[.]de|(www)[.]animekino[.]de|(www)[.]animehamburg[.]de|(www)[.]animemesse[.]de|(www)[.]animekultur[.]de|(www)[.]animetreff[.]de|(www)[.]animefestival[.]de|(www)[.]animetickets[.]de)[/]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "((www)[.]animeradio[.]de|(www)[.]animefanshop[.]de|(www)[.]animenews[.]de|(www)[.]animekino[.]de|(www)[.]animehamburg[.]de|(www)[.]animemesse[.]de|(www)[.]animekultur[.]de|(www)[.]animetreff[.]de|(www)[.]animefestival[.]de|(www)[.]animetickets[.]de)[/]", | |
| "regExp": "(www[.])?(animeradio|animefanshop|animenews|animekino|animehamburg|animemesse|animekultur|animetreff|animefestival|animetickets)[.]de[/]", |
| "xn--trkanimeizle-dlb.com" | ||
| ], | ||
| "version": "3.0.2", | ||
| "regExp": "(anizm[.]info|anizm[.]net|anizm[.]tv|anizm[.]pro|anizm[.]store|anizm[.]tr|(anizm|dafflix|hentaizm|onepieceizle|puffytr|tranime|turkanime)[.]com[.]tr|(anizm|tranimeizle|turkanime)[.]net[.]tr|anizle[.]com|animeizleindir[.]com|animeizleindir[.]net|(animeizle|tranimeizle)[.]org[.]tr|animetr[.]fun|(test[.])?puffytr[.]com|tranimeizle[.]org|tranimeizle[.]xyz|turkanime[.]fun|turkanime[.]info|turkanime[.]pro|turkanime[.]shop|turkanime[.]store|turkanime[.]xyz|turkanimeizle[.]com|turkanimeizle[.]co|turkceanimeizle[.]org|xn--trkealtyazizle-ijb74am5a[.]com|xn--turkcealtyazizle-lqc[.]com|xn--trkeanime-s3a2u[.]com|xn--trkanimeizle-dlb[.]com)[/]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(anizm[.]info|anizm[.]net|anizm[.]tv|anizm[.]pro|anizm[.]store|anizm[.]tr|(anizm|dafflix|hentaizm|onepieceizle|puffytr|tranime|turkanime)[.]com[.]tr|(anizm|tranimeizle|turkanime)[.]net[.]tr|anizle[.]com|animeizleindir[.]com|animeizleindir[.]net|(animeizle|tranimeizle)[.]org[.]tr|animetr[.]fun|(test[.])?puffytr[.]com|tranimeizle[.]org|tranimeizle[.]xyz|turkanime[.]fun|turkanime[.]info|turkanime[.]pro|turkanime[.]shop|turkanime[.]store|turkanime[.]xyz|turkanimeizle[.]com|turkanimeizle[.]co|turkceanimeizle[.]org|xn--trkealtyazizle-ijb74am5a[.]com|xn--turkcealtyazizle-lqc[.]com|xn--trkeanime-s3a2u[.]com|xn--trkanimeizle-dlb[.]com)[/]", | |
| "regExp": "([a-z0-9-]+[.])*(anizm|anizle|animeizle(indir)?|animetr|dafflix|hentaizm|onepieceizle|puffytr|tranime(izle)?|turkanime(izle)?|turkceanimeizle|xn--trkealtyazizle-ijb74am5a|xn--turkcealtyazizle-lqc|xn--trkeanime-s3a2u|xn--trkanimeizle-dlb)([.][a-z]+)+[/]", |
| "www.bbc.com" | ||
| ], | ||
| "version": "2.2.12", | ||
| "regExp": "((www[.]bbc)[.]co[.]uk|(www)[.]bbc[.]com)[/]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "((www[.]bbc)[.]co[.]uk|(www)[.]bbc[.]com)[/]", | |
| "regExp": "(www[.])?bbc[.](com|co[.]uk)[/]", |
Bas950
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
462 / 1101 files viewed
| "brainly.ro" | ||
| ], | ||
| "version": "1.0.16", | ||
| "regExp": "(brainly[.]com|(brainly)[.]co[.]id|brainly[.]in|brainly[.]ro)[/]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(brainly[.]com|(brainly)[.]co[.]id|brainly[.]in|brainly[.]ro)[/]", | |
| "regExp": "([a-z0-9-]+[.])*brainly[.](com|co[.]id|in|ro)[/]", |
| "dominos.co.uk" | ||
| ], | ||
| "version": "1.3.25", | ||
| "regExp": "(www[.]dominos|dominos)[.]co[.]uk[/]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(www[.]dominos|dominos)[.]co[.]uk[/]", | |
| "regExp": "(www[.])?dominos[.]co[.]uk[/]", |
| @@ -27,7 +27,8 @@ | |||
| "www.hbogoasia.id", | |||
| "www.hbogoasia.ph" | |||
| ], | |||
| "version": "2.4.4", | |||
| "regExp": "(hbogo[.]ro|hbogo[.]com|hbogo[.]pl|hbogo[.]cz|hbogo[.]sk|(www[.]hbogo)[.]co[.]th|(www)[.]hbogoasia[.]my|(www)[.]hbogoasia[.]id|(www)[.]hbogoasia[.]ph)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(hbogo[.]ro|hbogo[.]com|hbogo[.]pl|hbogo[.]cz|hbogo[.]sk|(www[.]hbogo)[.]co[.]th|(www)[.]hbogoasia[.]my|(www)[.]hbogoasia[.]id|(www)[.]hbogoasia[.]ph)[/]", | |
| "regExp": "(www[.])?hbogo(asia)?[.](ro|com|pl|cz|sk|co[.]th|my|id|ph)[/]", |
| @@ -53,7 +53,8 @@ | |||
| "es.ign.com", | |||
| "tr.ign.com" | |||
| ], | |||
| "version": "1.0.2", | |||
| "regExp": "(((www|pt|br|za|adria|nl|cz|fr|de|gr|hu|in|il|it|jp|kr|latam|me|nordic|pl|sea|es|tr)[.])?ign[.]com|(www[.]ign)[.]com[.]cn)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(((www|pt|br|za|adria|nl|cz|fr|de|gr|hu|in|il|it|jp|kr|latam|me|nordic|pl|sea|es|tr)[.])?ign[.]com|(www[.]ign)[.]com[.]cn)[/]", | |
| "regExp": "([a-z0-9-]+[.])*ign[.]com([.]cn)?[/]", |
Bas950
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
749 / 1101 files viewed
| @@ -19,7 +19,8 @@ | |||
| "lazada.sg", | |||
| "www.lazada.sg" | |||
| ], | |||
| "version": "1.0.9", | |||
| "regExp": "((www[.])?lazada[.]com|(www[.])?lazada[.]co|(www[.])?lazada[.]vn|(www[.])?lazada[.]sg)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "((www[.])?lazada[.]com|(www[.])?lazada[.]co|(www[.])?lazada[.]vn|(www[.])?lazada[.]sg)[/]", | |
| "regExp": "(www[.])?lazada[.](com|co|vn|sg)[/]", |
| @@ -31,7 +31,8 @@ | |||
| "trackmania.exchange", | |||
| "blog.mania.exchange" | |||
| ], | |||
| "version": "1.1.26", | |||
| "regExp": "(((www|tm|sm|item|accounts|tmtube|api)[.])?mania-exchange[.]com|((www|tm|sm|item|accounts|tmtube|api|blog)[.])?mania[.]exchange|item[.]exchange|trackmania[.]exchange)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(((www|tm|sm|item|accounts|tmtube|api)[.])?mania-exchange[.]com|((www|tm|sm|item|accounts|tmtube|api|blog)[.])?mania[.]exchange|item[.]exchange|trackmania[.]exchange)[/]", | |
| "regExp": "([a-z0-9-]+[.])*(mania-exchange[.]com|mania[.]exchange|trackmania[.]exchange|item[.]exchange)[/]", |
| @@ -15,7 +15,8 @@ | |||
| "cloud.masuru.in.th", | |||
| "forum.masuru.in.th" | |||
| ], | |||
| "version": "1.0.6", | |||
| "regExp": "(www[.]masuru|masuru|cloud[.]masuru|forum[.]masuru)[.]in[.]th[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(www[.]masuru|masuru|cloud[.]masuru|forum[.]masuru)[.]in[.]th[/]", | |
| "regExp": "([a-z0-9-]+[.])*masuru[.]in[.]th[/]", |
| @@ -13,7 +13,8 @@ | |||
| "pokerogue.net", | |||
| "127.0.0.1" | |||
| ], | |||
| "version": "1.0.10", | |||
| "regExp": "(pokerogue[.]net|(127[.]0)[.]0[.]1)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(pokerogue[.]net|(127[.]0)[.]0[.]1)[/]", | |
| "regExp": "([a-z0-9-]+[.])*pokerogue[.]net[/]", |
| "pokerogue.net", | ||
| "127.0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "pokerogue.net", | |
| "127.0.0.1" | |
| "pokerogue.net" |
Bas950
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
980 / 1101 files viewed
| @@ -27,7 +27,8 @@ | |||
| "s2dfree.is", | |||
| "soap2day.pe" | |||
| ], | |||
| "version": "3.0.17", | |||
| "regExp": "(soap2day[.]to|soap2day[.]ac|soap2day[.]sh|soap2day[.]mx|s2dfree[.]to|s2dfree[.]cc|s2dfree[.]de|s2dfree[.]is|soap2day[.]pe)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(soap2day[.]to|soap2day[.]ac|soap2day[.]sh|soap2day[.]mx|s2dfree[.]to|s2dfree[.]cc|s2dfree[.]de|s2dfree[.]is|soap2day[.]pe)[/]", | |
| "regExp": "([a-z0-9-]+[.])*(soap2day|s2dfree)[.][a-z]+[/]", |
| @@ -17,7 +17,8 @@ | |||
| "play.sooplive.co.kr", | |||
| "vod.sooplive.co.kr" | |||
| ], | |||
| "version": "1.0.4", | |||
| "regExp": "(www[.]sooplive|play[.]sooplive|vod[.]sooplive)[.]co[.]kr[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(www[.]sooplive|play[.]sooplive|vod[.]sooplive)[.]co[.]kr[/]", | |
| "regExp": "([a-z0-9-]+[.])*sooplive[.]co[.]kr[/]", |
| @@ -33,7 +33,8 @@ | |||
| "podcasters.spotify.com", | |||
| "accounts.spotify.com" | |||
| ], | |||
| "version": "2.4.7", | |||
| "regExp": "(www|open|newsroom|artists|developer|investors|support|podcasters|accounts)[.]spotify[.]com[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(www|open|newsroom|artists|developer|investors|support|podcasters|accounts)[.]spotify[.]com[/]", | |
| "regExp": "([a-z0-9-]+[.])*spotify[.]com[/]", |
| @@ -14,7 +14,8 @@ | |||
| "www.tvnz.co.nz", | |||
| "login.tech.tvnz.co.nz" | |||
| ], | |||
| "version": "1.3.34", | |||
| "regExp": "(www[.]tvnz|login[.]tech[.]tvnz)[.]co[.]nz[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(www[.]tvnz|login[.]tech[.]tvnz)[.]co[.]nz[/]", | |
| "regExp": "([a-z0-9-]+[.])*tvnz[.]co[.]nz[/]", |
| @@ -23,7 +23,8 @@ | |||
| "original.tm-exchange.com", | |||
| "blog.tm-exchange.com" | |||
| ], | |||
| "version": "1.1.23", | |||
| "regExp": "((www|united|tmnforever|nations|sunrise|original|blog)[.])?tm-exchange[.]com[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "((www|united|tmnforever|nations|sunrise|original|blog)[.])?tm-exchange[.]com[/]", | |
| "regExp": "([a-z0-9-]+[.])*tm-exchange[.]com[/]", |
| @@ -50,7 +50,8 @@ | |||
| "devstatus.twitch.tv", | |||
| "status.twitch.tv" | |||
| ], | |||
| "version": "3.3.3", | |||
| "regExp": "(www|dashboard|brand|blog|help|affiliate|dev|discuss[.]dev|devstatus|status)[.]twitch[.]tv[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "(www|dashboard|brand|blog|help|affiliate|dev|discuss[.]dev|devstatus|status)[.]twitch[.]tv[/]", | |
| "regExp": "([a-z0-9-]+[.])*twitch[.]tv[/]", |
theusaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps prepend // to each regex to avoid mismatches like fedex.com matching x.com
Bas950
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1101 / 1101 files viewed
| @@ -95,7 +95,8 @@ | |||
| "uncyclopedia.ca", | |||
| "desciclopedia.ws" | |||
| ], | |||
| "version": "1.4.27", | |||
| "regExp": "((en|de)[.]uncyclopedia[.]co|desencyclopedie[.]org|nonsa[.]pl|nonciclopedia[.]org|eincyclopedia[.]org|(ca|la|fa|mg|yi|th|ast|sl|bg|got|hr|sk|bs|lt|et|lb|su|ro|bn|jv|cy|li|lo|ms|oc|ka|mo|ga|km|hy|sco|nn|simple|tlh|dlm|be|grc|mwl|ie|fy|vls|mn)[.]uncyclopedia[.]info|(uncyclopedia)[.]miraheze[.]org|inciclopedia[.]org|frikipaideia[.]org|absurdopedia[.]net|psyklopedin[.]org|((is|fo)[.])?ikkepedia[.]org|spademanns[.]org|hikipedia[.]org|desciclopedia[.]org|unciklopedia[.]org|uncyclopedia[.]tw|ansaikuropedia[.]org|beidipedia[.]org|((af|zea)[.])?oncyclopedia[.]org|(sr|lv|mk)[.]neciklopedija[.]org|necyklopedie[.]org|yansiklopedi[.]org|(io[.])?neciklopedio[.]org|tolololpedia[.]org|inciklopedia[.]org|(zombie)[.]pedia[.]ws|uncyclopedia[.]kr|pekepedia[.]net|desgalipedia[.]org|(www)[.]stupidedia[.]org|kamelopedia[.]net|uncyclopedia[.]ca|desciclopedia[.]ws)[/]", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "regExp": "((en|de)[.]uncyclopedia[.]co|desencyclopedie[.]org|nonsa[.]pl|nonciclopedia[.]org|eincyclopedia[.]org|(ca|la|fa|mg|yi|th|ast|sl|bg|got|hr|sk|bs|lt|et|lb|su|ro|bn|jv|cy|li|lo|ms|oc|ka|mo|ga|km|hy|sco|nn|simple|tlh|dlm|be|grc|mwl|ie|fy|vls|mn)[.]uncyclopedia[.]info|(uncyclopedia)[.]miraheze[.]org|inciclopedia[.]org|frikipaideia[.]org|absurdopedia[.]net|psyklopedin[.]org|((is|fo)[.])?ikkepedia[.]org|spademanns[.]org|hikipedia[.]org|desciclopedia[.]org|unciklopedia[.]org|uncyclopedia[.]tw|ansaikuropedia[.]org|beidipedia[.]org|((af|zea)[.])?oncyclopedia[.]org|(sr|lv|mk)[.]neciklopedija[.]org|necyklopedie[.]org|yansiklopedi[.]org|(io[.])?neciklopedio[.]org|tolololpedia[.]org|inciklopedia[.]org|(zombie)[.]pedia[.]ws|uncyclopedia[.]kr|pekepedia[.]net|desgalipedia[.]org|(www)[.]stupidedia[.]org|kamelopedia[.]net|uncyclopedia[.]ca|desciclopedia[.]ws)[/]", | |
| "regExp": "([a-z0-9-]+[.])*(uncyclopedia[.](info|co|ca|miraheze[.]org)|(desencyclopedie|nonciclopedia|eincyclopedia|inciclopedia|frikipaideia|psyklopedin|ikkepedia|spademanns|hikipedia|desciclopedia|unciklopedia|ansaikuropedia|beidipedia|oncyclopedia|neciklopedija|necyklopedie|yansiklopedi|neciklopedio|tolololpedia|inciklopedia|desgalipedia|stupidedia)[.]org|nonsa[.]pl|(absurdopedia|pekepedia|kamelopedia)[.]net|uncyclopedia[.]tw|(pedia|desciclopedia)[.]ws|uncyclopedia[.]kr)[/]", |
@theusaf |
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: Bas van Zanten <[email protected]>
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: Bas van Zanten <[email protected]>
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: Bas van Zanten <[email protected]>
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: Bas van Zanten <[email protected]>
This change is done as a preparation to require regexs for all activities to remove matching logic based on the
urlproperty which will massively improve extension performance in the future.