WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Timeraa
Copy link
Member

@Timeraa Timeraa commented Dec 3, 2025

This change is done as a preparation to require regexs for all activities to remove matching logic based on the url property which will massively improve extension performance in the future.

@Timeraa Timeraa requested review from Bas950 and theusaf December 3, 2025 13:44
@notion-workspace
Copy link

Require regExp

@@ -10,7 +10,8 @@
"en": "Discover new games, compete for weekly prizes and share your experience with friends"
},
"url": "gx.games",
"version": "1.0.7",
"regExp": "([a-z0-9-]+[.])*gx[.]games[/]",
"version": "1.1.0",

Check failure

Code scanning / pmd

Makes sure the version is bumped

Expected initial version of activity GX.games to be 1.0.0
Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

113 / 1000 viewed

"home.aliexpress.com"
],
"version": "1.2.27",
"regExp": "(ru|pt|es|fr|de|it|nl|tr|ja|ko|th|vi|ar|he|pl|www|sale|sell|seller|helppage|report|shoppingcart|my|message|msg|trade|feedback|coupon|ilogisticsaddress|star|home)[.]aliexpress[.]com[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(ru|pt|es|fr|de|it|nl|tr|ja|ko|th|vi|ar|he|pl|www|sale|sell|seller|helppage|report|shoppingcart|my|message|msg|trade|feedback|coupon|ilogisticsaddress|star|home)[.]aliexpress[.]com[/]",
"regExp": "([a-z0-9-]+[.])*aliexpress[.]com[/]",

"www.animetickets.de"
],
"version": "1.2.29",
"regExp": "((www)[.]animeradio[.]de|(www)[.]animefanshop[.]de|(www)[.]animenews[.]de|(www)[.]animekino[.]de|(www)[.]animehamburg[.]de|(www)[.]animemesse[.]de|(www)[.]animekultur[.]de|(www)[.]animetreff[.]de|(www)[.]animefestival[.]de|(www)[.]animetickets[.]de)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "((www)[.]animeradio[.]de|(www)[.]animefanshop[.]de|(www)[.]animenews[.]de|(www)[.]animekino[.]de|(www)[.]animehamburg[.]de|(www)[.]animemesse[.]de|(www)[.]animekultur[.]de|(www)[.]animetreff[.]de|(www)[.]animefestival[.]de|(www)[.]animetickets[.]de)[/]",
"regExp": "(www[.])?(animeradio|animefanshop|animenews|animekino|animehamburg|animemesse|animekultur|animetreff|animefestival|animetickets)[.]de[/]",

"xn--trkanimeizle-dlb.com"
],
"version": "3.0.2",
"regExp": "(anizm[.]info|anizm[.]net|anizm[.]tv|anizm[.]pro|anizm[.]store|anizm[.]tr|(anizm|dafflix|hentaizm|onepieceizle|puffytr|tranime|turkanime)[.]com[.]tr|(anizm|tranimeizle|turkanime)[.]net[.]tr|anizle[.]com|animeizleindir[.]com|animeizleindir[.]net|(animeizle|tranimeizle)[.]org[.]tr|animetr[.]fun|(test[.])?puffytr[.]com|tranimeizle[.]org|tranimeizle[.]xyz|turkanime[.]fun|turkanime[.]info|turkanime[.]pro|turkanime[.]shop|turkanime[.]store|turkanime[.]xyz|turkanimeizle[.]com|turkanimeizle[.]co|turkceanimeizle[.]org|xn--trkealtyazizle-ijb74am5a[.]com|xn--turkcealtyazizle-lqc[.]com|xn--trkeanime-s3a2u[.]com|xn--trkanimeizle-dlb[.]com)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(anizm[.]info|anizm[.]net|anizm[.]tv|anizm[.]pro|anizm[.]store|anizm[.]tr|(anizm|dafflix|hentaizm|onepieceizle|puffytr|tranime|turkanime)[.]com[.]tr|(anizm|tranimeizle|turkanime)[.]net[.]tr|anizle[.]com|animeizleindir[.]com|animeizleindir[.]net|(animeizle|tranimeizle)[.]org[.]tr|animetr[.]fun|(test[.])?puffytr[.]com|tranimeizle[.]org|tranimeizle[.]xyz|turkanime[.]fun|turkanime[.]info|turkanime[.]pro|turkanime[.]shop|turkanime[.]store|turkanime[.]xyz|turkanimeizle[.]com|turkanimeizle[.]co|turkceanimeizle[.]org|xn--trkealtyazizle-ijb74am5a[.]com|xn--turkcealtyazizle-lqc[.]com|xn--trkeanime-s3a2u[.]com|xn--trkanimeizle-dlb[.]com)[/]",
"regExp": "([a-z0-9-]+[.])*(anizm|anizle|animeizle(indir)?|animetr|dafflix|hentaizm|onepieceizle|puffytr|tranime(izle)?|turkanime(izle)?|turkceanimeizle|xn--trkealtyazizle-ijb74am5a|xn--turkcealtyazizle-lqc|xn--trkeanime-s3a2u|xn--trkanimeizle-dlb)([.][a-z]+)+[/]",

"www.bbc.com"
],
"version": "2.2.12",
"regExp": "((www[.]bbc)[.]co[.]uk|(www)[.]bbc[.]com)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "((www[.]bbc)[.]co[.]uk|(www)[.]bbc[.]com)[/]",
"regExp": "(www[.])?bbc[.](com|co[.]uk)[/]",

Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

462 / 1101 files viewed

"brainly.ro"
],
"version": "1.0.16",
"regExp": "(brainly[.]com|(brainly)[.]co[.]id|brainly[.]in|brainly[.]ro)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(brainly[.]com|(brainly)[.]co[.]id|brainly[.]in|brainly[.]ro)[/]",
"regExp": "([a-z0-9-]+[.])*brainly[.](com|co[.]id|in|ro)[/]",

"dominos.co.uk"
],
"version": "1.3.25",
"regExp": "(www[.]dominos|dominos)[.]co[.]uk[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(www[.]dominos|dominos)[.]co[.]uk[/]",
"regExp": "(www[.])?dominos[.]co[.]uk[/]",

@@ -27,7 +27,8 @@
"www.hbogoasia.id",
"www.hbogoasia.ph"
],
"version": "2.4.4",
"regExp": "(hbogo[.]ro|hbogo[.]com|hbogo[.]pl|hbogo[.]cz|hbogo[.]sk|(www[.]hbogo)[.]co[.]th|(www)[.]hbogoasia[.]my|(www)[.]hbogoasia[.]id|(www)[.]hbogoasia[.]ph)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(hbogo[.]ro|hbogo[.]com|hbogo[.]pl|hbogo[.]cz|hbogo[.]sk|(www[.]hbogo)[.]co[.]th|(www)[.]hbogoasia[.]my|(www)[.]hbogoasia[.]id|(www)[.]hbogoasia[.]ph)[/]",
"regExp": "(www[.])?hbogo(asia)?[.](ro|com|pl|cz|sk|co[.]th|my|id|ph)[/]",

@@ -53,7 +53,8 @@
"es.ign.com",
"tr.ign.com"
],
"version": "1.0.2",
"regExp": "(((www|pt|br|za|adria|nl|cz|fr|de|gr|hu|in|il|it|jp|kr|latam|me|nordic|pl|sea|es|tr)[.])?ign[.]com|(www[.]ign)[.]com[.]cn)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(((www|pt|br|za|adria|nl|cz|fr|de|gr|hu|in|il|it|jp|kr|latam|me|nordic|pl|sea|es|tr)[.])?ign[.]com|(www[.]ign)[.]com[.]cn)[/]",
"regExp": "([a-z0-9-]+[.])*ign[.]com([.]cn)?[/]",

Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

749 / 1101 files viewed

@@ -19,7 +19,8 @@
"lazada.sg",
"www.lazada.sg"
],
"version": "1.0.9",
"regExp": "((www[.])?lazada[.]com|(www[.])?lazada[.]co|(www[.])?lazada[.]vn|(www[.])?lazada[.]sg)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "((www[.])?lazada[.]com|(www[.])?lazada[.]co|(www[.])?lazada[.]vn|(www[.])?lazada[.]sg)[/]",
"regExp": "(www[.])?lazada[.](com|co|vn|sg)[/]",

@@ -31,7 +31,8 @@
"trackmania.exchange",
"blog.mania.exchange"
],
"version": "1.1.26",
"regExp": "(((www|tm|sm|item|accounts|tmtube|api)[.])?mania-exchange[.]com|((www|tm|sm|item|accounts|tmtube|api|blog)[.])?mania[.]exchange|item[.]exchange|trackmania[.]exchange)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(((www|tm|sm|item|accounts|tmtube|api)[.])?mania-exchange[.]com|((www|tm|sm|item|accounts|tmtube|api|blog)[.])?mania[.]exchange|item[.]exchange|trackmania[.]exchange)[/]",
"regExp": "([a-z0-9-]+[.])*(mania-exchange[.]com|mania[.]exchange|trackmania[.]exchange|item[.]exchange)[/]",

@@ -15,7 +15,8 @@
"cloud.masuru.in.th",
"forum.masuru.in.th"
],
"version": "1.0.6",
"regExp": "(www[.]masuru|masuru|cloud[.]masuru|forum[.]masuru)[.]in[.]th[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(www[.]masuru|masuru|cloud[.]masuru|forum[.]masuru)[.]in[.]th[/]",
"regExp": "([a-z0-9-]+[.])*masuru[.]in[.]th[/]",

@@ -13,7 +13,8 @@
"pokerogue.net",
"127.0.0.1"
],
"version": "1.0.10",
"regExp": "(pokerogue[.]net|(127[.]0)[.]0[.]1)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(pokerogue[.]net|(127[.]0)[.]0[.]1)[/]",
"regExp": "([a-z0-9-]+[.])*pokerogue[.]net[/]",

Comment on lines 13 to 14
"pokerogue.net",
"127.0.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pokerogue.net",
"127.0.0.1"
"pokerogue.net"

Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

980 / 1101 files viewed

@@ -27,7 +27,8 @@
"s2dfree.is",
"soap2day.pe"
],
"version": "3.0.17",
"regExp": "(soap2day[.]to|soap2day[.]ac|soap2day[.]sh|soap2day[.]mx|s2dfree[.]to|s2dfree[.]cc|s2dfree[.]de|s2dfree[.]is|soap2day[.]pe)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(soap2day[.]to|soap2day[.]ac|soap2day[.]sh|soap2day[.]mx|s2dfree[.]to|s2dfree[.]cc|s2dfree[.]de|s2dfree[.]is|soap2day[.]pe)[/]",
"regExp": "([a-z0-9-]+[.])*(soap2day|s2dfree)[.][a-z]+[/]",

@@ -17,7 +17,8 @@
"play.sooplive.co.kr",
"vod.sooplive.co.kr"
],
"version": "1.0.4",
"regExp": "(www[.]sooplive|play[.]sooplive|vod[.]sooplive)[.]co[.]kr[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(www[.]sooplive|play[.]sooplive|vod[.]sooplive)[.]co[.]kr[/]",
"regExp": "([a-z0-9-]+[.])*sooplive[.]co[.]kr[/]",

@@ -33,7 +33,8 @@
"podcasters.spotify.com",
"accounts.spotify.com"
],
"version": "2.4.7",
"regExp": "(www|open|newsroom|artists|developer|investors|support|podcasters|accounts)[.]spotify[.]com[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(www|open|newsroom|artists|developer|investors|support|podcasters|accounts)[.]spotify[.]com[/]",
"regExp": "([a-z0-9-]+[.])*spotify[.]com[/]",

@@ -14,7 +14,8 @@
"www.tvnz.co.nz",
"login.tech.tvnz.co.nz"
],
"version": "1.3.34",
"regExp": "(www[.]tvnz|login[.]tech[.]tvnz)[.]co[.]nz[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(www[.]tvnz|login[.]tech[.]tvnz)[.]co[.]nz[/]",
"regExp": "([a-z0-9-]+[.])*tvnz[.]co[.]nz[/]",

@@ -23,7 +23,8 @@
"original.tm-exchange.com",
"blog.tm-exchange.com"
],
"version": "1.1.23",
"regExp": "((www|united|tmnforever|nations|sunrise|original|blog)[.])?tm-exchange[.]com[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "((www|united|tmnforever|nations|sunrise|original|blog)[.])?tm-exchange[.]com[/]",
"regExp": "([a-z0-9-]+[.])*tm-exchange[.]com[/]",

@@ -50,7 +50,8 @@
"devstatus.twitch.tv",
"status.twitch.tv"
],
"version": "3.3.3",
"regExp": "(www|dashboard|brand|blog|help|affiliate|dev|discuss[.]dev|devstatus|status)[.]twitch[.]tv[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "(www|dashboard|brand|blog|help|affiliate|dev|discuss[.]dev|devstatus|status)[.]twitch[.]tv[/]",
"regExp": "([a-z0-9-]+[.])*twitch[.]tv[/]",

@theusaf theusaf added activity update multiple activities PR edits more than 1 activity repo maintenance General repo maintenance, including updating tools etc labels Dec 7, 2025
Copy link
Contributor

@theusaf theusaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps prepend // to each regex to avoid mismatches like fedex.com matching x.com

Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1101 / 1101 files viewed

@@ -95,7 +95,8 @@
"uncyclopedia.ca",
"desciclopedia.ws"
],
"version": "1.4.27",
"regExp": "((en|de)[.]uncyclopedia[.]co|desencyclopedie[.]org|nonsa[.]pl|nonciclopedia[.]org|eincyclopedia[.]org|(ca|la|fa|mg|yi|th|ast|sl|bg|got|hr|sk|bs|lt|et|lb|su|ro|bn|jv|cy|li|lo|ms|oc|ka|mo|ga|km|hy|sco|nn|simple|tlh|dlm|be|grc|mwl|ie|fy|vls|mn)[.]uncyclopedia[.]info|(uncyclopedia)[.]miraheze[.]org|inciclopedia[.]org|frikipaideia[.]org|absurdopedia[.]net|psyklopedin[.]org|((is|fo)[.])?ikkepedia[.]org|spademanns[.]org|hikipedia[.]org|desciclopedia[.]org|unciklopedia[.]org|uncyclopedia[.]tw|ansaikuropedia[.]org|beidipedia[.]org|((af|zea)[.])?oncyclopedia[.]org|(sr|lv|mk)[.]neciklopedija[.]org|necyklopedie[.]org|yansiklopedi[.]org|(io[.])?neciklopedio[.]org|tolololpedia[.]org|inciklopedia[.]org|(zombie)[.]pedia[.]ws|uncyclopedia[.]kr|pekepedia[.]net|desgalipedia[.]org|(www)[.]stupidedia[.]org|kamelopedia[.]net|uncyclopedia[.]ca|desciclopedia[.]ws)[/]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"regExp": "((en|de)[.]uncyclopedia[.]co|desencyclopedie[.]org|nonsa[.]pl|nonciclopedia[.]org|eincyclopedia[.]org|(ca|la|fa|mg|yi|th|ast|sl|bg|got|hr|sk|bs|lt|et|lb|su|ro|bn|jv|cy|li|lo|ms|oc|ka|mo|ga|km|hy|sco|nn|simple|tlh|dlm|be|grc|mwl|ie|fy|vls|mn)[.]uncyclopedia[.]info|(uncyclopedia)[.]miraheze[.]org|inciclopedia[.]org|frikipaideia[.]org|absurdopedia[.]net|psyklopedin[.]org|((is|fo)[.])?ikkepedia[.]org|spademanns[.]org|hikipedia[.]org|desciclopedia[.]org|unciklopedia[.]org|uncyclopedia[.]tw|ansaikuropedia[.]org|beidipedia[.]org|((af|zea)[.])?oncyclopedia[.]org|(sr|lv|mk)[.]neciklopedija[.]org|necyklopedie[.]org|yansiklopedi[.]org|(io[.])?neciklopedio[.]org|tolololpedia[.]org|inciklopedia[.]org|(zombie)[.]pedia[.]ws|uncyclopedia[.]kr|pekepedia[.]net|desgalipedia[.]org|(www)[.]stupidedia[.]org|kamelopedia[.]net|uncyclopedia[.]ca|desciclopedia[.]ws)[/]",
"regExp": "([a-z0-9-]+[.])*(uncyclopedia[.](info|co|ca|miraheze[.]org)|(desencyclopedie|nonciclopedia|eincyclopedia|inciclopedia|frikipaideia|psyklopedin|ikkepedia|spademanns|hikipedia|desciclopedia|unciklopedia|ansaikuropedia|beidipedia|oncyclopedia|neciklopedija|necyklopedie|yansiklopedi|neciklopedio|tolololpedia|inciklopedia|desgalipedia|stupidedia)[.]org|nonsa[.]pl|(absurdopedia|pekepedia|kamelopedia)[.]net|uncyclopedia[.]tw|(pedia|desciclopedia)[.]ws|uncyclopedia[.]kr)[/]",

@Bas950
Copy link
Member

Bas950 commented Dec 9, 2025

Perhaps prepend // to each regex to avoid mismatches like fedex.com matching x.com

@theusaf ^https?[:][/][/] probs even better

Bas950 and others added 4 commits December 10, 2025 09:03
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: Bas van Zanten <[email protected]>
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: Bas van Zanten <[email protected]>
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: Bas van Zanten <[email protected]>
Co-authored-by: Daniel Lau <[email protected]>
Signed-off-by: Bas van Zanten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activity update multiple activities PR edits more than 1 activity repo maintenance General repo maintenance, including updating tools etc

Development

Successfully merging this pull request may close these issues.

4 participants