-
Notifications
You must be signed in to change notification settings - Fork 350
feat:添加ins5t8025软件包 #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat:添加ins5t8025软件包 #1942
Conversation
Updated help text to clarify the driver package for the RTC chip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new driver package for the INS5T8025 RTC chip to the RT-Thread package repository. The driver is based on software I2C and has been tested locally on HC32F460.
Key Changes:
- Adds package configuration files (package.json and Kconfig) for the INS5T8025 RTC driver
- Integrates the new package into the peripherals Kconfig menu
- Provides configuration options for I2C bus selection and alarm interrupt pin
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| peripherals/ins5t8025/package.json | Defines package metadata, repository location, and versioning for the INS5T8025 driver |
| peripherals/ins5t8025/Kconfig | Provides configuration options including I2C bus name, alarm interrupt pin, and demo example enablement |
| peripherals/Kconfig | Integrates the new INS5T8025 package into the peripherals configuration menu |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| config INS5T8025_I2C_BUS | ||
| string "name of IIC bus for INS5T8025" | ||
| default "i2c2_sw" | ||
| help | ||
| Set INS5T8025 I2C bus. |
Copilot
AI
Jan 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent terminology usage. This configuration uses "IIC" in both the option name (INS5T8025_I2C_BUS) and description, but the naming mixes I2C and IIC. The config name uses "I2C" while the description uses "IIC". For consistency, use the same term throughout (typically "I2C" is the standard abbreviation).
| default n | ||
| select RT_USING_I2C | ||
| help | ||
| A driver package for hardware RTC chip INS5T8025 on IIC bus |
Copilot
AI
Jan 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent terminology. The help text uses "IIC bus" while the standard term is "I2C bus". This should match the terminology used elsewhere in the codebase and in the package.json file.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
基于rtthread的软IIC驱动芯片ins5t8025 本地HC32F460测试成功