WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

[libcpu][arm][cortex-a] Fixup mmu setup early #11094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laidene wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[libcpu][arm][cortex-a] Fixup mmu setup early #11094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcpu/arm/cortex-a/mmu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ void rt_hw_mem_setup_early(rt_uint32_t *early_mmu_talbe,
extern unsigned char _reset;
rt_uint32_t va = (rt_uint32_t) &_reset;
/* The starting virtual address is aligned along 0x1000000. */
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states "aligned along 0x1000000" but could be more precise. Consider updating it to "aligned down to 0x1000000 (16MB) boundary" to make the direction of alignment and the boundary size clearer for future maintainers.

中文：注释表述为"aligned along 0x1000000"，但可以更精确。建议更新为"aligned down to 0x1000000 (16MB) boundary"，以便更清楚地说明对齐方向和边界大小，方便后续维护。

Suggested change
/* The starting virtual address is aligned along 0x1000000. */
/* The starting virtual address is aligned down to 0x1000000 (16MB) boundary. */

Copilot uses AI. Check for mistakes.
va &= (0x1000000 - 1);
va &= ~(0x1000000 - 1);
size -= va;
_init_map_section(early_mmu_talbe, va, size, va + pv_off, normal_attr);
#endif
Expand Down
Loading