WIP: spirv_asm: introduce InlineAsmCx to allow implementing global_asm!.
#368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
inline-asm-cx
branch
2 times, most recently
from
963ca69 to
14435cb
Compare
eddyb
force-pushed
the
inline-asm-cx
branch
from
14435cb to
17d5c2a
Compare
eddyb
force-pushed
the
inline-asm-cx
branch
from
17d5c2a to
4349311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily based on (only the last commit is specific to this PR):
line_spansfor slightly better source locations. #369I have no plans/need for this currently, but if there is a desire for
global_asm!, this approach was what I had in mind back in early 2021 (from when I have had this branch lingering around my local checkout).I don't really like the bit of code duplication, and more fine-grained
Spans should be possible, but without some tests this is not really going to ever do much anyway.