rustfmt: manually split up string literals crossing the maximum line width. #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an unfortunate
rustfmtbug/limitation, where string literals that cross the max width breaks reformatting in everything it's nested in.The resulting files were tested for reformatting ability by (un)indenting the entire file (e.g.
Ctrl+A Tab Ctrl+Sin VSCode), and inspecting the resulting diff - complete success leads to only whitespace changes in lines that are string\continuations (becauserustfmtdoesn't touch those).In fact, to ensure all instances are caught, I ended up doing this instead:
(sadly, macros also don't get reformatted, so this is a bit annoying to skim, but still useful)
You can see in the diff that there was some positive overall impact by looking for formatting changes that are not directly around the changed strings, but rather in nearby (sibling-ish) AST nodes.