kem: add KeyInit support to Decapsulate
#2056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This notably provides a common way to initialize KEM decapsulation keys along with a common way to do key generation
Member
Author
|
cc @rozbb |
tarcieri
changed the title
KeyInit support to DecapsulatorKeyInit support to Decapsulate
newpavlov
reviewed
Oct 30, 2025
| /// Often, this will just be a secret key. But, as with [`Encapsulate`], it can be a bundle | ||
| /// of secret keys, or it can include a sender's private key for authenticated encapsulation. | ||
| pub trait Decapsulate<EK, SS> { | ||
| pub trait Decapsulate<EK, SS>: KeyInit { |
Member
There was a problem hiding this comment.
Are you sure that KeyInit should be a super trait of Decapsulate? Couldn't Decapsulate in theory be implemented on top of a HSM?
Member
Author
There was a problem hiding this comment.
Good point. I guess I'll close this, but perhaps we can use KeyInit by convention in the KEM crates.
Member
There was a problem hiding this comment.
It may be worth to re-export KeyInit from kem to promote its use.
tarcieri
added a commit
that referenced
this pull request
Oct 30, 2025
Encourages the use of these traits for initializing decapsulators that impl the `Decapsulate` type. (This is effectively #2056 without the supertrait bound)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notably provides a common way to initialize KEM decapsulation keys along with a common way to do key generation