Bump rand_core to v0.10.0-rc-2
#2063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
rand_core/v0.10.0-rc-2
branch
2 times, most recently
from
7974444 to
c9cce6c
Compare
Member
Author
|
I guess another way to solve this would be to remove |
Member
Author
|
#2064 switches (back) to using |
tarcieri
added a commit
that referenced
this pull request
Nov 5, 2025
Replaces usages of `OsRng` with `getrandom`, and `OsError` with `getrandom::Error`. In `rand_core` v0.10 prereleases, `OsRng` has been moved to the `rand` crate (at least for now). The `rand` crate also depends on `chacha20`, so if we were to depend on `rand` it would create a circular dependency. We can avoid this circular dependency by using `getrandom` directly. By changing the feature name back to `getrandom`, it also matches the existing feature name in stable releases, which is one less thing people need to change in updates. Since `aead` was consuming `OsRng` via `crypto-common`, the latter has been changed to re-export `getrandom`. See also: #1379, #1746, #2063
tarcieri
force-pushed
the
rand_core/v0.10.0-rc-2
branch
from
c9cce6c to
8addf55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
OsRnghas been moved torand, andranddepends onchacha20which depends oncipher->crypto-commonwhich needs access toOsRng, this temporarily vendors the relevant code (which is a thin wrapper aroundgetrandom) until we can sort out a better solution for accessingOsRngwithout creating a circular dependency onrand.cc @dhardy